<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19286">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Fix trailing whitespace in several files<br><br>Change-Id: Ide9921dfce3b6d7c580edaa612a3063c94319a02<br>---<br>M include/osmocom/bsc/abis_nm.h<br>M src/osmo-bsc/bts_nokia_site.c<br>M src/osmo-bsc/bts_siemens_bs11.c<br>M src/osmo-bsc/codec_pref.c<br>M src/osmo-bsc/handover_vty.c<br>M src/osmo-bsc/lchan_fsm.c<br>M src/osmo-bsc/pcu_sock.c<br>7 files changed, 9 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/abis_nm.h b/include/osmocom/bsc/abis_nm.h</span><br><span>index 83bc2f8..3a0cb0e 100644</span><br><span>--- a/include/osmocom/bsc/abis_nm.h</span><br><span>+++ b/include/osmocom/bsc/abis_nm.h</span><br><span>@@ -1,4 +1,4 @@</span><br><span style="color: hsl(0, 100%, 40%);">-/* GSM Network Management messages on the A-bis interface </span><br><span style="color: hsl(120, 100%, 40%);">+/* GSM Network Management messages on the A-bis interface</span><br><span> * 3GPP TS 12.21 version 8.0.0 Release 1999 / ETSI TS 100 623 V8.0.0 */</span><br><span> </span><br><span> /* (C) 2008-2009 by Harald Welte <laforge@gnumonks.org></span><br><span>@@ -151,7 +151,7 @@</span><br><span> int abis_nm_ipaccess_set_attr(struct gsm_bts *bts, uint8_t obj_class,</span><br><span> uint8_t bts_nr, uint8_t trx_nr, uint8_t ts_nr,</span><br><span> uint8_t *attr, uint8_t attr_len);</span><br><span style="color: hsl(0, 100%, 40%);">-int abis_nm_ipaccess_rsl_connect(struct gsm_bts_trx *trx, </span><br><span style="color: hsl(120, 100%, 40%);">+int abis_nm_ipaccess_rsl_connect(struct gsm_bts_trx *trx,</span><br><span> uint32_t ip, uint16_t port, uint8_t stream);</span><br><span> void abis_nm_ipaccess_cgi(uint8_t *buf, struct gsm_bts *bts);</span><br><span> int ipac_parse_bcch_info(struct ipac_bcch_info *binf, uint8_t *buf);</span><br><span>diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c</span><br><span>index 51710b8..523c9ed 100644</span><br><span>--- a/src/osmo-bsc/bts_nokia_site.c</span><br><span>+++ b/src/osmo-bsc/bts_nokia_site.c</span><br><span>@@ -1533,7 +1533,7 @@</span><br><span> - receive ACK, start RSL link(s)</span><br><span> ACK some other messages received from the BTS.</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Probably its also possible to configure the BTS without a reset, this </span><br><span style="color: hsl(120, 100%, 40%);">+ Probably its also possible to configure the BTS without a reset, this</span><br><span> has not been tested yet.</span><br><span> */</span><br><span> </span><br><span>@@ -1608,8 +1608,8 @@</span><br><span> if (!bts->nokia.did_reset) {</span><br><span> bts->nokia.did_reset = 1;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* </span><br><span style="color: hsl(0, 100%, 40%);">- TODO: For the InSite processing the received data is </span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ TODO: For the InSite processing the received data is</span><br><span> blocked in the driver during reset.</span><br><span> Otherwise the LAPD module might assert because the InSite</span><br><span> sends garbage on the E1 line during reset.</span><br><span>diff --git a/src/osmo-bsc/bts_siemens_bs11.c b/src/osmo-bsc/bts_siemens_bs11.c</span><br><span>index 2750f8c..057a0e1 100644</span><br><span>--- a/src/osmo-bsc/bts_siemens_bs11.c</span><br><span>+++ b/src/osmo-bsc/bts_siemens_bs11.c</span><br><span>@@ -61,7 +61,7 @@</span><br><span> [NM_ATT_BS11_L1_PROT_TYPE] = { TLV_TYPE_TV },</span><br><span> [NM_ATT_BS11_BIT_ERR_THESH] = { TLV_TYPE_FIXED, 2 },</span><br><span> [NM_ATT_BS11_DIVERSITY] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(0, 100%, 40%);">- [NM_ATT_BS11_LMT_LOGON_SESSION]={ TLV_TYPE_TLV }, </span><br><span style="color: hsl(120, 100%, 40%);">+ [NM_ATT_BS11_LMT_LOGON_SESSION]={ TLV_TYPE_TLV },</span><br><span> [NM_ATT_BS11_LMT_LOGIN_TIME] = { TLV_TYPE_TLV },</span><br><span> [NM_ATT_BS11_LMT_USER_ACC_LEV] ={ TLV_TYPE_TLV },</span><br><span> [NM_ATT_BS11_LMT_USER_NAME] = { TLV_TYPE_TLV },</span><br><span>diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c</span><br><span>index be442b5..6ec6d05 100644</span><br><span>--- a/src/osmo-bsc/codec_pref.c</span><br><span>+++ b/src/osmo-bsc/codec_pref.c</span><br><span>@@ -270,7 +270,7 @@</span><br><span> static int match_amr_s15_s0(struct channel_mode_and_rate *ch_mode_rate, const struct bsc_msc_data *msc, const struct gsm_bts *bts, const struct gsm0808_speech_codec *sc_match, uint8_t perm_spch)</span><br><span> {</span><br><span> uint16_t amr_s15_s0_supported;</span><br><span style="color: hsl(0, 100%, 40%);">- </span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Normally the MSC should never try to advertise an AMR codec</span><br><span> * configuration that we did not previously advertised as supported.</span><br><span> * However, to ensure that no unsupported AMR codec configuration</span><br><span>@@ -278,7 +278,7 @@</span><br><span> * and generate an intersection. All further processing is then done</span><br><span> * with this intersection result. At the same time we will make sure</span><br><span> * that the intersection contains at least one rate setting. */</span><br><span style="color: hsl(0, 100%, 40%);">- </span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> amr_s15_s0_supported = gen_bss_supported_amr_s15_s0(msc, bts, (perm_spch == GSM0808_PERM_HR3));</span><br><span> </span><br><span> /* NOTE: The sc_match pointer points to a speech codec from the speech</span><br><span>diff --git a/src/osmo-bsc/handover_vty.c b/src/osmo-bsc/handover_vty.c</span><br><span>index e9333ec..a418aa7 100644</span><br><span>--- a/src/osmo-bsc/handover_vty.c</span><br><span>+++ b/src/osmo-bsc/handover_vty.c</span><br><span>@@ -175,4 +175,3 @@</span><br><span> </span><br><span> ho_vty_init_cmds(BTS_NODE);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index a1bf857..68eef4b 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -1015,7 +1015,7 @@</span><br><span> * TODO: that's how the code was before lchan FSM, is this correct/useful? */</span><br><span> handle_rll_rel_ind_or_conf(fi, event, data);</span><br><span> break;</span><br><span style="color: hsl(0, 100%, 40%);">- </span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> case LCHAN_EV_RTP_RELEASED:</span><br><span> case LCHAN_EV_RTP_ERROR:</span><br><span> break;</span><br><span>diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c</span><br><span>index e75c2d4..3e0b7bf 100644</span><br><span>--- a/src/osmo-bsc/pcu_sock.c</span><br><span>+++ b/src/osmo-bsc/pcu_sock.c</span><br><span>@@ -716,4 +716,3 @@</span><br><span> talloc_free(state);</span><br><span> bts->pcu_state = NULL;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19286">change 19286</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19286"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ide9921dfce3b6d7c580edaa612a3063c94319a02 </div>
<div style="display:none"> Gerrit-Change-Number: 19286 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>