<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19270">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgcp_client_pending_add(): Consider "talloc returns NULL" case<br><br>Change-Id: I43a4715fa41fba5a5506fc08e3c21ef6f9ca2521<br>---<br>M src/libosmo-mgcp-client/mgcp_client.c<br>1 file changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c</span><br><span>index eeb5e4f..bbf805b 100644</span><br><span>--- a/src/libosmo-mgcp-client/mgcp_client.c</span><br><span>+++ b/src/libosmo-mgcp-client/mgcp_client.c</span><br><span>@@ -911,6 +911,9 @@</span><br><span>      struct mgcp_response_pending *pending;</span><br><span> </span><br><span>   pending = talloc_zero(mgcp, struct mgcp_response_pending);</span><br><span style="color: hsl(120, 100%, 40%);">+    if (!pending)</span><br><span style="color: hsl(120, 100%, 40%);">+         return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>       pending->trans_id = trans_id;</span><br><span>     pending->response_cb = response_cb;</span><br><span>       pending->priv = priv;</span><br><span>@@ -943,6 +946,10 @@</span><br><span>      }</span><br><span> </span><br><span>        pending = mgcp_client_pending_add(mgcp, trans_id, response_cb, priv);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!pending) {</span><br><span style="color: hsl(120, 100%, 40%);">+               talloc_free(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+             return -ENOMEM;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span> </span><br><span>        if (msgb_l2len(msg) > 4096) {</span><br><span>             LOGP(DLMGCP, LOGL_ERROR,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19270">change 19270</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/19270"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I43a4715fa41fba5a5506fc08e3c21ef6f9ca2521 </div>
<div style="display:none"> Gerrit-Change-Number: 19270 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>