<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19241">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">iperf3: Avoid creating empty log file<br><br>Since a while ago, we avoid by default using the --logfile param to log<br>the json output to a different file, in order to stay compatible with<br>older versions of iperf3.<br>However, the local logfile was still being created, and was not<br>overwritten with the remote file with content because there's none<br>created remotely (due to reasons explained above).<br><br>Change-Id: I218ec28dc65febc7bd083d6d15854319bf4f3daf<br>---<br>M src/osmo_gsm_tester/obj/iperf3.py<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/obj/iperf3.py b/src/osmo_gsm_tester/obj/iperf3.py</span><br><span>index d61dbb1..9e084aa 100644</span><br><span>--- a/src/osmo_gsm_tester/obj/iperf3.py</span><br><span>+++ b/src/osmo_gsm_tester/obj/iperf3.py</span><br><span>@@ -117,7 +117,7 @@</span><br><span>         self.log('Starting iperf3-srv')</span><br><span>         self.log_copied = False</span><br><span>         self.run_dir = util.Dir(self.testenv.test().get_run_dir().new_dir(self.name()))</span><br><span style="color: hsl(0, 100%, 40%);">-        self.log_file = self.run_dir.new_file(IPerf3Server.LOGFILE)</span><br><span style="color: hsl(120, 100%, 40%);">+        self.log_file = self.run_dir.new_child(IPerf3Server.LOGFILE)</span><br><span>         if self.runs_locally():</span><br><span>             self.start_locally()</span><br><span>         else:</span><br><span>@@ -258,7 +258,7 @@</span><br><span>         self.log('Preparing iperf3-client connecting to %s:%d (proto=%s,time=%ds)' % (self.server.addr(), self.server.port(), self._proto, time_sec))</span><br><span>         self.log_copied = False</span><br><span>         self.run_dir = util.Dir(self.testenv.test().get_run_dir().new_dir(self.name()))</span><br><span style="color: hsl(0, 100%, 40%);">-        self.log_file = self.run_dir.new_file(IPerf3Client.LOGFILE)</span><br><span style="color: hsl(120, 100%, 40%);">+        self.log_file = self.run_dir.new_child(IPerf3Client.LOGFILE)</span><br><span> </span><br><span>         popen_args = ('iperf3', '-c',  self.server.addr(),</span><br><span>                       '-p', str(self.server.port()), '-J',</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19241">change 19241</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19241"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I218ec28dc65febc7bd083d6d15854319bf4f3daf </div>
<div style="display:none"> Gerrit-Change-Number: 19241 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>