<p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/19228">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/19228/2/src/target/trx_toolkit/transceiver.py">File src/target/trx_toolkit/transceiver.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/19228/2/src/target/trx_toolkit/transceiver.py@277">Patch Set #2, Line 277:</a> <code style="font-family:monospace,monospace">              if event == "POWEROFF":</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Aren't yo repeating the same above in POWEROFF?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/19228/2/src/target/trx_toolkit/transceiver.py@326">Patch Set #2, Line 326:</a> <code style="font-family:monospace,monospace">                      self._tx_queue.append(msg)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If you sort them here when adding them, then during clk_tick you only need to check for the few first ones, or only the first element.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/19228">change 19228</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/19228"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie66ef9667dc8d156ad578ce324941a816c07c105 </div>
<div style="display:none"> Gerrit-Change-Number: 19228 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 13 Jul 2020 08:54:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>