<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/19223">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx_toolkit/fake_trx.py: avoid using TRXList.__getitem__()<br><br>Running with cProfile shows that there are quite a lot calls:<br><br>  469896    0.254    0.000    0.254    0.000 trx_list.py:37(__getitem__)<br><br>Let's better avoid using it in performance critical parts.<br><br>Change-Id: I2bbc0a2af8218af0b9a02d8e16d4216cf602892a<br>---<br>M src/target/trx_toolkit/fake_trx.py<br>M src/target/trx_toolkit/trx_list.py<br>2 files changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/23/19223/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py</span><br><span>index 4a49fa3..82eb5b7 100755</span><br><span>--- a/src/target/trx_toolkit/fake_trx.py</span><br><span>+++ b/src/target/trx_toolkit/fake_trx.py</span><br><span>@@ -411,7 +411,7 @@</span><br><span>                               self.append_child_trx(addr, port, idx, name)</span><br><span> </span><br><span>             # Burst forwarding between transceivers</span><br><span style="color: hsl(0, 100%, 40%);">-         self.burst_fwd = BurstForwarder(self.trx_list)</span><br><span style="color: hsl(120, 100%, 40%);">+                self.burst_fwd = BurstForwarder(self.trx_list.trx_list)</span><br><span> </span><br><span>          log.info("Init complete")</span><br><span> </span><br><span>@@ -444,7 +444,7 @@</span><br><span>        def run(self):</span><br><span>               # Compose list of to be monitored sockets</span><br><span>            sock_list = []</span><br><span style="color: hsl(0, 100%, 40%);">-          for trx in self.trx_list:</span><br><span style="color: hsl(120, 100%, 40%);">+             for trx in self.trx_list.trx_list:</span><br><span>                   sock_list.append(trx.ctrl_if.sock)</span><br><span>                   sock_list.append(trx.data_if.sock)</span><br><span> </span><br><span>@@ -454,7 +454,7 @@</span><br><span>                         r_event, _, _ = select.select(sock_list, [], [])</span><br><span> </span><br><span>                         # Iterate over all transceivers</span><br><span style="color: hsl(0, 100%, 40%);">-                 for trx in self.trx_list:</span><br><span style="color: hsl(120, 100%, 40%);">+                     for trx in self.trx_list.trx_list:</span><br><span>                           # DATA interface</span><br><span>                             if trx.data_if.sock in r_event:</span><br><span>                                      msg = trx.recv_data_msg()</span><br><span>diff --git a/src/target/trx_toolkit/trx_list.py b/src/target/trx_toolkit/trx_list.py</span><br><span>index 4f9eff2..3206d74 100644</span><br><span>--- a/src/target/trx_toolkit/trx_list.py</span><br><span>+++ b/src/target/trx_toolkit/trx_list.py</span><br><span>@@ -34,6 +34,7 @@</span><br><span>   def __init__(self, trx_list = None):</span><br><span>                 self.trx_list = trx_list or []</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    # NOTE: do not use this in performance critical parts</span><br><span>        def __getitem__(self, i):</span><br><span>            return self.trx_list[i]</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/19223">change 19223</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/19223"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2bbc0a2af8218af0b9a02d8e16d4216cf602892a </div>
<div style="display:none"> Gerrit-Change-Number: 19223 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>