<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19179">View Change</a></p><div style="white-space:pre-wrap">Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">GSM_RestOctets: SI2quater fixup: rename "Cell List" to "Repeated Cells"<br><br>So far the naming is so that the EUTRAN_NeighborCell sounds like it reflects a<br>single E-ARFCN, while in fact it contains a list of E-ARFCNs. In 3GPP TS 48.018<br>it is more accurately named "Neighbor Cells", in plural.<br><br>There is another "list layer" that allows repeating these lists of E-ARFCNs,<br>which the spec names Repeated Neighbor Cells, i.e. have a list of (=repeat) the<br>lists of E-ARFCNs.<br><br> Repeated Neighbor Cells = {<br> // first cells list<br> Neighbor Cells = {<br> cell descriptions = {<br> { e_arfcn = 1, meas_bw = 3 },<br> { e_arfcn = 2, meas_bw = 3 },<br> { e_arfcn = 3, meas_bw = 3 },<br> },<br> prio, thresh, ...<br> },<br> // second cells list<br> Neighbor Cells = {<br> cell descriptions = {<br> { e_arfcn = 4, meas_bw = 3 },<br> { e_arfcn = 5, meas_bw = 3 },<br> { e_arfcn = 6, meas_bw = 3 },<br> },<br> prio, thresh, ...<br> },<br> ...<br> }<br><br>Adjust the naming of the SI2quaterRestOctets members to more closely resemble<br>this structure, adopting the naming in 3GPP TS 48.018:<br><br> EUTRAN_NeighborCell -> EUTRAN_NeighborCells<br> because it is really a collection of multiple E-ARFCNs<br><br> EUTRAN_NeighborCells -> EUTRAN_RepeatedNeighborCells<br> because it is a list of E-ARFCN lists, and 3GPP TS 48.018 names it<br> "Repeated Neighbor Cells".<br><br>Also rename the EUTRAN_NotAllowedCells accordingly.<br><br>Change-Id: Ib11d72c04cdb8997ec97321257fb58b2c113e790<br>---<br>M library/GSM_RestOctets.ttcn<br>1 file changed, 10 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSM_RestOctets.ttcn b/library/GSM_RestOctets.ttcn</span><br><span>index 3bc9349..39f15bb 100644</span><br><span>--- a/library/GSM_RestOctets.ttcn</span><br><span>+++ b/library/GSM_RestOctets.ttcn</span><br><span>@@ -350,11 +350,11 @@</span><br><span> EUTRAN_GPRSMeasParamsDescOpt gprs_meas_params_desc,</span><br><span> </span><br><span> /* { 1 < Repeated E-UTRAN Neighbour Cells > } ** 0 */</span><br><span style="color: hsl(0, 100%, 40%);">- EUTRAN_NeighbourCells neigh_cell_list optional,</span><br><span style="color: hsl(0, 100%, 40%);">- BIT1 neigh_cell_list_term ('0'B),</span><br><span style="color: hsl(120, 100%, 40%);">+ EUTRAN_RepeatedNeighbourCells repeated_neigh_cells optional,</span><br><span style="color: hsl(120, 100%, 40%);">+ BIT1 repeated_neigh_cells_term ('0'B),</span><br><span> /* { 1 < Repeated E-UTRAN Not Allowed Cells > } ** 0 */</span><br><span style="color: hsl(0, 100%, 40%);">- EUTRAN_NotAllowedCells not_allowed_cell_list optional,</span><br><span style="color: hsl(0, 100%, 40%);">- BIT1 not_allowed_cell_list_term ('0'B),</span><br><span style="color: hsl(120, 100%, 40%);">+ EUTRAN_RepeatedNotAllowedCells repeated_not_allowed_cells optional,</span><br><span style="color: hsl(120, 100%, 40%);">+ BIT1 repeated_not_allowed_cells_term ('0'B),</span><br><span> /* { 1 < Repeated E-UTRAN PCID to TA mapping > } ** 0 */</span><br><span> EUTRAN_PCID2TAMaps pcid2ta_map_list optional,</span><br><span> BIT1 pcid2ta_map_list_term ('0'B)</span><br><span>@@ -376,9 +376,9 @@</span><br><span> variant (desc) "PRESENCE(presence = '1'B)"</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Repeated E-UTRAN Neighbour Cell List */</span><br><span style="color: hsl(0, 100%, 40%);">-private type record of EUTRAN_NeighbourCell EUTRAN_NeighbourCells;</span><br><span style="color: hsl(0, 100%, 40%);">-private type record EUTRAN_NeighbourCell {</span><br><span style="color: hsl(120, 100%, 40%);">+/* Repeated E-UTRAN Neighbour Cells */</span><br><span style="color: hsl(120, 100%, 40%);">+private type record of EUTRAN_NeighbourCells EUTRAN_RepeatedNeighbourCells;</span><br><span style="color: hsl(120, 100%, 40%);">+private type record EUTRAN_NeighbourCells {</span><br><span> BIT1 item_ind ('1'B),</span><br><span> /* { 1 < Repeated E-UTRAN Neighbour Cells > } ** 0 */</span><br><span> EUTRAN_CellDescs cell_desc_list optional,</span><br><span>@@ -409,9 +409,9 @@</span><br><span> variant (meas_bw) "PRESENCE(meas_bw_presence = '1'B)"</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Repeated E-UTRAN Not Allowed Cell List */</span><br><span style="color: hsl(0, 100%, 40%);">-private type record of EUTRAN_NotAllowedCell EUTRAN_NotAllowedCells;</span><br><span style="color: hsl(0, 100%, 40%);">-private type record EUTRAN_NotAllowedCell {</span><br><span style="color: hsl(120, 100%, 40%);">+/* Repeated E-UTRAN Not Allowed Cells */</span><br><span style="color: hsl(120, 100%, 40%);">+private type record of EUTRAN_NotAllowedCells EUTRAN_RepeatedNotAllowedCells;</span><br><span style="color: hsl(120, 100%, 40%);">+private type record EUTRAN_NotAllowedCells {</span><br><span> BIT1 item_ind ('1'B),</span><br><span> /* FIXME: Not Allowed Cells : < PCID Group IE > (not implemented) */</span><br><span> BIT1 pcid_group_presence ('0'B),</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19179">change 19179</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19179"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib11d72c04cdb8997ec97321257fb58b2c113e790 </div>
<div style="display:none"> Gerrit-Change-Number: 19179 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>