<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/19171">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ttcn3-bts: Fix most OML test failing after osmo-bts shutdown optimization<br><br>Since osmo-bts.git 0a6bdb024f5429a35c56178496158c9b1c3ee032, the process<br>is quickly terminated during shutdown if no TRX is running. Since in the<br>OML tests the TTCN3 components implements the OML IPA server side, most<br>of the time when osmo-bts starts it finds no one listening on the<br>address and exits immediately. This makes respawn.sh script run osmo-bts<br>lots of times per seconds (since osmo-bts terminates quicker now). As a<br>result, it quickly consumes the 500 launch threshold and exits without<br>starting osmo-bts being launched anymore.<br>As a result, only first tests pass, and all the later ones fail because<br>osmo-bts never connects.<br><br>Let's add a sleep 1 between respawns in respawn.sh only when running OML<br>tests (not needed in the others since there's an osmo-bsc always<br>running). This also clears a lot of output in the logs of osmo-bts<br>processes restarting over and over again.<br><br>Change-Id: I10d3e1ef8325dd78f9ae2b95fbfd1c6d893bf8a4<br>---<br>M osmo-bts-master/respawn.sh<br>M ttcn3-bts-test/jenkins.sh<br>2 files changed, 11 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/71/19171/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/osmo-bts-master/respawn.sh b/osmo-bts-master/respawn.sh</span><br><span>index 2413916..31a8c06 100755</span><br><span>--- a/osmo-bts-master/respawn.sh</span><br><span>+++ b/osmo-bts-master/respawn.sh</span><br><span>@@ -2,6 +2,8 @@</span><br><span> </span><br><span> trap "kill 0" EXIT</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+SLEEP_BEFORE_RESPAWN=${SLEEP_BEFORE_RESPAWN:-0}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> i=0</span><br><span> max_i=500</span><br><span> while [ $i -lt $max_i ]; do</span><br><span>@@ -10,6 +12,10 @@</span><br><span> LAST_PID=$!</span><br><span> wait $LAST_PID</span><br><span> echo "$i: stopped pid $LAST_PID with status $?"</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ $SLEEP_BEFORE_RESPAWN -gt 0 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ echo "sleeping $SLEEP_BEFORE_RESPAWN seconds..."</span><br><span style="color: hsl(120, 100%, 40%);">+ sleep $SLEEP_BEFORE_RESPAWN</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span> i=$(expr $i + 1)</span><br><span> done</span><br><span> echo "exiting after $max_i runs"</span><br><span>diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh</span><br><span>index d85c82f..c32682c 100755</span><br><span>--- a/ttcn3-bts-test/jenkins.sh</span><br><span>+++ b/ttcn3-bts-test/jenkins.sh</span><br><span>@@ -24,6 +24,7 @@</span><br><span> start_bts() {</span><br><span> local variant</span><br><span> variant="$1"</span><br><span style="color: hsl(120, 100%, 40%);">+ sleep_time_respawn="$2"</span><br><span> echo Starting container with BTS</span><br><span> if [ -z "$variant" ]; then</span><br><span> echo ERROR: You have to specify a BTS variant</span><br><span>@@ -34,6 +35,7 @@</span><br><span> --ulimit core=-1 \</span><br><span> -v $VOL_BASE_DIR/bts:/data \</span><br><span> -v $VOL_BASE_DIR/unix:/data/unix \</span><br><span style="color: hsl(120, 100%, 40%);">+ -e "SLEEP_BEFORE_RESPAWN=$sleep_time_respawn" \</span><br><span> --name ${BUILD_TAG}-bts -d \</span><br><span> $DOCKER_ARGS \</span><br><span> $REPO_USER/osmo-bts-$IMAGE_SUFFIX \</span><br><span>@@ -127,7 +129,7 @@</span><br><span> </span><br><span> # 1) classic test suite with BSC for OML and trxcon+fake_trx</span><br><span> start_bsc</span><br><span style="color: hsl(0, 100%, 40%);">-start_bts trx</span><br><span style="color: hsl(120, 100%, 40%);">+start_bts trx 0</span><br><span> start_fake_trx</span><br><span> start_trxcon</span><br><span> start_testsuite</span><br><span>@@ -139,7 +141,7 @@</span><br><span> docker container kill ${BUILD_TAG}-fake_trx</span><br><span> docker container kill ${BUILD_TAG}-bts</span><br><span> cp virtphy/osmo-bts.cfg $VOL_BASE_DIR/bts/</span><br><span style="color: hsl(0, 100%, 40%);">-start_bts virtual</span><br><span style="color: hsl(120, 100%, 40%);">+start_bts virtual 0</span><br><span> start_virtphy</span><br><span> # ... and execute the testsuite again with different cfg</span><br><span> cp virtphy/BTS_Tests.cfg $VOL_BASE_DIR/bts-tester/</span><br><span>@@ -151,7 +153,7 @@</span><br><span> docker container kill ${BUILD_TAG}-virtphy</span><br><span> docker container kill ${BUILD_TAG}-bts</span><br><span> cp oml/osmo-bts.cfg $VOL_BASE_DIR/bts/</span><br><span style="color: hsl(0, 100%, 40%);">-start_bts trx</span><br><span style="color: hsl(120, 100%, 40%);">+start_bts trx 1</span><br><span> start_fake_trx</span><br><span> start_trxcon</span><br><span> # ... and execute the testsuite again with different cfg</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/docker-playground/+/19171">change 19171</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/docker-playground/+/19171"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I10d3e1ef8325dd78f9ae2b95fbfd1c6d893bf8a4 </div>
<div style="display:none"> Gerrit-Change-Number: 19171 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>