<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19151">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">change f_bts_0_cfg() to take a VTY port arg<br><br>Remove the 'runs on' clause, add a VTY port argument.<br>That allows using this function also on the test_CT.<br><br>Will be used by upcoming SI2quater tests.<br><br>Change-Id: Ib059d9690f92f5f76025bca2b84496716a2a4cf0<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 16 insertions(+), 16 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/51/19151/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index f6e1b2c..784375a 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -3020,7 +3020,7 @@</span><br><span> ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR}));</span><br><span> </span><br><span> f_establish_fully(ass_cmd, exp_compl);</span><br><span style="color: hsl(0, 100%, 40%);">- f_bts_0_cfg({"neighbor bts 1"});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bts_0_cfg(BSCVTY, {"neighbor bts 1"});</span><br><span> </span><br><span> var HandoverState hs := {</span><br><span> rr_ho_cmpl_seen := false,</span><br><span>@@ -3102,7 +3102,7 @@</span><br><span> var template PDU_BSSAP exp_compl := f_gen_exp_compl();</span><br><span> f_establish_fully(ass_req, exp_compl);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_bts_0_cfg({"neighbor lac 99 arfcn 123 bsic any"});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bts_0_cfg(BSCVTY, {"neighbor lac 99 arfcn 123 bsic any"});</span><br><span> f_vty_transceive(BSCVTY, "handover any to arfcn 123 bsic any");</span><br><span> </span><br><span> BSSAP.receive(tr_BSSMAP_HandoverRequired);</span><br><span>@@ -3169,7 +3169,7 @@</span><br><span> var template PDU_BSSAP exp_compl := f_gen_exp_compl();</span><br><span> f_establish_fully(ass_req, exp_compl);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_bts_0_cfg({"neighbor lac 99 arfcn 123 bsic any"});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bts_0_cfg(BSCVTY, {"neighbor lac 99 arfcn 123 bsic any"});</span><br><span> f_vty_transceive(BSCVTY, "handover any to arfcn 123 bsic any");</span><br><span> </span><br><span> BSSAP.receive(tr_BSSMAP_HandoverRequired);</span><br><span>@@ -3216,7 +3216,7 @@</span><br><span> var template PDU_BSSAP exp_compl := f_gen_exp_compl();</span><br><span> f_establish_fully(ass_req, exp_compl);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_bts_0_cfg({"neighbor lac 99 arfcn 123 bsic any"});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bts_0_cfg(BSCVTY, {"neighbor lac 99 arfcn 123 bsic any"});</span><br><span> f_vty_transceive(BSCVTY, "handover any to arfcn 123 bsic any");</span><br><span> </span><br><span> BSSAP.receive(tr_BSSMAP_HandoverRequired);</span><br><span>@@ -3301,7 +3301,7 @@</span><br><span> var template PDU_BSSAP exp_compl := f_gen_exp_compl();</span><br><span> f_establish_fully(ass_req, exp_compl);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_bts_0_cfg({"neighbor lac 99 arfcn 123 bsic any"});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bts_0_cfg(BSCVTY, {"neighbor lac 99 arfcn 123 bsic any"});</span><br><span> f_vty_transceive(BSCVTY, "handover any to arfcn 123 bsic any");</span><br><span> </span><br><span> BSSAP.receive(tr_BSSMAP_HandoverRequired);</span><br><span>@@ -3760,13 +3760,13 @@</span><br><span> </span><br><span> type record of charstring Commands;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-private function f_bts_0_cfg(Commands cmds := {}) runs on MSC_ConnHdlr</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_bts_0_cfg(TELNETasp_PT pt, Commands cmds := {})</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- f_vty_enter_cfg_bts(BSCVTY, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_enter_cfg_bts(pt, 0);</span><br><span> for (var integer i := 0; i < sizeof(cmds); i := i+1) {</span><br><span style="color: hsl(0, 100%, 40%);">- f_vty_transceive(BSCVTY, cmds[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_transceive(pt, cmds[i]);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- f_vty_transceive(BSCVTY, "end");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_transceive(pt, "end");</span><br><span> }</span><br><span> </span><br><span> private function f_cs7_inst_0_cfg(TELNETasp_PT pt, Commands cmds := {})</span><br><span>@@ -3920,7 +3920,7 @@</span><br><span> */</span><br><span> </span><br><span> log("f_tc_ho_neighbor_config: 1. No 'neighbor' config");</span><br><span style="color: hsl(0, 100%, 40%);">- f_bts_0_cfg({"no neighbors"});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bts_0_cfg(BSCVTY, {"no neighbors"});</span><br><span> f_probe_for_handover("1.a", "HO to bts 1 works, implicitly listed as neighbor (legacy behavior when none are configured)",</span><br><span> "handover any to arfcn 871 bsic 11",</span><br><span> true);</span><br><span>@@ -3948,7 +3948,7 @@</span><br><span> */</span><br><span> </span><br><span> log("f_tc_ho_neighbor_config: 2. explicit local neighbor: 'neighbor bts 1'");</span><br><span style="color: hsl(0, 100%, 40%);">- f_bts_0_cfg({"neighbor bts 1"});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bts_0_cfg(BSCVTY, {"neighbor bts 1"});</span><br><span> f_sleep(0.5);</span><br><span> </span><br><span> f_probe_for_handover("2.a", "HO to bts 1 works, explicitly listed as neighbor",</span><br><span>@@ -3970,7 +3970,7 @@</span><br><span> */</span><br><span> </span><br><span> log("f_tc_ho_neighbor_config: 3. explicit local neighbor: 'neighbor bts 2'");</span><br><span style="color: hsl(0, 100%, 40%);">- f_bts_0_cfg({"no neighbors", "neighbor bts 2"});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bts_0_cfg(BSCVTY, {"no neighbors", "neighbor bts 2"});</span><br><span> f_sleep(0.5);</span><br><span> </span><br><span> f_probe_for_handover("3.a", "HO to bts 1 doesn't work, not listed as neighbor",</span><br><span>@@ -3991,7 +3991,7 @@</span><br><span> */</span><br><span> </span><br><span> log("f_tc_ho_neighbor_config: 4. explicit remote neighbor: 'neighbor lac 99 arfcn 123 bsic 45'");</span><br><span style="color: hsl(0, 100%, 40%);">- f_bts_0_cfg({"no neighbors", "neighbor lac 99 arfcn 123 bsic 45"});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bts_0_cfg(BSCVTY, {"no neighbors", "neighbor lac 99 arfcn 123 bsic 45"});</span><br><span> f_sleep(0.5);</span><br><span> </span><br><span> f_probe_for_handover("4.a", "HO to bts 1 doesn't work, not listed as neighbor",</span><br><span>@@ -4015,7 +4015,7 @@</span><br><span> */</span><br><span> </span><br><span> log("f_tc_ho_neighbor_config: 5. explicit remote neighbor re-using ARFCN+BSIC: 'neighbor lac 99 arfcn 871 bsic 12'");</span><br><span style="color: hsl(0, 100%, 40%);">- f_bts_0_cfg({"no neighbors", "neighbor lac 99 arfcn 871 bsic 12"});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bts_0_cfg(BSCVTY, {"no neighbors", "neighbor lac 99 arfcn 871 bsic 12"});</span><br><span> f_sleep(0.5);</span><br><span> </span><br><span> f_probe_for_handover("5.a", "HO to 871-12 triggers inter-BSC HO (ignoring local cells with same ARFCN+BSIC)",</span><br><span>@@ -4034,7 +4034,7 @@</span><br><span> </span><br><span> log("f_tc_ho_neighbor_config: 6. config error: explicit local and remote neighbors with ambiguous ARFCN+BSIC:"</span><br><span> & " 'neighbor bts 2; neighbor lac 99 arfcn 871 bsic 12'");</span><br><span style="color: hsl(0, 100%, 40%);">- f_bts_0_cfg({"no neighbors", "neighbor bts 2", "neighbor lac 99 arfcn 871 bsic 12"});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bts_0_cfg(BSCVTY, {"no neighbors", "neighbor bts 2", "neighbor lac 99 arfcn 871 bsic 12"});</span><br><span> f_sleep(0.5);</span><br><span> </span><br><span> f_probe_for_handover("6.a", "HO to 871-12 is ambiguous = error",</span><br><span>@@ -4053,7 +4053,7 @@</span><br><span> </span><br><span> log("f_tc_ho_neighbor_config: 7. explicit local and remote neighbors:"</span><br><span> & " 'neighbor bts 2; neighbor lac 99 arfcn 123 bsic 45'");</span><br><span style="color: hsl(0, 100%, 40%);">- f_bts_0_cfg({"no neighbors", "neighbor bts 2", "neighbor lac 99 arfcn 123 bsic 45"});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bts_0_cfg(BSCVTY, {"no neighbors", "neighbor bts 2", "neighbor lac 99 arfcn 123 bsic 45"});</span><br><span> f_sleep(0.5);</span><br><span> </span><br><span> f_probe_for_handover("7.a", "HO to 871-12 does HO to bts 2",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19151">change 19151</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19151"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib059d9690f92f5f76025bca2b84496716a2a4cf0 </div>
<div style="display:none"> Gerrit-Change-Number: 19151 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>