<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19067">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19067/2//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/19067/2//COMMIT_MSG@11">Patch Set #2, Line 11:</a> <code style="font-family:monospace,monospace">being able to determine channel type.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">a bit hard to understand why.</p><p style="white-space: pre-wrap; word-wrap: break-word;">maybe reword to something like:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> These callers rely on a NULL return value for unknown channel type:<br> - gsmtap_send()<br> - osmo-bts/src/osmo-bts-virtual/scheduler_virtbts.c _tx_to_virt_um()<br> With the reverted patch, they would send invalid GSMTAP data.</pre><p style="white-space: pre-wrap; word-wrap: break-word;">but do they?<br>Do any callers regularly pass GSMTAP_CHANNEL_UNKNOWN?</p><p style="white-space: pre-wrap; word-wrap: break-word;">If you saw fallout that would be nice to know.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19067">change 19067</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19067"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6ebaa89cc3422df1d7fd2365a6176cb2902d1c67 </div>
<div style="display:none"> Gerrit-Change-Number: 19067 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 06 Jul 2020 12:05:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>