<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19153">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">si2quater: fix budget calculation for multiple EARFCNs<br><br>In rest_octets.c append_earfcn(), the unconditional bits added are 40, not 25.<br>Removing only 25 bits from the budget resulted in malformed SI2quater starting<br>with 4 configured EARFCNs, by adding more EARFCNs than fit in 20 bits.<br><br>These malformed SI2quater were also expected in gsm0408_test.c. Update the<br>expected SI2quater to what is being generated now. This patch passes the ttcn3<br>testing added in I45382f88686ca60e68569e93569fc4cfb63a0e0d, which provides some<br>confidence that the coding expected in gsm0408_test.c is now correct.<br><br>Related: OS#4652<br>Change-Id: I5df269f713456a6ccbb874d6b7faac4a6f123c67<br>---<br>M src/osmo-bsc/rest_octets.c<br>M tests/gsm0408/gsm0408_test.ok<br>2 files changed, 91 insertions(+), 67 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/rest_octets.c b/src/osmo-bsc/rest_octets.c</span><br><span>index 2238b08..0d806f3 100644</span><br><span>--- a/src/osmo-bsc/rest_octets.c</span><br><span>+++ b/src/osmo-bsc/rest_octets.c</span><br><span>@@ -162,7 +162,7 @@</span><br><span> {</span><br><span> bool appended;</span><br><span> unsigned int old = bv->cur_bit; /* save current position to make rollback possible */</span><br><span style="color: hsl(0, 100%, 40%);">- int rem = budget - 25;</span><br><span style="color: hsl(120, 100%, 40%);">+ int rem = ((int)budget) - 40;</span><br><span> if (rem <= 0)</span><br><span> return;</span><br><span> </span><br><span>@@ -190,6 +190,8 @@</span><br><span> /* Priority and E-UTRAN Parameters Description */</span><br><span> bitvec_set_bit(bv, 1);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* budget: 10 bits used above */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Serving Cell Priority Parameters Descr. is Present,</span><br><span> * see also: 3GPP TS 44.018, Table 10.5.2.33b.1 */</span><br><span> bitvec_set_bit(bv, 1);</span><br><span>@@ -209,6 +211,8 @@</span><br><span> /* T_Reselection */</span><br><span> bitvec_set_uint(bv, 0, 2);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* budget: 26 bits used above */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* No 3G Priority Parameters Description */</span><br><span> bitvec_set_bit(bv, 0);</span><br><span> /* E-UTRAN Parameters Description */</span><br><span>@@ -232,12 +236,16 @@</span><br><span> /* Repeated E-UTRAN Neighbour Cells */</span><br><span> bitvec_set_bit(bv, 1);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* budget: 34 bits used above */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> appended = append_eutran_neib_cell(bv, bts, rem);</span><br><span> if (!appended) { /* appending is impossible within current budget: rollback */</span><br><span> bv->cur_bit = old;</span><br><span> return;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* budget: further 6 bits used below, totalling 40 bits */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* stop bit - end of Repeated E-UTRAN Neighbour Cells sequence: */</span><br><span> bitvec_set_bit(bv, 0);</span><br><span> </span><br><span>diff --git a/tests/gsm0408/gsm0408_test.ok b/tests/gsm0408/gsm0408_test.ok</span><br><span>index bad8aef..7e054f4 100644</span><br><span>--- a/tests/gsm0408/gsm0408_test.ok</span><br><span>+++ b/tests/gsm0408/gsm0408_test.ok</span><br><span>@@ -80,13 +80,14 @@</span><br><span> added EARFCN 1945 - generating SI2quater for 4 EARFCNs and 0 UARFCNs...</span><br><span> generated valid SI2quater [00/00]: [23] 59 06 07 40 00 04 87 00 00 b3 07 7d 98 3c 62 0f 23 50 79 90 50 0b 2b </span><br><span> added EARFCN 1965 - generating SI2quater for 5 EARFCNs and 0 UARFCNs...</span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [00/00]: [23] 59 06 07 40 00 04 87 00 00 b3 07 7d 98 3c 62 0f 23 50 79 94 1e b4 14 </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [00/01]: [23] 59 06 07 40 20 04 87 00 00 b3 07 7d 98 3c 62 0f 23 50 79 90 50 0b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [01/01]: [23] 59 06 07 42 20 04 87 00 00 b3 07 ad 05 01 2b 2b 2b 2b 2b 2b 2b 2b 2b </span><br><span> added EARFCN 1967 - generating SI2quater for 6 EARFCNs and 0 UARFCNs...</span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [00/01]: [23] 59 06 07 40 20 04 87 00 00 b3 07 7d 98 3c 62 0f 23 50 79 94 1e b4 14 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [01/01]: [23] 59 06 07 42 20 04 87 00 00 b3 07 af c0 a0 2b 2b 2b 2b 2b 2b 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [00/01]: [23] 59 06 07 40 20 04 87 00 00 b3 07 7d 98 3c 62 0f 23 50 79 90 50 0b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [01/01]: [23] 59 06 07 42 20 04 87 00 00 b3 07 ad 41 eb f0 28 0b 2b 2b 2b 2b 2b 2b </span><br><span> added EARFCN 1982 - generating SI2quater for 7 EARFCNs and 0 UARFCNs...</span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [00/01]: [23] 59 06 07 40 20 04 87 00 00 b3 07 7d 98 3c 62 0f 23 50 79 94 1e b4 14 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [01/01]: [23] 59 06 07 42 20 04 87 00 00 b3 07 af c8 3d f5 85 01 2b 2b 2b 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [00/01]: [23] 59 06 07 40 20 04 87 00 00 b3 07 7d 98 3c 62 0f 23 50 79 90 50 0b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [01/01]: [23] 59 06 07 42 20 04 87 00 00 b3 07 ad 41 eb f2 0f 7d 61 40 2b 2b 2b 2b </span><br><span> BTS deallocated OK in test_si2q_e()</span><br><span> BTS allocation OK in test_si2q_u()</span><br><span> Testing SYSINFO_TYPE_2quater UARFCN generation:</span><br><span>@@ -135,77 +136,92 @@</span><br><span> BTS allocation OK in test_si2q_long()</span><br><span> Testing SYSINFO_TYPE_2quater combined EARFCN & UARFCN generation:</span><br><span> generating SI2quater for 17 EARFCNs and 1 UARFCNs...</span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 0c 1a 10 9c 00 02 cc 1e 09 07 82 39 76 56 0b </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 87 00 00 b3 07 84 d8 3c 1e c1 e1 76 10 7f ae 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 87 00 00 b3 08 40 c8 42 0d c2 10 aa 10 a7 ae 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 87 00 00 b3 08 54 c8 42 ad c2 15 aa 10 93 ae 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 87 00 00 b3 08 4a c8 42 5d c2 13 29 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 0c 1a 10 9c 00 02 cc 1e 09 07 82 39 76 56 0b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 87 00 00 b3 07 84 d8 3c 1e c1 e1 75 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 87 00 00 b3 08 3f d8 42 06 42 10 6d cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 87 00 00 b3 08 42 a8 42 9e c2 15 31 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 87 00 00 b3 08 55 b8 42 b5 42 12 75 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 87 00 00 b3 08 4a c8 42 5d c2 13 29 cb b2 b0 2b 2b </span><br><span> generating SI2quater for 17 EARFCNs and 2 UARFCNs...</span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 14 4d e7 00 46 00 01 66 0f 04 83 c1 1c bb 2b </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 87 00 00 b3 07 84 d8 3c 1e c1 e1 76 10 7f ae 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 87 00 00 b3 08 40 c8 42 0d c2 10 aa 10 a7 ae 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 87 00 00 b3 08 54 c8 42 ad c2 15 aa 10 93 ae 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 87 00 00 b3 08 4a c8 42 5d c2 13 29 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [00/06]: [23] 59 06 07 40 c0 25 0f 70 14 4d e7 00 46 00 01 66 0f 04 72 ec ac 0b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [01/06]: [23] 59 06 07 42 c0 04 87 00 00 b3 07 82 41 e1 36 0f 07 ae 5d 95 83 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [02/06]: [23] 59 06 07 44 c0 04 87 00 00 b3 07 85 d8 41 fe c2 10 31 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [03/06]: [23] 59 06 07 46 c0 04 87 00 00 b3 08 41 b8 42 15 42 14 f5 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [04/06]: [23] 59 06 07 48 c0 04 87 00 00 b3 08 54 c8 42 ad c2 15 a9 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [05/06]: [23] 59 06 07 4a c0 04 87 00 00 b3 08 49 d8 42 56 42 12 ed cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [06/06]: [23] 59 06 07 4c c0 04 87 00 00 b3 08 4c a7 2e ca c1 2b 2b 2b 2b 2b 2b 2b </span><br><span> generating SI2quater for 17 EARFCNs and 3 UARFCNs...</span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 1c 4d e7 03 04 87 00 00 b3 07 82 41 e0 8e 5d </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 87 00 00 b3 07 84 d8 3c 1e c1 e1 76 10 7f ae 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 87 00 00 b3 08 40 c8 42 0d c2 10 aa 10 a7 ae 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 87 00 00 b3 08 54 c8 42 ad c2 15 aa 10 93 ae 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 87 00 00 b3 08 4a c8 42 5d c2 13 29 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [00/06]: [23] 59 06 07 40 c0 25 0f 70 1c 4d e7 03 04 87 00 00 b3 07 82 39 76 56 0b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [01/06]: [23] 59 06 07 42 c0 04 87 00 00 b3 07 82 41 e1 36 0f 07 ae 5d 95 83 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [02/06]: [23] 59 06 07 44 c0 04 87 00 00 b3 07 85 d8 41 fe c2 10 31 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [03/06]: [23] 59 06 07 46 c0 04 87 00 00 b3 08 41 b8 42 15 42 14 f5 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [04/06]: [23] 59 06 07 48 c0 04 87 00 00 b3 08 54 c8 42 ad c2 15 a9 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [05/06]: [23] 59 06 07 4a c0 04 87 00 00 b3 08 49 d8 42 56 42 12 ed cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [06/06]: [23] 59 06 07 4c c0 04 87 00 00 b3 08 4c a7 2e ca c1 2b 2b 2b 2b 2b 2b 2b </span><br><span> generating SI2quater for 17 EARFCNs and 4 UARFCNs...</span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 24 59 fa 26 73 84 87 00 00 b3 07 82 39 76 56 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 87 00 00 b3 07 82 41 e1 36 0f 07 b0 78 5d 72 ec ac </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 87 00 00 b3 08 3f d8 42 06 42 10 6e 10 85 4e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 87 00 00 b3 08 53 d8 42 a6 42 15 6e 10 ad 4e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 87 00 00 b3 08 49 d8 42 56 42 12 ee 10 99 4e 5d 95 </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [00/06]: [23] 59 06 07 40 c0 25 0f 70 24 59 fa 26 73 84 87 00 00 b2 e5 d9 58 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [01/06]: [23] 59 06 07 42 c0 04 87 00 00 b3 07 82 41 e0 90 78 4d 72 ec ac 0b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [02/06]: [23] 59 06 07 44 c0 04 87 00 00 b3 07 83 d8 3c 2e c2 0f f5 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [03/06]: [23] 59 06 07 46 c0 04 87 00 00 b3 08 40 c8 42 0d c2 10 a9 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [04/06]: [23] 59 06 07 48 c0 04 87 00 00 b3 08 53 d8 42 a6 42 15 6d cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [05/06]: [23] 59 06 07 4a c0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b1 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [06/06]: [23] 59 06 07 4c c0 04 87 00 00 b3 08 4b b8 42 65 39 76 56 0b 2b 2b 2b 2b </span><br><span> generating SI2quater for 17 EARFCNs and 5 UARFCNs...</span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 2c 59 fa 30 73 f6 04 87 00 00 b3 07 82 39 76 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 87 00 00 b3 07 82 41 e1 36 0f 07 b0 78 5d 72 ec ac </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 87 00 00 b3 08 3f d8 42 06 42 10 6e 10 85 4e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 87 00 00 b3 08 53 d8 42 a6 42 15 6e 10 ad 4e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 87 00 00 b3 08 49 d8 42 56 42 12 ee 10 99 4e 5d 95 </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [00/06]: [23] 59 06 07 40 c0 25 0f 70 2c 59 fa 30 73 f6 04 87 00 00 b2 e5 d9 58 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [01/06]: [23] 59 06 07 42 c0 04 87 00 00 b3 07 82 41 e0 90 78 4d 72 ec ac 0b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [02/06]: [23] 59 06 07 44 c0 04 87 00 00 b3 07 83 d8 3c 2e c2 0f f5 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [03/06]: [23] 59 06 07 46 c0 04 87 00 00 b3 08 40 c8 42 0d c2 10 a9 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [04/06]: [23] 59 06 07 48 c0 04 87 00 00 b3 08 53 d8 42 a6 42 15 6d cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [05/06]: [23] 59 06 07 4a c0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b1 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [06/06]: [23] 59 06 07 4c c0 04 87 00 00 b3 08 4b b8 42 65 39 76 56 0b 2b 2b 2b 2b </span><br><span> generating SI2quater for 17 EARFCNs and 6 UARFCNs...</span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 34 f1 ae 15 f3 f4 83 04 87 00 00 b2 e5 d9 58 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 87 00 00 b3 07 82 41 e0 90 78 4d 83 c1 eb 97 65 60 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 87 00 00 b3 07 85 d8 41 fe c2 10 32 10 83 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 87 00 00 b3 08 42 a8 42 9e c2 15 32 10 ab 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b2 10 97 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 87 00 00 b3 08 4c a7 2e ca c1 2b 2b 2b 2b 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [00/06]: [23] 59 06 07 40 c0 25 0f 70 34 f1 ae 15 f3 f4 83 03 2b 2b 2b 2b 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [01/06]: [23] 59 06 07 42 c0 04 87 00 00 b3 07 82 41 e0 90 78 4d 72 ec ac 0b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [02/06]: [23] 59 06 07 44 c0 04 87 00 00 b3 07 83 d8 3c 2e c2 0f f5 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [03/06]: [23] 59 06 07 46 c0 04 87 00 00 b3 08 40 c8 42 0d c2 10 a9 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [04/06]: [23] 59 06 07 48 c0 04 87 00 00 b3 08 53 d8 42 a6 42 15 6d cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [05/06]: [23] 59 06 07 4a c0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b1 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [06/06]: [23] 59 06 07 4c c0 04 87 00 00 b3 08 4b b8 42 65 39 76 56 0b 2b 2b 2b 2b </span><br><span> generating SI2quater for 17 EARFCNs and 7 UARFCNs...</span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 3c f1 ae 15 f3 f4 83 01 84 87 00 00 b2 e5 d9 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 87 00 00 b3 07 82 41 e0 90 78 4d 83 c1 eb 97 65 60 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 87 00 00 b3 07 85 d8 41 fe c2 10 32 10 83 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 87 00 00 b3 08 42 a8 42 9e c2 15 32 10 ab 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b2 10 97 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 87 00 00 b3 08 4c a7 2e ca c1 2b 2b 2b 2b 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [00/06]: [23] 59 06 07 40 c0 25 0f 70 3c f1 ae 15 f3 f4 83 01 83 2b 2b 2b 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [01/06]: [23] 59 06 07 42 c0 04 87 00 00 b3 07 82 41 e0 90 78 4d 72 ec ac 0b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [02/06]: [23] 59 06 07 44 c0 04 87 00 00 b3 07 83 d8 3c 2e c2 0f f5 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [03/06]: [23] 59 06 07 46 c0 04 87 00 00 b3 08 40 c8 42 0d c2 10 a9 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [04/06]: [23] 59 06 07 48 c0 04 87 00 00 b3 08 53 d8 42 a6 42 15 6d cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [05/06]: [23] 59 06 07 4a c0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b1 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [06/06]: [23] 59 06 07 4c c0 04 87 00 00 b3 08 4b b8 42 65 39 76 56 0b 2b 2b 2b 2b </span><br><span> generating SI2quater for 17 EARFCNs and 8 UARFCNs...</span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 45 19 a0 0d 7d 7e a6 19 e7 0b 2b 2b 2b 2b 2b </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 87 00 00 b3 07 82 41 e0 90 78 4d 83 c1 eb 97 65 60 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 87 00 00 b3 07 85 d8 41 fe c2 10 32 10 83 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 87 00 00 b3 08 42 a8 42 9e c2 15 32 10 ab 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b2 10 97 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 87 00 00 b3 08 4c a7 2e ca c1 2b 2b 2b 2b 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [00/06]: [23] 59 06 07 40 c0 25 0f 70 45 19 a0 0d 7d 7e a6 19 e7 0b 2b 2b 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [01/06]: [23] 59 06 07 42 c0 04 87 00 00 b3 07 82 41 e0 90 78 4d 72 ec ac 0b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [02/06]: [23] 59 06 07 44 c0 04 87 00 00 b3 07 83 d8 3c 2e c2 0f f5 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [03/06]: [23] 59 06 07 46 c0 04 87 00 00 b3 08 40 c8 42 0d c2 10 a9 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [04/06]: [23] 59 06 07 48 c0 04 87 00 00 b3 08 53 d8 42 a6 42 15 6d cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [05/06]: [23] 59 06 07 4a c0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b1 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [06/06]: [23] 59 06 07 4c c0 04 87 00 00 b3 08 4b b8 42 65 39 76 56 0b 2b 2b 2b 2b </span><br><span> generating SI2quater for 17 EARFCNs and 9 UARFCNs...</span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 4d 19 a0 26 fd 66 a6 03 e7 fa 0b 2b 2b 2b 2b </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 87 00 00 b3 07 82 41 e0 90 78 4d 83 c1 eb 97 65 60 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 87 00 00 b3 07 85 d8 41 fe c2 10 32 10 83 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 87 00 00 b3 08 42 a8 42 9e c2 15 32 10 ab 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b2 10 97 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 87 00 00 b3 08 4c a7 2e ca c1 2b 2b 2b 2b 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [00/06]: [23] 59 06 07 40 c0 25 0f 70 4d 19 a0 26 fd 66 a6 03 e7 fa 0b 2b 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [01/06]: [23] 59 06 07 42 c0 04 87 00 00 b3 07 82 41 e0 90 78 4d 72 ec ac 0b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [02/06]: [23] 59 06 07 44 c0 04 87 00 00 b3 07 83 d8 3c 2e c2 0f f5 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [03/06]: [23] 59 06 07 46 c0 04 87 00 00 b3 08 40 c8 42 0d c2 10 a9 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [04/06]: [23] 59 06 07 48 c0 04 87 00 00 b3 08 53 d8 42 a6 42 15 6d cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [05/06]: [23] 59 06 07 4a c0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b1 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [06/06]: [23] 59 06 07 4c c0 04 87 00 00 b3 08 4b b8 42 65 39 76 56 0b 2b 2b 2b 2b </span><br><span> generating SI2quater for 17 EARFCNs and 10 UARFCNs...</span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 55 47 89 1e fd 7c b0 00 e7 9b b0 2b 2b 2b 2b </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 87 00 00 b3 07 82 41 e0 90 78 4d 83 c1 eb 97 65 60 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 87 00 00 b3 07 85 d8 41 fe c2 10 32 10 83 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 87 00 00 b3 08 42 a8 42 9e c2 15 32 10 ab 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b2 10 97 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 87 00 00 b3 08 4c a7 2e ca c1 2b 2b 2b 2b 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [00/06]: [23] 59 06 07 40 c0 25 0f 70 55 47 89 1e fd 7c b0 00 e7 9b b0 2b 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [01/06]: [23] 59 06 07 42 c0 04 87 00 00 b3 07 82 41 e0 90 78 4d 72 ec ac 0b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [02/06]: [23] 59 06 07 44 c0 04 87 00 00 b3 07 83 d8 3c 2e c2 0f f5 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [03/06]: [23] 59 06 07 46 c0 04 87 00 00 b3 08 40 c8 42 0d c2 10 a9 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [04/06]: [23] 59 06 07 48 c0 04 87 00 00 b3 08 53 d8 42 a6 42 15 6d cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [05/06]: [23] 59 06 07 4a c0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b1 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [06/06]: [23] 59 06 07 4c c0 04 87 00 00 b3 08 4b b8 42 65 39 76 56 0b 2b 2b 2b 2b </span><br><span> generating SI2quater for 17 EARFCNs and 11 UARFCNs...</span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 5d 47 89 1e fd 7c b0 01 67 9b b3 f8 2b 2b 2b </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 87 00 00 b3 07 82 41 e0 90 78 4d 83 c1 eb 97 65 60 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 87 00 00 b3 07 85 d8 41 fe c2 10 32 10 83 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 87 00 00 b3 08 42 a8 42 9e c2 15 32 10 ab 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b2 10 97 6e 5d 95 </span><br><span style="color: hsl(0, 100%, 40%);">-generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 87 00 00 b3 08 4c a7 2e ca c1 2b 2b 2b 2b 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [00/06]: [23] 59 06 07 40 c0 25 0f 70 5d 47 89 1e fd 7c b0 01 67 9b b3 f8 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [01/06]: [23] 59 06 07 42 c0 04 87 00 00 b3 07 82 41 e0 90 78 4d 72 ec ac 0b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [02/06]: [23] 59 06 07 44 c0 04 87 00 00 b3 07 83 d8 3c 2e c2 0f f5 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [03/06]: [23] 59 06 07 46 c0 04 87 00 00 b3 08 40 c8 42 0d c2 10 a9 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [04/06]: [23] 59 06 07 48 c0 04 87 00 00 b3 08 53 d8 42 a6 42 15 6d cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [05/06]: [23] 59 06 07 4a c0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b1 cb b2 b0 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+generated valid SI2quater [06/06]: [23] 59 06 07 4c c0 04 87 00 00 b3 08 4b b8 42 65 39 76 56 0b 2b 2b 2b 2b </span><br><span> BTS deallocated OK in test_si2q_long()</span><br><span> BTS allocation OK in test_si_ba_ind()</span><br><span> Testing if BA-IND is set as expected in SI2xxx and SI5xxx</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19153">change 19153</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19153"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5df269f713456a6ccbb874d6b7faac4a6f123c67 </div>
<div style="display:none"> Gerrit-Change-Number: 19153 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>