<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/19156">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">common: Avoid changing OPSTATE to Enabled upon RSL up<br><br>the RSL link has nothing to do regarding the state of the Radio Carrier,<br>as in it being up is not enough to have a working (enabled) Radio<br>Carrier.<br><br>Change-Id: Iefb5c4e1097233b5c31e4d621c544d51516af678<br>---<br>M src/common/trx.c<br>1 file changed, 2 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/56/19156/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/trx.c b/src/common/trx.c</span><br><span>index 074cb95..90d3148 100644</span><br><span>--- a/src/common/trx.c</span><br><span>+++ b/src/common/trx.c</span><br><span>@@ -153,13 +153,10 @@</span><br><span> int trx_link_estab(struct gsm_bts_trx *trx)</span><br><span> {</span><br><span>  struct e1inp_sign_link *link = trx->rsl_link;</span><br><span style="color: hsl(0, 100%, 40%);">-        uint8_t radio_state = link ?  NM_OPSTATE_ENABLED : NM_OPSTATE_DISABLED;</span><br><span>      int rc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     LOGP(DSUM, LOGL_INFO, "RSL link (TRX %02x) state changed to %s, sending Status'.\n",</span><br><span style="color: hsl(0, 100%, 40%);">-              trx->nr, link ? "up" : "down");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-  oml_mo_state_chg(&trx->mo, radio_state, NM_AVSTATE_OK);</span><br><span style="color: hsl(120, 100%, 40%);">+        LOGPTRX(trx, DSUM, LOGL_INFO, "RSL link %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+              link ? "up" : "down");</span><br><span> </span><br><span>       if (link)</span><br><span>            rc = rsl_tx_rf_res(trx);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/19156">change 19156</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/19156"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iefb5c4e1097233b5c31e4d621c544d51516af678 </div>
<div style="display:none"> Gerrit-Change-Number: 19156 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>