<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19133">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BTS_Tests: cosmetic: mark private test case functions as such<br><br>Change-Id: I173e42dbe1694a10b54f95a730df2e64f2c65d17<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 45 insertions(+), 45 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 132e13e..1b6c9b2 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -674,7 +674,7 @@</span><br><span> ***********************************************************************/</span><br><span> </span><br><span> /* Stress test: Do 500 channel activations/deactivations in rapid succession */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_chan_act_stress(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_chan_act_stress(charstring id) runs on ConnHdlr {</span><br><span> for (var integer i := 0; i < 500; i := i+1) {</span><br><span> f_rsl_chan_act(g_pars.chan_mode);</span><br><span> f_rsl_chan_deact();</span><br><span>@@ -691,7 +691,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Test if re-activation of an already active channel fails as expected */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_chan_act_react(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_chan_act_react(charstring id) runs on ConnHdlr {</span><br><span> f_rsl_chan_act(g_pars.chan_mode);</span><br><span> /* attempt to activate the same lchan again -> expect reject */</span><br><span> RSL.send(ts_RSL_CHAN_ACT(g_chan_nr, g_pars.chan_mode));</span><br><span>@@ -715,7 +715,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Attempt to de-activate a channel that's not active */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_chan_deact_not_active(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_chan_deact_not_active(charstring id) runs on ConnHdlr {</span><br><span> timer T := 3.0;</span><br><span> RSL.send(ts_RSL_RF_CHAN_REL(g_chan_nr));</span><br><span> T.start;</span><br><span>@@ -737,7 +737,7 @@</span><br><span> }</span><br><span> </span><br><span> /* attempt to activate channel with wrong RSL Channel Nr IE; expect NACK */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_chan_act_wrong_nr(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_chan_act_wrong_nr(charstring id) runs on ConnHdlr {</span><br><span> RSL.send(ts_RSL_CHAN_ACT(g_chan_nr, g_pars.chan_mode));</span><br><span> alt {</span><br><span> [] RSL.receive(tr_RSL_CHAN_ACT_ACK(g_chan_nr)) {</span><br><span>@@ -1571,7 +1571,7 @@</span><br><span> Misc_Helpers.f_shutdown(__BFILE__, __LINE__);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_ho_rach(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_ho_rach(charstring id) runs on ConnHdlr {</span><br><span> var GsmFrameNumber fn;</span><br><span> var RSL_Message rm;</span><br><span> </span><br><span>@@ -2000,7 +2000,7 @@</span><br><span> }</span><br><span> </span><br><span> /* establish DChan, verify existance + contents of measurement reports */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_meas_res_periodic(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_meas_res_periodic(charstring id) runs on ConnHdlr {</span><br><span> f_l1_tune(L1CTL);</span><br><span> RSL.clear;</span><br><span> </span><br><span>@@ -2168,7 +2168,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Verify Tx power reduction and ramping up during BTS bring up */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_tx_power_start_ramp_up_bcch(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_tx_power_start_ramp_up_bcch(charstring id) runs on ConnHdlr {</span><br><span> f_l1_tune(L1CTL);</span><br><span> RSL.clear;</span><br><span> </span><br><span>@@ -2188,7 +2188,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Verify Tx power reduction and ramping downd uring BTS bring shutdown due to Abis link failure */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_tx_power_start_ramp_down_bcch(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_tx_power_start_ramp_down_bcch(charstring id) runs on ConnHdlr {</span><br><span> f_connhdlr_init_vty_bsc();</span><br><span> </span><br><span> f_l1_tune(L1CTL);</span><br><span>@@ -2218,7 +2218,7 @@</span><br><span> * + ramping down during ADM state UNLOCKED->LOCKED</span><br><span> * + ramping up during ADM state LOCKED->UNLOCKED</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_tx_power_ramp_adm_state_change(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_tx_power_ramp_adm_state_change(charstring id) runs on ConnHdlr {</span><br><span> var L1ctlDlMessage l1_dl;</span><br><span> var integer last_rx_lvl;</span><br><span> </span><br><span>@@ -2290,7 +2290,7 @@</span><br><span> </span><br><span> /* see if the rsl meas res contains our expeced bs power level</span><br><span> bs power set during assignment */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_rsl_bs_pwr_static_ass(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_rsl_bs_pwr_static_ass(charstring id) runs on ConnHdlr {</span><br><span> f_l1_tune(L1CTL);</span><br><span> RSL.clear;</span><br><span> </span><br><span>@@ -2313,7 +2313,7 @@</span><br><span> </span><br><span> /* see if the rsl meas res contains our expeced bs power level</span><br><span> bs power set after assignment */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_rsl_bs_pwr_static_power_control(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_rsl_bs_pwr_static_power_control(charstring id) runs on ConnHdlr {</span><br><span> f_l1_tune(L1CTL);</span><br><span> RSL.clear;</span><br><span> </span><br><span>@@ -2364,7 +2364,7 @@</span><br><span> /* target level -100, first rssi -90, ms power 7, expected increase to 7+6 within 6 seconds,</span><br><span> second rssi -110, ms power 7+6, expected decrease to 7 within 6 seconds,</span><br><span> These power levels are valid for all bands and require no special handling */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_rsl_ms_pwr_dyn_ass_updown(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_rsl_ms_pwr_dyn_ass_updown(charstring id) runs on ConnHdlr {</span><br><span> var uint5_t pwr_var := 7;</span><br><span> var L1ctlDlMessage l1_dl;</span><br><span> </span><br><span>@@ -2432,7 +2432,7 @@</span><br><span> }</span><br><span> </span><br><span> /* check that we do not exceed the max power */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_rsl_ms_pwr_dyn_max(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_rsl_ms_pwr_dyn_max(charstring id) runs on ConnHdlr {</span><br><span> var uint5_t pwr_var := 7;</span><br><span> var L1ctlDlMessage l1_dl;</span><br><span> </span><br><span>@@ -2474,7 +2474,7 @@</span><br><span> }</span><br><span> </span><br><span> /* see if we reach the band max power */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_rsl_ms_pwr_dyn_up(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_rsl_ms_pwr_dyn_up(charstring id) runs on ConnHdlr {</span><br><span> var L1ctlDlMessage l1_dl;</span><br><span> var uint5_t pwr_var := 15;</span><br><span> var uint5_t pwr_max_var := f_get_max_power_from_band();</span><br><span>@@ -2524,7 +2524,7 @@</span><br><span> }</span><br><span> </span><br><span> /* see if we reach the band min power */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_rsl_ms_pwr_dyn_down(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_rsl_ms_pwr_dyn_down(charstring id) runs on ConnHdlr {</span><br><span> var L1ctlDlMessage l1_dl;</span><br><span> </span><br><span> /* set a high value to ensure power decreases */</span><br><span>@@ -2575,7 +2575,7 @@</span><br><span> </span><br><span> /* see if we change the power level without receiving power parameters, which should not happen</span><br><span> rsl chan act WITHOUT power parameters */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_rsl_ms_pwr_dyn_active(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_rsl_ms_pwr_dyn_active(charstring id) runs on ConnHdlr {</span><br><span> var L1ctlDlMessage l1_dl;</span><br><span> </span><br><span> /* set a high value to ensure power decreases */</span><br><span>@@ -2616,7 +2616,7 @@</span><br><span> </span><br><span> /* see if we change the power level without receiving power parameters, which should not happen</span><br><span> ms power control WITHOUT power parameters */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_rsl_ms_pwr_dyn_active2(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_rsl_ms_pwr_dyn_active2(charstring id) runs on ConnHdlr {</span><br><span> var L1ctlDlMessage l1_dl;</span><br><span> </span><br><span> /* set a high value to ensure power decreases */</span><br><span>@@ -2902,7 +2902,7 @@</span><br><span> </span><br><span> /* establish DChan, and send MS POWER CONTROL messages via RSL, verify that</span><br><span> * the BTS is forwarding those values to the MS via the SACCH L1 header. */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_tc_rsl_ms_pwr_ctrl(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_tc_rsl_ms_pwr_ctrl(charstring id) runs on ConnHdlr {</span><br><span> var L1ctlDlMessage l1_dl;</span><br><span> var RSL_IE_MS_Power ms_power;</span><br><span> var RSL_Message rsl;</span><br><span>@@ -2973,7 +2973,7 @@</span><br><span> </span><br><span> /* establish DChan, verify that the BTS sets the TA in the first SACCH L1 header.</span><br><span> TA for the IMM ASS messages is still controlled by g_pars.l1_pars.ms_actual_ta! */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_tc_rsl_chan_initial_ta(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_tc_rsl_chan_initial_ta(charstring id) runs on ConnHdlr {</span><br><span> var L1ctlDlMessage l1_dl;</span><br><span> var uint5_t ta_to_test := 16;</span><br><span> </span><br><span>@@ -3022,7 +3022,7 @@</span><br><span> }</span><br><span> </span><br><span> /* establish DChan, verify that the BTS sets MS power in the first SACCH L1 header. */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_tc_rsl_chan_initial_ms_pwr(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_tc_rsl_chan_initial_ms_pwr(charstring id) runs on ConnHdlr {</span><br><span> var L1ctlDlMessage l1_dl;</span><br><span> var uint5_t ms_power_level := 7;</span><br><span> </span><br><span>@@ -3900,7 +3900,7 @@</span><br><span> </span><br><span> /* helper function: Set given SI via RSL + validate scheduling.</span><br><span> * CALLER MUST MAKE SURE TO CHANGE GLOBAL si_cfg! */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_si_sched() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_si_sched() runs on test_CT {</span><br><span> var SystemInformationVectorPerTc si_per_tc;</span><br><span> f_init_l1ctl();</span><br><span> f_l1_tune(L1CTL);</span><br><span>@@ -4068,14 +4068,14 @@</span><br><span> }</span><br><span> </span><br><span> /* Send messages with wrong message type */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_wrong_msg_type_dchan(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_wrong_msg_type_dchan(charstring id) runs on ConnHdlr {</span><br><span> var template (value) RSL_Message rsl_tx;</span><br><span> rsl_tx := ts_RSL_CHAN_ACT(g_chan_nr, g_pars.chan_mode);</span><br><span> rsl_tx.msg_type := RSL_MT_NOT_CMD;</span><br><span> RSL.send(rsl_tx);</span><br><span> f_rslem_unregister(0, g_chan_nr);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_wrong_msg_type_rll(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_wrong_msg_type_rll(charstring id) runs on ConnHdlr {</span><br><span> var template (value) RSL_Message rsl_tx;</span><br><span> /* we first have to activate the dedicated channel */</span><br><span> f_rsl_chan_act(g_pars.chan_mode);</span><br><span>@@ -4120,7 +4120,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Send messages in wrong sequence (RLL to an inactive lchan) */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_err_rep_wrong_sequence(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_err_rep_wrong_sequence(charstring id) runs on ConnHdlr {</span><br><span> RSL.send(ts_RSL_UNITDATA_REQ(g_chan_nr, ts_RslLinkID_DCCH(0), '0102'O));</span><br><span> f_rslem_unregister(0, g_chan_nr);</span><br><span> }</span><br><span>@@ -4141,7 +4141,7 @@</span><br><span> ***********************************************************************/</span><br><span> </span><br><span> /* Send IPA DLCX to inactive lchan */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_ipa_dlcx_not_active(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_ipa_dlcx_not_active(charstring id) runs on ConnHdlr {</span><br><span> f_rsl_transceive(ts_RSL_IPA_DLCX(g_chan_nr, 0), tr_RSL_IPA_DLCX_ACK(g_chan_nr, ?, ?),</span><br><span> "IPA DLCX ACK");</span><br><span> }</span><br><span>@@ -4153,7 +4153,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Send IPA CRCX twice to inactive lchan */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_ipa_crcx_twice_not_active(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_ipa_crcx_twice_not_active(charstring id) runs on ConnHdlr {</span><br><span> f_rsl_transceive(ts_RSL_IPA_CRCX(g_chan_nr), tr_RSL_IPA_CRCX_ACK(g_chan_nr, ?, ?, ?),</span><br><span> "IPA CRCX ACK");</span><br><span> f_rsl_transceive(ts_RSL_IPA_CRCX(g_chan_nr), tr_RSL_IPA_CRCX_NACK(g_chan_nr, RSL_ERR_RES_UNAVAIL),</span><br><span>@@ -4167,7 +4167,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Regular sequence of CRCX/MDCX/DLCX */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_ipa_crcx_mdcx_dlcx_not_active(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_ipa_crcx_mdcx_dlcx_not_active(charstring id) runs on ConnHdlr {</span><br><span> f_rsl_transceive(ts_RSL_IPA_CRCX(g_chan_nr), tr_RSL_IPA_CRCX_ACK(g_chan_nr, ?, ?, ?),</span><br><span> "IPA CRCX ACK");</span><br><span> var uint32_t remote_ip := f_rnd_int(c_UINT32_MAX);</span><br><span>@@ -4188,7 +4188,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Sequence of CRCX, 2x MDCX, DLCX */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_ipa_crcx_mdcx_mdcx_dlcx_not_active(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_ipa_crcx_mdcx_mdcx_dlcx_not_active(charstring id) runs on ConnHdlr {</span><br><span> f_rsl_transceive(ts_RSL_IPA_CRCX(g_chan_nr), tr_RSL_IPA_CRCX_ACK(g_chan_nr, ?, ?, ?),</span><br><span> "IPA CRCX ACK");</span><br><span> var uint32_t remote_ip := f_rnd_int(c_UINT32_MAX);</span><br><span>@@ -4215,7 +4215,7 @@</span><br><span> }</span><br><span> </span><br><span> /* IPA CRCX on SDCCH/4 and SDCCH/8 (doesn't make sense) */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_ipa_crcx_sdcch_not_active(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_ipa_crcx_sdcch_not_active(charstring id) runs on ConnHdlr {</span><br><span> f_rsl_transceive(ts_RSL_IPA_CRCX(g_chan_nr), tr_RSL_IPA_CRCX_NACK(g_chan_nr, ?),</span><br><span> "IPA CRCX NACK");</span><br><span> }</span><br><span>@@ -5415,7 +5415,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Activate Osmocom-style dynamic PDCH from BSC side */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_dyn_osmo_pdch_act_deact(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_dyn_osmo_pdch_act_deact(charstring id) runs on ConnHdlr {</span><br><span> var PCUIF_Message first_info;</span><br><span> var integer ts_nr := g_chan_nr.tn;</span><br><span> var integer trx_nr := 0;</span><br><span>@@ -5440,7 +5440,7 @@</span><br><span> }</span><br><span> </span><br><span> /* send a RF CHAN REL for PDCH on an osmocom dynamci PDCH that's already inactive */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_dyn_osmo_pdch_unsol_deact(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_dyn_osmo_pdch_unsol_deact(charstring id) runs on ConnHdlr {</span><br><span> var PCUIF_Message first_info;</span><br><span> var integer pcu_conn_id := -1;</span><br><span> </span><br><span>@@ -5462,7 +5462,7 @@</span><br><span> }</span><br><span> </span><br><span> /* try to RSL CHAN ACT a PDCH on an osmocom-style PDCH that's already active */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_dyn_osmo_pdch_double_act(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_dyn_osmo_pdch_double_act(charstring id) runs on ConnHdlr {</span><br><span> var PCUIF_Message first_info;</span><br><span> var integer ts_nr := g_chan_nr.tn;</span><br><span> var integer trx_nr := 0;</span><br><span>@@ -5488,7 +5488,7 @@</span><br><span> }</span><br><span> </span><br><span> /* try to RSL CHAN ACT a TCH/F on an osmocom-style PDCH */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_dyn_osmo_pdch_tchf_act(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_dyn_osmo_pdch_tchf_act(charstring id) runs on ConnHdlr {</span><br><span> var PCUIF_Message first_info;</span><br><span> var integer ts_nr := g_chan_nr.tn;</span><br><span> var integer trx_nr := 0;</span><br><span>@@ -5516,7 +5516,7 @@</span><br><span> }</span><br><span> </span><br><span> /* try to RSL CHAN ACT the TCH/H on an osmocom-style PDCH */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_dyn_osmo_pdch_tchh_act(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_dyn_osmo_pdch_tchh_act(charstring id) runs on ConnHdlr {</span><br><span> var PCUIF_Message first_info;</span><br><span> var integer ts_nr := g_chan_nr.tn;</span><br><span> var integer trx_nr := 0;</span><br><span>@@ -5615,7 +5615,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Activate and de-activate an IPA-style dynamic TCH/F + PDCH */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_dyn_ipa_pdch_act_deact(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_dyn_ipa_pdch_act_deact(charstring id) runs on ConnHdlr {</span><br><span> var PCUIF_Message first_info;</span><br><span> var integer ts_nr := g_chan_nr.tn;</span><br><span> var integer trx_nr := 0;</span><br><span>@@ -5642,7 +5642,7 @@</span><br><span> }</span><br><span> </span><br><span> /* try to RSL CHAN ACT a TCH/F on an IPA-style PDCH */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_dyn_ipa_pdch_tchf_act(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_dyn_ipa_pdch_tchf_act(charstring id) runs on ConnHdlr {</span><br><span> var PCUIF_Message first_info;</span><br><span> var integer ts_nr := g_chan_nr.tn;</span><br><span> var integer trx_nr := 0;</span><br><span>@@ -5668,7 +5668,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Activate IPA style dyn PDCH as TCH/F and then illegally try to activate it as PDCH, too */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_dyn_ipa_pdch_tchf_act_pdch_act_nack(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_dyn_ipa_pdch_tchf_act_pdch_act_nack(charstring id) runs on ConnHdlr {</span><br><span> var PCUIF_Message first_info;</span><br><span> var integer ts_nr := g_chan_nr.tn;</span><br><span> var integer trx_nr := 0;</span><br><span>@@ -5704,7 +5704,7 @@</span><br><span> }</span><br><span> </span><br><span> /* try to RSL CHAN ACT a TCH/F on an IPA-style PDCH that's already in PDCH mode; expect NACK */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_dyn_ipa_pdch_act_tchf_act_nack(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_dyn_ipa_pdch_act_tchf_act_nack(charstring id) runs on ConnHdlr {</span><br><span> var PCUIF_Message first_info;</span><br><span> var integer ts_nr := g_chan_nr.tn;</span><br><span> var integer trx_nr := 0;</span><br><span>@@ -6217,7 +6217,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Test channel activation with A5/n right from the beginning (like in assignment + hand-over) */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_chan_act_encr(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_chan_act_encr(charstring id) runs on ConnHdlr {</span><br><span> f_l1_tune(L1CTL);</span><br><span> f_est_dchan(true);</span><br><span> </span><br><span>@@ -6256,7 +6256,7 @@</span><br><span> </span><br><span> /* Test channel activation with A5/n right from the beginning and RSL MODE MODIFY</span><br><span> which should break the en/decryption on purpose by supplying a new key that is unknown to the MS*/</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_rsl_modify_encr(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_rsl_modify_encr(charstring id) runs on ConnHdlr {</span><br><span> f_l1_tune(L1CTL);</span><br><span> f_est_dchan(true);</span><br><span> </span><br><span>@@ -6321,7 +6321,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Test unencrypted channel activation followed by explicit ENCR CMD later */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_encr_cmd(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_encr_cmd(charstring id) runs on ConnHdlr {</span><br><span> /* L3 payload doesn't matter, as it is passed transparently */</span><br><span> var BIT3 l3_alg_id := f_alg_id_to_l3(g_pars.encr.alg_id);</span><br><span> var octetstring l3 := enc_PDU_ML3_NW_MS(valueof(ts_RRM_CiphModeCmd(l3_alg_id)));</span><br><span>@@ -6445,7 +6445,7 @@</span><br><span> g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,7)));</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_test_l2_fill_frames(boolean dtxd) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_test_l2_fill_frames(boolean dtxd) runs on ConnHdlr {</span><br><span> var L1ctlDlMessage dl;</span><br><span> var octetstring l2_fill_frame := '0303012B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B'O;</span><br><span> var octetstring l2_fill_frame_sacch := substr(l2_fill_frame, 0, lengthof(l2_fill_frame) - 2);</span><br><span>@@ -6583,15 +6583,15 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_tch_sign_l2_fill_frame(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_tch_sign_l2_fill_frame(charstring id) runs on ConnHdlr {</span><br><span> f_test_l2_fill_frames(false);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_TC_tch_sign_l2_fill_frame_dtxd(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_tch_sign_l2_fill_frame_dtxd(charstring id) runs on ConnHdlr {</span><br><span> f_test_l2_fill_frames(true);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_tch_sign_l2_fill_frame(boolean dtxd) runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_tch_sign_l2_fill_frame(boolean dtxd) runs on test_CT {</span><br><span> var ConnHdlr vc_conn;</span><br><span> var ConnHdlrPars pars;</span><br><span> pars.t_guard := 60.0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19133">change 19133</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19133"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I173e42dbe1694a10b54f95a730df2e64f2c65d17 </div>
<div style="display:none"> Gerrit-Change-Number: 19133 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>