<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/19125">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lapd: Replace magic numbers with #defines<br><br>Related: OS#4644<br>Change-Id: I2971fb5bb27a7024abac7e2a4414eaf61f27ccb5<br>---<br>M src/input/lapd.c<br>1 file changed, 6 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/input/lapd.c b/src/input/lapd.c</span><br><span>index 4bcece5..9bab5a9 100644</span><br><span>--- a/src/input/lapd.c</span><br><span>+++ b/src/input/lapd.c</span><br><span>@@ -82,6 +82,9 @@</span><br><span> #define LOGSAP(sap, level, fmt, args ...) \</span><br><span>       LOGP(DLLAPD, level, "%s: " fmt, (sap)->dl.name, ## args)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define DLSAP_MSGB_SIZE              56</span><br><span style="color: hsl(120, 100%, 40%);">+#define DLSAP_MSGB_HEADROOM 56</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> const struct lapd_profile lapd_profile_isdn = {</span><br><span>      .k              = LAPD_SET_K(7,7),</span><br><span>   .n200           = 3,</span><br><span>@@ -349,7 +352,7 @@</span><br><span>           /* Send ACCEPT */</span><br><span>            memmove(resp, "\xfe\xff\x03\x0f\x00\x00\x02\x00", 8);</span><br><span>              resp[7] = (action << 1) | 1;</span><br><span style="color: hsl(0, 100%, 40%);">-              msg = msgb_alloc_headroom(56, 56, "DL EST");</span><br><span style="color: hsl(120, 100%, 40%);">+                msg = msgb_alloc_headroom(DLSAP_MSGB_SIZE, DLSAP_MSGB_HEADROOM, "DL EST");</span><br><span>                 msg->l2h = msgb_push(msg, 8);</span><br><span>             memcpy(msg->l2h, resp, 8);</span><br><span> </span><br><span>@@ -521,7 +524,7 @@</span><br><span>      LOGSAP(sap, LOGL_NOTICE, "LAPD DL-ESTABLISH request TEI=%d SAPI=%d\n", tei, sapi);</span><br><span> </span><br><span>     /* prepare prim */</span><br><span style="color: hsl(0, 100%, 40%);">-      msg = msgb_alloc_headroom(56, 56, "DL EST");</span><br><span style="color: hsl(120, 100%, 40%);">+        msg = msgb_alloc_headroom(DLSAP_MSGB_SIZE, DLSAP_MSGB_HEADROOM, "DL EST");</span><br><span>         msg->l3h = msg->data;</span><br><span>         osmo_prim_init(&dp.oph, 0, PRIM_DL_EST, PRIM_OP_REQUEST, msg);</span><br><span> </span><br><span>@@ -548,7 +551,7 @@</span><br><span>  LOGSAP(sap, LOGL_NOTICE, "LAPD DL-RELEASE request TEI=%d SAPI=%d\n", tei, sapi);</span><br><span> </span><br><span>       /* prepare prim */</span><br><span style="color: hsl(0, 100%, 40%);">-      msg = msgb_alloc_headroom(56, 56, "DL REL");</span><br><span style="color: hsl(120, 100%, 40%);">+        msg = msgb_alloc_headroom(DLSAP_MSGB_SIZE, DLSAP_MSGB_HEADROOM, "DL REL");</span><br><span>         msg->l3h = msg->data;</span><br><span>         osmo_prim_init(&dp.oph, 0, PRIM_DL_REL, PRIM_OP_REQUEST, msg);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/19125">change 19125</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/19125"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2971fb5bb27a7024abac7e2a4414eaf61f27ccb5 </div>
<div style="display:none"> Gerrit-Change-Number: 19125 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>