<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/19117">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_data.h: Use enum type for NM state fields<br><br>Change-Id: I21fa1688a0c8a3788a5ecedd5912f596a69a1beb<br>---<br>M include/osmo-bts/gsm_data.h<br>M src/common/oml.c<br>2 files changed, 6 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/17/19117/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-bts/gsm_data.h b/include/osmo-bts/gsm_data.h</span><br><span>index 7b4d456..97f5cde 100644</span><br><span>--- a/include/osmo-bts/gsm_data.h</span><br><span>+++ b/include/osmo-bts/gsm_data.h</span><br><span>@@ -83,9 +83,9 @@</span><br><span> </span><br><span> /* Network Management State */</span><br><span> struct gsm_nm_state {</span><br><span style="color: hsl(0, 100%, 40%);">-   uint8_t operational;</span><br><span style="color: hsl(0, 100%, 40%);">-    uint8_t administrative;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t availability;</span><br><span style="color: hsl(120, 100%, 40%);">+ enum abis_nm_op_state operational;</span><br><span style="color: hsl(120, 100%, 40%);">+    enum abis_nm_adm_state administrative;</span><br><span style="color: hsl(120, 100%, 40%);">+        enum abis_nm_avail_state availability;</span><br><span> };</span><br><span> </span><br><span> struct gsm_abis_mo {</span><br><span>diff --git a/src/common/oml.c b/src/common/oml.c</span><br><span>index 5f64d52..63287f0 100644</span><br><span>--- a/src/common/oml.c</span><br><span>+++ b/src/common/oml.c</span><br><span>@@ -314,6 +314,7 @@</span><br><span> int oml_tx_state_changed(const struct gsm_abis_mo *mo)</span><br><span> {</span><br><span>   struct msgb *nmsg;</span><br><span style="color: hsl(120, 100%, 40%);">+    uint8_t avail_state;</span><br><span> </span><br><span>     nmsg = oml_msgb_alloc();</span><br><span>     if (!nmsg)</span><br><span>@@ -323,7 +324,8 @@</span><br><span>     msgb_tv_put(nmsg, NM_ATT_OPER_STATE, mo->nm_state.operational);</span><br><span> </span><br><span>       /* 9.4.7 Availability Status */</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_tl16v_put(nmsg, NM_ATT_AVAIL_STATUS, 1, &mo->nm_state.availability);</span><br><span style="color: hsl(120, 100%, 40%);">+      avail_state = (uint8_t) mo->nm_state.availability;</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_tl16v_put(nmsg, NM_ATT_AVAIL_STATUS, 1, &avail_state);</span><br><span> </span><br><span>  /* 9.4.4 Administrative Status -- not in spec but also sent by nanobts */</span><br><span>    msgb_tv_put(nmsg, NM_ATT_ADM_STATE, mo->nm_state.administrative);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/19117">change 19117</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/19117"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I21fa1688a0c8a3788a5ecedd5912f596a69a1beb </div>
<div style="display:none"> Gerrit-Change-Number: 19117 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>