<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19121">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgcp_vty: refactor endpoint number configuration<br><br>At the moment the number of possible E1 endpoints (depends on the number<br>of E1 timeslots that should be used) is hardcoded and the configuration<br>of the number of virtual endpoints has an off-by-one problem.<br><br>For the E1 timeslots one might choose not to occupy all E1 timeslots of<br>once. A one TRX E1 BTS usually requires 3 E1 timeslots. One as D-Channel<br>timeslot and two to cover the voice channels. The voice channels<br>timeslots need to be set up in osmo-mgw, while the D-Channel timeslot<br>must not be touched. The VTY config needs to be able to reflect that.<br><br>Change-Id: I73b31e3c236a61ea0a6f76ef5ff98ce589f52c77<br>Related: OS#2547<br>---<br>M include/osmocom/mgcp/mgcp_trunk.h<br>M src/libosmo-mgcp/mgcp_trunk.c<br>M src/libosmo-mgcp/mgcp_vty.c<br>M tests/mgcp/mgcp_test.c<br>4 files changed, 85 insertions(+), 28 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/21/19121/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/mgcp/mgcp_trunk.h b/include/osmocom/mgcp/mgcp_trunk.h</span><br><span>index aa6dd29..4caeff9 100644</span><br><span>--- a/include/osmocom/mgcp/mgcp_trunk.h</span><br><span>+++ b/include/osmocom/mgcp/mgcp_trunk.h</span><br><span>@@ -39,11 +39,23 @@</span><br><span> int rtp_accept_all;</span><br><span> </span><br><span> unsigned int number_endpoints;</span><br><span style="color: hsl(0, 100%, 40%);">- unsigned int vty_number_endpoints;</span><br><span> struct mgcp_endpoint **endpoints;</span><br><span> </span><br><span> /* global rate counters to measure the trunks overall performance and health */</span><br><span> struct mgcp_ratectr_trunk ratectr;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ union {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Virtual trunk specific */</span><br><span style="color: hsl(120, 100%, 40%);">+ struct {</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int vty_number_endpoints;</span><br><span style="color: hsl(120, 100%, 40%);">+ } virtual;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* E1 specific */</span><br><span style="color: hsl(120, 100%, 40%);">+ struct {</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int vty_timeslot_first;</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int vty_timeslot_num;</span><br><span style="color: hsl(120, 100%, 40%);">+ } e1;</span><br><span style="color: hsl(120, 100%, 40%);">+ };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> };</span><br><span> </span><br><span> struct mgcp_trunk *mgcp_trunk_alloc(struct mgcp_config *cfg, enum mgcp_trunk_type ttype, int nr);</span><br><span>diff --git a/src/libosmo-mgcp/mgcp_trunk.c b/src/libosmo-mgcp/mgcp_trunk.c</span><br><span>index 43abe45..1aadc2c 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_trunk.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_trunk.c</span><br><span>@@ -41,13 +41,16 @@</span><br><span> return NULL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Set reasonable VTY defaults */</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->virtual.vty_number_endpoints = 32;</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->e1.vty_timeslot_first = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->e1.vty_timeslot_num = 2;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> trunk->cfg = cfg;</span><br><span> trunk->trunk_type = ttype;</span><br><span> trunk->trunk_nr = nr;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> trunk->audio_send_ptime = 1;</span><br><span> trunk->audio_send_name = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- trunk->vty_number_endpoints = 33;</span><br><span> trunk->omit_rtcp = 0;</span><br><span> </span><br><span> mgcp_trunk_set_keepalive(trunk, MGCP_KEEPALIVE_ONCE);</span><br><span>@@ -67,13 +70,8 @@</span><br><span> {</span><br><span> int i;</span><br><span> struct mgcp_endpoint *endp;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Make sure the amount of requested endpoints does not execeed</span><br><span style="color: hsl(0, 100%, 40%);">- * sane limits. The VTY already limits the possible amount,</span><br><span style="color: hsl(0, 100%, 40%);">- * however miss-initalation of the struct or memory corruption</span><br><span style="color: hsl(0, 100%, 40%);">- * could still lead to an excessive allocation of endpoints, so</span><br><span style="color: hsl(0, 100%, 40%);">- * better stop early if that is the case. */</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(trunk->vty_number_endpoints < 65534);</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int number_endpoints;</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int offset_endpoints;</span><br><span> </span><br><span> /* This function is called once on startup by the VTY to allocate the</span><br><span> * endpoints. The number of endpoints must not change througout the</span><br><span>@@ -81,15 +79,37 @@</span><br><span> OSMO_ASSERT(trunk->number_endpoints == 0);</span><br><span> OSMO_ASSERT(trunk->endpoints == NULL);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ switch (trunk->trunk_type) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case MGCP_TRUNK_VIRTUAL:</span><br><span style="color: hsl(120, 100%, 40%);">+ number_endpoints = trunk->virtual.vty_number_endpoints;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Note: due to historical reasons the endpoints on the virtual</span><br><span style="color: hsl(120, 100%, 40%);">+ * trunk start counting at 1. */</span><br><span style="color: hsl(120, 100%, 40%);">+ offset_endpoints = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MGCP_TRUNK_E1:</span><br><span style="color: hsl(120, 100%, 40%);">+ number_endpoints = trunk->e1.vty_timeslot_num * MGCP_ENDP_E1_SUBSLOTS;</span><br><span style="color: hsl(120, 100%, 40%);">+ offset_endpoints = trunk->e1.vty_timeslot_first * MGCP_ENDP_E1_SUBSLOTS;</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(false);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Make sure the amount of requested endpoints does not execeed</span><br><span style="color: hsl(120, 100%, 40%);">+ * sane limits. The VTY already limits the possible amount,</span><br><span style="color: hsl(120, 100%, 40%);">+ * however miss-initalation of the struct or memory corruption</span><br><span style="color: hsl(120, 100%, 40%);">+ * could still lead to an excessive allocation of endpoints, so</span><br><span style="color: hsl(120, 100%, 40%);">+ * better stop early if that is the case. */</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(number_endpoints < 65534);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* allocate pointer array for the endpoints */</span><br><span> trunk->endpoints = _talloc_zero_array(trunk->cfg,</span><br><span style="color: hsl(0, 100%, 40%);">- sizeof(struct mgcp_endpoint *), trunk->vty_number_endpoints, "endpoints");</span><br><span style="color: hsl(120, 100%, 40%);">+ sizeof(struct mgcp_endpoint *), number_endpoints, "endpoints");</span><br><span> if (!trunk->endpoints)</span><br><span> return -1;</span><br><span> </span><br><span> /* create endpoints */</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = 0; i < trunk->vty_number_endpoints; ++i) {</span><br><span style="color: hsl(0, 100%, 40%);">- endp = mgcp_endp_alloc(trunk, i);</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < number_endpoints; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ endp = mgcp_endp_alloc(trunk, i + offset_endpoints);</span><br><span> if (!endp) {</span><br><span> talloc_free(trunk->endpoints);</span><br><span> return -1;</span><br><span>@@ -98,7 +118,7 @@</span><br><span> }</span><br><span> </span><br><span> /* make the endpoints we just created available to the MGW code */</span><br><span style="color: hsl(0, 100%, 40%);">- trunk->number_endpoints = trunk->vty_number_endpoints;</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->number_endpoints = number_endpoints;</span><br><span> </span><br><span> return 0;</span><br><span> }</span><br><span>diff --git a/src/libosmo-mgcp/mgcp_vty.c b/src/libosmo-mgcp/mgcp_vty.c</span><br><span>index 683d2ed..2310b6a 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_vty.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_vty.c</span><br><span>@@ -112,7 +112,7 @@</span><br><span> trunk->audio_send_name ? "" : "no ", VTY_NEWLINE);</span><br><span> vty_out(vty, " loop %u%s", ! !trunk->audio_loop, VTY_NEWLINE);</span><br><span> vty_out(vty, " number endpoints %u%s",</span><br><span style="color: hsl(0, 100%, 40%);">- trunk->vty_number_endpoints - 1, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->virtual.vty_number_endpoints, VTY_NEWLINE);</span><br><span> vty_out(vty, " %sallow-transcoding%s",</span><br><span> trunk->no_audio_transcoding ? "no " : "", VTY_NEWLINE);</span><br><span> if (g_cfg->call_agent_addr)</span><br><span>@@ -289,7 +289,7 @@</span><br><span> </span><br><span> vty_out(vty, "%s trunk %d with %d endpoints:%s",</span><br><span> trunk->trunk_type == MGCP_TRUNK_VIRTUAL ? "Virtual" : "E1",</span><br><span style="color: hsl(0, 100%, 40%);">- trunk->trunk_nr, trunk->number_endpoints - 1, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->trunk_nr, trunk->number_endpoints, VTY_NEWLINE);</span><br><span> </span><br><span> if (!trunk->endpoints) {</span><br><span> vty_out(vty, "No endpoints allocated yet.%s", VTY_NEWLINE);</span><br><span>@@ -715,8 +715,7 @@</span><br><span> {</span><br><span> struct mgcp_trunk *trunk = mgcp_trunk_by_num(g_cfg, MGCP_TRUNK_VIRTUAL, MGCP_VIRT_TRUNK_ID);</span><br><span> OSMO_ASSERT(trunk);</span><br><span style="color: hsl(0, 100%, 40%);">- /* + 1 as we start counting at one */</span><br><span style="color: hsl(0, 100%, 40%);">- trunk->vty_number_endpoints = atoi(argv[0]) + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->virtual.vty_number_endpoints = atoi(argv[0]);</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span>@@ -934,6 +933,10 @@</span><br><span> trunk->audio_fmtp_extra, VTY_NEWLINE);</span><br><span> vty_out(vty, " %sallow-transcoding%s",</span><br><span> trunk->no_audio_transcoding ? "no " : "", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " timeslot first %u%s",</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->e1.vty_timeslot_first, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " timeslot num %u%s",</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->e1.vty_timeslot_num, VTY_NEWLINE);</span><br><span> }</span><br><span> </span><br><span> return CMD_SUCCESS;</span><br><span>@@ -1160,6 +1163,26 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_trunk_e1_timeslot_first,</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg_trunk_e1_timeslot_first_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "timeslot first <0-31>",</span><br><span style="color: hsl(120, 100%, 40%);">+ "timeslot options" "First E1 timeslot to be used\n" "E1 timeslot number\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct mgcp_trunk *trunk = vty->index;</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->e1.vty_timeslot_first = atoi(argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_trunk_e1_timeslot_num,</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg_trunk_e1_timeslot_num_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "timeslot num <0-31>",</span><br><span style="color: hsl(120, 100%, 40%);">+ "timeslot options" "Number of E1 timeslots to use\n" "E1 timeslot count\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct mgcp_trunk *trunk = vty->index;</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->e1.vty_timeslot_num = atoi(argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN(loop_conn,</span><br><span> loop_conn_cmd,</span><br><span> "loop-endpoint <0-64> NAME (0|1)",</span><br><span>@@ -1550,6 +1573,8 @@</span><br><span> install_element(TRUNK_NODE_E1, &cfg_trunk_no_sdp_payload_send_name_cmd);</span><br><span> install_element(TRUNK_NODE_E1, &cfg_trunk_allow_transcoding_cmd);</span><br><span> install_element(TRUNK_NODE_E1, &cfg_trunk_no_allow_transcoding_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(TRUNK_NODE_E1, &cfg_trunk_e1_timeslot_first_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(TRUNK_NODE_E1, &cfg_trunk_e1_timeslot_num_cmd);</span><br><span> </span><br><span> return 0;</span><br><span> }</span><br><span>diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c</span><br><span>index 8c084b4..c0e70d3 100644</span><br><span>--- a/tests/mgcp/mgcp_test.c</span><br><span>+++ b/tests/mgcp/mgcp_test.c</span><br><span>@@ -605,7 +605,7 @@</span><br><span> </span><br><span> trunk = endp->trunk;</span><br><span> last_endpoint[0] = '\0';</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = 0; i < trunk->vty_number_endpoints; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < trunk->number_endpoints; i++) {</span><br><span> if (strcmp(endp->name, trunk->endpoints[i]->name) == 0)</span><br><span> strcpy(last_endpoint, trunk->endpoints[i]->name);</span><br><span> }</span><br><span>@@ -655,7 +655,7 @@</span><br><span> static void mgcp_endpoints_release(struct mgcp_trunk *trunk)</span><br><span> {</span><br><span> int i;</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = 1; i < trunk->number_endpoints; i++)</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < trunk->number_endpoints; i++)</span><br><span> mgcp_endp_release(trunk->endpoints[i]);</span><br><span> }</span><br><span> </span><br><span>@@ -770,7 +770,7 @@</span><br><span> cfg = mgcp_config_alloc();</span><br><span> trunk = mgcp_trunk_by_num(cfg, MGCP_TRUNK_VIRTUAL, MGCP_VIRT_TRUNK_ID);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- trunk->vty_number_endpoints = 64;</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->virtual.vty_number_endpoints = 64;</span><br><span> mgcp_trunk_alloc_endpts(trunk);</span><br><span> cfg->policy_cb = mgcp_test_policy_cb;</span><br><span> </span><br><span>@@ -912,7 +912,7 @@</span><br><span> cfg = mgcp_config_alloc();</span><br><span> trunk = mgcp_trunk_by_num(cfg, MGCP_TRUNK_VIRTUAL, MGCP_VIRT_TRUNK_ID);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- trunk->vty_number_endpoints = 64;</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->virtual.vty_number_endpoints = 64;</span><br><span> mgcp_trunk_alloc_endpts(trunk);</span><br><span> </span><br><span> memset(last_conn_id, 0, sizeof(last_conn_id));</span><br><span>@@ -982,7 +982,7 @@</span><br><span> trunk = mgcp_trunk_by_num(cfg, MGCP_TRUNK_VIRTUAL, MGCP_VIRT_TRUNK_ID);</span><br><span> cfg->rqnt_cb = rqnt_cb;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- trunk->vty_number_endpoints = 64;</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->virtual.vty_number_endpoints = 64;</span><br><span> mgcp_trunk_alloc_endpts(trunk);</span><br><span> </span><br><span> trunk2 = mgcp_trunk_alloc(cfg, MGCP_TRUNK_E1, 1);</span><br><span>@@ -1063,7 +1063,7 @@</span><br><span> </span><br><span> endp.cfg = &cfg;</span><br><span> endp.type = &ep_typeset.rtp;</span><br><span style="color: hsl(0, 100%, 40%);">- trunk.vty_number_endpoints = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk.virtual.vty_number_endpoints = 1;</span><br><span> trunk.endpoints = endpoints;</span><br><span> trunk.endpoints[0] = &endp;</span><br><span> endp.trunk = &trunk;</span><br><span>@@ -1315,7 +1315,7 @@</span><br><span> endp.cfg = &cfg;</span><br><span> endp.type = &ep_typeset.rtp;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- trunk.vty_number_endpoints = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk.virtual.vty_number_endpoints = 1;</span><br><span> trunk.endpoints = endpoints;</span><br><span> trunk.endpoints[0] = &endp;</span><br><span> trunk.force_constant_ssrc = patch_ssrc;</span><br><span>@@ -1394,7 +1394,7 @@</span><br><span> </span><br><span> cfg = mgcp_config_alloc();</span><br><span> trunk = mgcp_trunk_by_num(cfg, MGCP_TRUNK_VIRTUAL, MGCP_VIRT_TRUNK_ID);</span><br><span style="color: hsl(0, 100%, 40%);">- trunk->vty_number_endpoints = 64;</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->virtual.vty_number_endpoints = 64;</span><br><span> mgcp_trunk_alloc_endpts(trunk);</span><br><span> cfg->policy_cb = mgcp_test_policy_cb;</span><br><span> </span><br><span>@@ -1540,7 +1540,7 @@</span><br><span> </span><br><span> cfg = mgcp_config_alloc();</span><br><span> trunk = mgcp_trunk_by_num(cfg, MGCP_TRUNK_VIRTUAL, MGCP_VIRT_TRUNK_ID);</span><br><span style="color: hsl(0, 100%, 40%);">- trunk->vty_number_endpoints = 64;</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->virtual.vty_number_endpoints = 64;</span><br><span> mgcp_trunk_alloc_endpts(trunk);</span><br><span> </span><br><span> endp = mgcp_endp_by_name(NULL, "rtpbridge/1@mgw", cfg);</span><br><span>@@ -1590,7 +1590,7 @@</span><br><span> cfg = mgcp_config_alloc();</span><br><span> trunk = mgcp_trunk_by_num(cfg, MGCP_TRUNK_VIRTUAL, MGCP_VIRT_TRUNK_ID);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- trunk->vty_number_endpoints = 64;</span><br><span style="color: hsl(120, 100%, 40%);">+ trunk->virtual.vty_number_endpoints = 64;</span><br><span> trunk->audio_send_name = 0;</span><br><span> mgcp_trunk_alloc_endpts(trunk);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19121">change 19121</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/19121"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I73b31e3c236a61ea0a6f76ef5ff98ce589f52c77 </div>
<div style="display:none"> Gerrit-Change-Number: 19121 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>