<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19063">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_04_08_rr: fix hopping parameters in RR Assignment Command<br><br>According to 3GPP TS 44.018, section 9.1.2.4, if at least one of<br>the Channel Description IEs indicates frequency hopping, one and<br>only one of the following IEs shall be present:<br><br> - Mobile Allocation, after time (see 10.5.2.21);<br> - Frequency List, after time (see 10.5.2.13).<br><br>For some reason, osmo-bsc includes the GSM48_IE_MA_BEFORE instead<br>of GSM48_IE_MA_AFTER - fix this.<br><br>According to section 9.1.2.6 of the same document, if any of the<br>Mobile Allocation IEs (before/after time) is present, then the<br>network must ensure that either the MS has already received the<br>the proper reference cell frequency list (CA), or that the Cell<br>Channel Description IE (see 10.5.2.1b) is present.<br><br>Without this IE, the phone I was using in my testing setup sends<br>RR Status message with cause #100 "conditional IE error".<br><br>Fortunately, we already have generate_cell_chan_list(), since we<br>also need to include the Cell Channel Description in SI Type 1.<br><br>Change-Id: I43ef66c109b107ebcaa1cb6197637701b13b3787<br>Related: SYS#4868, OS#4545, OS#4546<br>---<br>M src/osmo-bsc/gsm_04_08_rr.c<br>1 file changed, 9 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c</span><br><span>index 8a74aab..f47c31f 100644</span><br><span>--- a/src/osmo-bsc/gsm_04_08_rr.c</span><br><span>+++ b/src/osmo-bsc/gsm_04_08_rr.c</span><br><span>@@ -43,6 +43,7 @@</span><br><span> #include <osmocom/bsc/handover_fsm.h></span><br><span> #include <osmocom/bsc/gsm_08_08.h></span><br><span> #include <osmocom/bsc/gsm_data.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/system_information.h></span><br><span> </span><br><span> </span><br><span> int gsm48_sendmsg(struct msgb *msg)</span><br><span>@@ -576,13 +577,18 @@</span><br><span> gsm48_lchan2chan_desc(&ass->chan_desc, lchan);</span><br><span> ass->power_command = power_command;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* optional: cell channel description */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Cell Channel Description (freq. hopping), TV (see 3GPP TS 44.018, 10.5.2.1b) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (lchan->ts->hopping.enabled) {</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t *chan_desc = msgb_put(msg, 1 + 16); /* tag + fixed length */</span><br><span style="color: hsl(120, 100%, 40%);">+ generate_cell_chan_list(chan_desc + 1, dest_lchan->ts->trx->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ chan_desc[0] = GSM48_IE_CELL_CH_DESC;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> msgb_tv_put(msg, GSM48_IE_CHANMODE_1, lchan->tch_mode);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* mobile allocation in case of hopping */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Mobile Allocation (freq. hopping), TLV (see 3GPP TS 44.018, 10.5.2.21) */</span><br><span> if (lchan->ts->hopping.enabled) {</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_tlv_put(msg, GSM48_IE_MA_BEFORE, lchan->ts->hopping.ma_len,</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_tlv_put(msg, GSM48_IE_MA_AFTER, lchan->ts->hopping.ma_len,</span><br><span> lchan->ts->hopping.ma_data);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19063">change 19063</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19063"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I43ef66c109b107ebcaa1cb6197637701b13b3787 </div>
<div style="display:none"> Gerrit-Change-Number: 19063 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>