<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19073">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: Introduce test TC_ul_flow_multiple_llc_blocks<br><br>Related: OS#4559<br><br>Change-Id: I62f42981d31bc5c2e4c61e92bea329bd74cb2d19<br>---<br>M library/RLCMAC_Templates.ttcn<br>M pcu/GPRS_Components.ttcn<br>M pcu/PCU_Tests.ttcn<br>3 files changed, 128 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/19073/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/RLCMAC_Templates.ttcn b/library/RLCMAC_Templates.ttcn</span><br><span>index 939a814..848052e 100644</span><br><span>--- a/library/RLCMAC_Templates.ttcn</span><br><span>+++ b/library/RLCMAC_Templates.ttcn</span><br><span>@@ -683,17 +683,27 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Template for a LlcBlock (part of a LLC frame inside RlcMac?lDataBlock */</span><br><span style="color: hsl(0, 100%, 40%);">- template LlcBlock t_RLCMAC_LLCBLOCK(octetstring data, boolean more := false, boolean e := true) := {</span><br><span style="color: hsl(0, 100%, 40%);">- /* let encoder figure out the header */</span><br><span style="color: hsl(0, 100%, 40%);">- hdr := omit,</span><br><span style="color: hsl(120, 100%, 40%);">+ template LlcBlockHdr t_RLCMAC_LLCBLOCK_HDR(uint16_t length_ind, boolean more, boolean e) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ length_ind := length_ind,</span><br><span style="color: hsl(120, 100%, 40%);">+ more := more, /* 1 = new LLC PDU starts */</span><br><span style="color: hsl(120, 100%, 40%);">+ e := e /* 0 = another extension octet after LLC PDU, 1 = no more extension octets */</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ template EgprsLlcBlockHdr t_RLCMAC_LLCBLOCK_EGPRS_HDR(uint16_t length_ind, boolean e) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ length_ind := length_ind,</span><br><span style="color: hsl(120, 100%, 40%);">+ e := e /* 0 = another extension octet after LLC PDU, 1 = no more extension octets */</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Template for a LlcBlock (part of a LLC frame inside RlcMacDlDataBlock */</span><br><span style="color: hsl(120, 100%, 40%);">+ template LlcBlock t_RLCMAC_LLCBLOCK(octetstring data, template (omit) LlcBlockHdr llc_hdr := omit) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ hdr := llc_hdr, /* omit = let encoder figure out the header */</span><br><span> payload := data</span><br><span> }</span><br><span> </span><br><span> /* Template for a LlcBlock (part of a LLC frame inside RlcMacEgprs?lDataBlock */</span><br><span style="color: hsl(0, 100%, 40%);">- template EgprsLlcBlock t_RLCMAC_LLCBLOCK_EGPRS(octetstring data, boolean e := true) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ template EgprsLlcBlock t_RLCMAC_LLCBLOCK_EGPRS(octetstring data, template (omit) EgprsLlcBlockHdr llc_hdr := omit) := {</span><br><span> /* let encoder figure out the header */</span><br><span style="color: hsl(0, 100%, 40%);">- hdr := omit,</span><br><span style="color: hsl(120, 100%, 40%);">+ hdr := llc_hdr, /* omit = let encoder figure out the header */</span><br><span> payload := data</span><br><span> }</span><br><span> </span><br><span>diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn</span><br><span>index 392440c..3eb3f9f 100644</span><br><span>--- a/pcu/GPRS_Components.ttcn</span><br><span>+++ b/pcu/GPRS_Components.ttcn</span><br><span>@@ -263,6 +263,12 @@</span><br><span> return dl_tbf;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+function f_ultbf_inc_bsn(inout UlTbf ul_tbf)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on MS_BTS_IFACE_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_tbf.bsn := ul_tbf.bsn + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_tbf.bsn := ul_tbf.bsn mod 128; /* FIXME: EGPRS SNS: 2048 */</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> function f_ms_use_ra(inout GprsMS ms, uint16_t ra, uint8_t ra_is_11bit := 0)</span><br><span> runs on MS_BTS_IFACE_CT {</span><br><span> ms.ra_is_11bit := ra_is_11bit;</span><br><span>@@ -353,10 +359,8 @@</span><br><span> ul_data.data.mac_hdr.tlli_ind := true;</span><br><span> ul_data.data.tlli := ms.tlli;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- ms.ul_tbf.bsn := ms.ul_tbf.bsn + 1;</span><br><span style="color: hsl(0, 100%, 40%);">- ms.ul_tbf.bsn := ms.ul_tbf.bsn mod 128; /* FIXME: EGPRS SNS: 2048 */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ultbf_inc_bsn(ms.ul_tbf);</span><br><span> return f_ms_tx_ul_block(ms, ul_data, fn);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> }</span><br><span> </span><br><span> /* Send random payload for last "num_blocks" blocks in Ul TBF (ending with CV=0). */</span><br><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index bdcf7c1..c5f4b59 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -1333,6 +1333,110 @@</span><br><span> f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify Decoding and segmentation of UL LLC PDUs into RLC data blocks, OS#4559.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Check "GPRS from A-Z" slide "Example of LI-Field and E-Bit" page 186.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Check "3GPP TS 44.060" Annex B. */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_ul_flow_multiple_llc_blocks() runs on RAW_PCU_Test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var RlcmacDlBlock dl_block;</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring dataA := f_rnd_octstring(20);</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring dataB := f_rnd_octstring(13);</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring dataC := f_rnd_octstring(3);</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring dataD := f_rnd_octstring(12);</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint32_t sched_fn;</span><br><span style="color: hsl(120, 100%, 40%);">+ var GprsMS ms;</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (value) RlcmacUlBlock ul_data;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize NS/BSSGP side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_bssgp();</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize GPRS MS side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_gprs_ms();</span><br><span style="color: hsl(120, 100%, 40%);">+ ms := g_ms[0]; /* We only use first MS in this test */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize the PCU interface abstraction */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_raw(testcasename());</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish BSSGP connection to the PCU */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_establish();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_llgmm_assign('FFFFFFFF'O, ms.tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish an Uplink TBF */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_establish_ul_tbf(ms);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Summary of what's transmitted:</span><br><span style="color: hsl(120, 100%, 40%);">+ * 1- UL RlcDataBlock(dataA) [BSN=0, CV=3]</span><br><span style="color: hsl(120, 100%, 40%);">+ * 2- UL RlcDataBlock(dataA finished, dataB starts) [BSN=1, CV=2]</span><br><span style="color: hsl(120, 100%, 40%);">+ * 3- UL RlcDataBlock(dataB finished, dataC starts and finishes, dataD starts) [BSN=2, CV=1]</span><br><span style="color: hsl(120, 100%, 40%);">+ * 4- UL RlcDataBlock(dataD finishes) [BSN=3, CV=0]</span><br><span style="color: hsl(120, 100%, 40%);">+ And on SGSN we receive 4 packets, one for each LlcBlock dataA..D.</span><br><span style="color: hsl(120, 100%, 40%);">+ We'll also receive some UL ACK/NACK we need to reply with CTRL ACK.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* UL RlcDataBlock(dataA) [BSN=0, CV=3] */</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_data := t_RLCMAC_UL_DATA_TLLI(tfi := ms.ul_tbf.tfi,</span><br><span style="color: hsl(120, 100%, 40%);">+ cv := 3,</span><br><span style="color: hsl(120, 100%, 40%);">+ bsn := ms.ul_tbf.bsn,</span><br><span style="color: hsl(120, 100%, 40%);">+ blocks := { t_RLCMAC_LLCBLOCK(substr(dataA, 0, 16)) },</span><br><span style="color: hsl(120, 100%, 40%);">+ tlli := ms.tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Indicate no llc header, meaning first LLC block doesn't finish in current</span><br><span style="color: hsl(120, 100%, 40%);">+ * RLCMAC block being sent. */</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_data.data.mac_hdr.e := true;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ultbf_inc_bsn(ms.ul_tbf);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ul_data);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* UL RlcDataBlock(dataA finished, dataB starts) [BSN=1, CV=2] */</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_data := t_RLCMAC_UL_DATA_TLLI(tfi := ms.ul_tbf.tfi,</span><br><span style="color: hsl(120, 100%, 40%);">+ cv := 2,</span><br><span style="color: hsl(120, 100%, 40%);">+ bsn := ms.ul_tbf.bsn,</span><br><span style="color: hsl(120, 100%, 40%);">+ blocks := { t_RLCMAC_LLCBLOCK(substr(dataA, 16, 4),</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RLCMAC_LLCBLOCK_HDR(length_ind := 4, more := true, e := true)),</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RLCMAC_LLCBLOCK(substr(dataB, 0, 11))</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ tlli := ms.tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ultbf_inc_bsn(ms.ul_tbf);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ul_data);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* UL block dataA should be received in SGSN */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[0].receive(tr_BSSGP_UL_UD(ms.tlli, mp_gb_cfg.cell_id, dataA));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* UL RlcDataBlock(dataB finished, dataC starts and finishes, dataD starts) [BSN=2, CV=1] */</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_data := t_RLCMAC_UL_DATA_TLLI(tfi := ms.ul_tbf.tfi,</span><br><span style="color: hsl(120, 100%, 40%);">+ cv := 1,</span><br><span style="color: hsl(120, 100%, 40%);">+ bsn := ms.ul_tbf.bsn,</span><br><span style="color: hsl(120, 100%, 40%);">+ blocks := { t_RLCMAC_LLCBLOCK(substr(dataB, 11, 2),</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RLCMAC_LLCBLOCK_HDR(length_ind := 2, more := true, e := false)),</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RLCMAC_LLCBLOCK(substr(dataC, 0, 3),</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RLCMAC_LLCBLOCK_HDR(length_ind := 3, more := true, e := true)),</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RLCMAC_LLCBLOCK(substr(dataD, 0, 9))</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ tlli := ms.tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ultbf_inc_bsn(ms.ul_tbf);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ul_data);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* UL block dataB and dataC should be received in SGSN */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[0].receive(tr_BSSGP_UL_UD(ms.tlli, mp_gb_cfg.cell_id, dataB));</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[0].receive(tr_BSSGP_UL_UD(ms.tlli, mp_gb_cfg.cell_id, dataC));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* UL RlcDataBlock(dataD finishes) [BSN=3, CV=0] */</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_data := t_RLCMAC_UL_DATA_TLLI(tfi := ms.ul_tbf.tfi,</span><br><span style="color: hsl(120, 100%, 40%);">+ cv := 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ bsn := ms.ul_tbf.bsn,</span><br><span style="color: hsl(120, 100%, 40%);">+ blocks := { t_RLCMAC_LLCBLOCK(substr(dataD, 9, 3),</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RLCMAC_LLCBLOCK_HDR(length_ind := 3, more := false, e := true))</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ tlli := ms.tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ultbf_inc_bsn(ms.ul_tbf);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ul_data);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* UL block dataB and dataD should be received in SGSN */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[0].receive(tr_BSSGP_UL_UD(ms.tlli, mp_gb_cfg.cell_id, dataD));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> private function f_pkt_paging_match_imsi(in PacketPagingReq req, hexstring imsi)</span><br><span> runs on RAW_PCU_Test_CT {</span><br><span> var MobileIdentityLV_Paging mi_lv := req.repeated_pageinfo.cs.mobile_identity;</span><br><span>@@ -1766,6 +1870,7 @@</span><br><span> execute (TC_ul_intermediate_retrans() );</span><br><span> execute( TC_imm_ass_dl_block_retrans() );</span><br><span> execute( TC_dl_flow_more_blocks() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute (TC_ul_flow_multiple_llc_blocks() );</span><br><span> execute( TC_paging_cs_from_bts() );</span><br><span> execute( TC_paging_cs_from_sgsn_sign_ptmsi() );</span><br><span> execute( TC_paging_cs_from_sgsn_sign() );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19073">change 19073</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19073"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I62f42981d31bc5c2e4c61e92bea329bd74cb2d19 </div>
<div style="display:none"> Gerrit-Change-Number: 19073 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>