<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-e1d/+/19045">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-e1d/+/19045/1/src/intf_line.c">File src/intf_line.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-e1d/+/19045/1/src/intf_line.c@71">Patch Set #1, Line 71:</a> <code style="font-family:monospace,monospace">_e1_intf_destroy(struct e1_intf *intf)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">_ prefix</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also, I'm getting a bit confused about the e1_ vs e1d_ prefix and what belongs where logically.<br>(I'm just looking at the individual patches ATM so I don't have a clear view of the final code organization).</p><p style="white-space: pre-wrap; word-wrap: break-word;">But obviously it's confusing since the commit title uses e1d_ and the function is actually e1_ ...</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1d/+/19045">change 19045</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1d/+/19045"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1d </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5425d22288d7239063d621bddfe81e9cf21f1a5b </div>
<div style="display:none"> Gerrit-Change-Number: 19045 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Assignee: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 29 Jun 2020 14:03:16 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>