<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/19028">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-bts-trx/scheduler: cosmetic: move trx_if_powered() check<br><br>I believe the modern compilers are smart enough to optimize the<br>outer (per-timeslot) loop of trx_sched_fn() in a way that TDMA<br>frame number is advanced after making sure that a transceiver<br>is powered on.  However, it's still more perspicuous to check<br>availability of a given transceiver first.<br><br>Change-Id: I6a97000c1c84e36096e9ba378a489c82caa4cc5b<br>---<br>M src/osmo-bts-trx/scheduler_trx.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/28/19028/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c</span><br><span>index 6122ad0..472bae8 100644</span><br><span>--- a/src/osmo-bts-trx/scheduler_trx.c</span><br><span>+++ b/src/osmo-bts-trx/scheduler_trx.c</span><br><span>@@ -73,14 +73,14 @@</span><br><span>               struct trx_l1h *l1h = pinst->u.osmotrx.hdl;</span><br><span>               struct l1sched_trx *l1t = &l1h->l1s;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-         /* advance frame number, so the transceiver has more</span><br><span style="color: hsl(0, 100%, 40%);">-             * time until it must be transmitted. */</span><br><span style="color: hsl(0, 100%, 40%);">-                sched_fn = GSM_TDMA_FN_SUM(fn, plink->u.osmotrx.clock_advance);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>           /* we don't schedule, if power is off */</span><br><span>                 if (!trx_if_powered(l1h))</span><br><span>                    continue;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+         /* advance frame number, so the transceiver has more</span><br><span style="color: hsl(120, 100%, 40%);">+           * time until it must be transmitted. */</span><br><span style="color: hsl(120, 100%, 40%);">+              sched_fn = GSM_TDMA_FN_SUM(fn, plink->u.osmotrx.clock_advance);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                 /* process every TS of TRX */</span><br><span>                for (tn = 0; tn < ARRAY_SIZE(l1t->ts); tn++) {</span><br><span>                         /* ready-to-send */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/19028">change 19028</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/19028"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6a97000c1c84e36096e9ba378a489c82caa4cc5b </div>
<div style="display:none"> Gerrit-Change-Number: 19028 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>