<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/19004">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved; Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_ss7: remove use-after-free of stream_server after close_cb<br><br>In I9b3ae6dfcf6efeabb7fb6c33503d1d7924fec2fa we fixed some problems<br>regarding rapid open/close cycles of inbound M3UA client connections.<br>Unfortunately the fix now triggered another bug.<br><br>xua_srv_conn_closed_cb() is called by libosmo-netif stream code whenever<br>a connection (socket) is closed.  As the stream_server is de-allocated<br>right after this call-back, the call-back must make sure to remove<br>any pending references to the stream_server.<br><br>Change-Id: I2464cf524f1f91bfad10ff1861a03bf1461dfed8<br>Related: OS#4625<br>---<br>M src/osmo_ss7.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c</span><br><span>index 9aeed9b..cdac27a 100644</span><br><span>--- a/src/osmo_ss7.c</span><br><span>+++ b/src/osmo_ss7.c</span><br><span>@@ -1786,12 +1786,13 @@</span><br><span>       /* send M-SCTP_RELEASE.ind to Layer Manager */</span><br><span>       xua_asp_send_xlm_prim_simple(asp, OSMO_XLM_PRIM_M_SCTP_RELEASE, PRIM_OP_INDICATION);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      asp->server = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     /* if we were dynamically allocated at accept_cb() time, let's</span><br><span>    * self-destruct now.  A new connection will re-create the ASP. */</span><br><span>   if (asp->dyn_allocated) {</span><br><span>                 /* avoid re-entrance via osmo_stream_srv_destroy() which</span><br><span>              * called us */</span><br><span style="color: hsl(0, 100%, 40%);">-         asp->server = NULL;</span><br><span>               osmo_ss7_asp_destroy(asp);</span><br><span>   }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/19004">change 19004</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/19004"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2464cf524f1f91bfad10ff1861a03bf1461dfed8 </div>
<div style="display:none"> Gerrit-Change-Number: 19004 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: Jenkins Builder </div>
<div style="display:none"> Gerrit-MessageType: merged </div>