<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/19011">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-bts-trx/schedulder: get rid of _sched_fcch_burst<br><br>According to 3GPP 45.002, section 5.2.4, a frequency correction<br>burst is basically a sequence of zeros.  Since br->burst is already<br>zero-initialized, there is no need to maintain and memcpy() another<br>sequence of zeros into it. Just set the length.<br><br>Change-Id: Ic4f6d550010da5caf4bc471ff1e184c9fab30c6d<br>---<br>M include/osmo-bts/scheduler_backend.h<br>M src/common/scheduler.c<br>M src/osmo-bts-trx/sched_lchan_fcch_sch.c<br>3 files changed, 2 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/11/19011/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-bts/scheduler_backend.h b/include/osmo-bts/scheduler_backend.h</span><br><span>index be23c47..eb8039f 100644</span><br><span>--- a/include/osmo-bts/scheduler_backend.h</span><br><span>+++ b/include/osmo-bts/scheduler_backend.h</span><br><span>@@ -37,7 +37,6 @@</span><br><span> </span><br><span> extern const ubit_t _sched_tsc[8][26];</span><br><span> extern const ubit_t _sched_egprs_tsc[8][78];</span><br><span style="color: hsl(0, 100%, 40%);">-extern const ubit_t _sched_fcch_burst[148];</span><br><span> extern const ubit_t _sched_sch_train[64];</span><br><span> </span><br><span> struct msgb *_sched_dequeue_prim(struct l1sched_trx *l1t, int8_t tn, uint32_t fn,</span><br><span>diff --git a/src/common/scheduler.c b/src/common/scheduler.c</span><br><span>index 62efed4..3068918 100644</span><br><span>--- a/src/common/scheduler.c</span><br><span>+++ b/src/common/scheduler.c</span><br><span>@@ -62,15 +62,6 @@</span><br><span>     0,0,0,</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*! \brief FCCH Burst (TS 05.02 Chapter 5.2.4) */</span><br><span style="color: hsl(0, 100%, 40%);">-const ubit_t _sched_fcch_burst[GSM_BURST_LEN] = {</span><br><span style="color: hsl(0, 100%, 40%);">-      0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,</span><br><span style="color: hsl(0, 100%, 40%);">-        0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,</span><br><span style="color: hsl(0, 100%, 40%);">-        0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,</span><br><span style="color: hsl(0, 100%, 40%);">-        0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,</span><br><span style="color: hsl(0, 100%, 40%);">-        0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /*! \brief Training Sequences (TS 05.02 Chapter 5.2.3) */</span><br><span> const ubit_t _sched_tsc[8][26] = {</span><br><span>        { 0,0,1,0,0,1,0,1,1,1,0,0,0,0,1,0,0,0,1,0,0,1,0,1,1,1, },</span><br><span>diff --git a/src/osmo-bts-trx/sched_lchan_fcch_sch.c b/src/osmo-bts-trx/sched_lchan_fcch_sch.c</span><br><span>index bc03f81..2a5e482 100644</span><br><span>--- a/src/osmo-bts-trx/sched_lchan_fcch_sch.c</span><br><span>+++ b/src/osmo-bts-trx/sched_lchan_fcch_sch.c</span><br><span>@@ -40,7 +40,8 @@</span><br><span> {</span><br><span>  LOGL1S(DL1P, LOGL_DEBUG, l1t, br->tn, chan, br->fn, "Transmitting FCCH\n");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- memcpy(br->burst, _sched_fcch_burst, GSM_BURST_LEN);</span><br><span style="color: hsl(120, 100%, 40%);">+       /* A frequency correction burst is basically a sequence of zeros.</span><br><span style="color: hsl(120, 100%, 40%);">+      * Since br->burst is already zero-initialized, just set the length. */</span><br><span>   br->burst_len = GSM_BURST_LEN;</span><br><span> </span><br><span>        return 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/19011">change 19011</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/19011"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic4f6d550010da5caf4bc471ff1e184c9fab30c6d </div>
<div style="display:none"> Gerrit-Change-Number: 19011 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>