<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18979">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/RSL: pass lost link event to upper layers instead of failing<br><br>Some tests may expect that behavior so let the test decide what to do<br>with it.<br><br>Change-Id: Idd4bdfc99514f4c439837f0ce4a20ec5ff45e86c<br>---<br>M library/RSL_Emulation.ttcn<br>1 file changed, 24 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn</span><br><span>index 66cc4dc..2fcb96c 100644</span><br><span>--- a/library/RSL_Emulation.ttcn</span><br><span>+++ b/library/RSL_Emulation.ttcn</span><br><span>@@ -394,6 +394,20 @@</span><br><span> return f_streamId_by_trx(trx_nr);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+private function f_trx_conn_map_unregister(integer conn_id)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on RSL_Emulation_CT return IpaStreamId {</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (var integer i := 0; i < sizeof(TrxConnMap); i := i + 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (conn_id == TrxConnMap[i]) {</span><br><span style="color: hsl(120, 100%, 40%);">+ TrxConnMap[i] := -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ TrxConnNum := TrxConnNum - 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ return f_streamId_by_trx(i);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ testcase.stop("Trying to unregister an unknown conn_id=", conn_id);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> private function f_trx_conn_map_resolve(IpaStreamId id)</span><br><span> runs on RSL_Emulation_CT return integer {</span><br><span> var integer trx_nr := f_trx_by_streamId(id);</span><br><span>@@ -498,12 +512,17 @@</span><br><span> /* Notify the upper layers about a new connection */</span><br><span> CCHAN_PT.send(ts_RSLEm_EV(RSLEM_EV_TRX_UP, sid));</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- [bts_role] IPA_PT.receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_DOWN)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Lost IPA connection!");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+ [bts_role] IPA_PT.receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_DOWN)) -> value evt {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("Lost IPA connection! (conn_id=", evt.conn_id, "): ", evt.id_resp);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Notify the upper layers about lost connection */</span><br><span style="color: hsl(120, 100%, 40%);">+ var IpaStreamId sid := f_trx_conn_map_unregister(evt.conn_id);</span><br><span style="color: hsl(120, 100%, 40%);">+ CCHAN_PT.send(ts_RSLEm_EV(RSLEM_EV_TRX_DOWN, sid));</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- [not bts_role] IPA_PT.receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_DOWN)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Lost IPA connection!");</span><br><span style="color: hsl(120, 100%, 40%);">+ [not bts_role] IPA_PT.receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_DOWN)) -> value evt {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("Lost IPA connection! (conn_id=", evt.conn_id, ")");</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Notify the upper layers about lost connection */</span><br><span style="color: hsl(120, 100%, 40%);">+ var IpaStreamId sid := f_trx_conn_map_unregister(evt.conn_id);</span><br><span style="color: hsl(120, 100%, 40%);">+ CCHAN_PT.send(ts_RSLEm_EV(RSLEM_EV_TRX_DOWN, sid));</span><br><span> }</span><br><span> [bts_role] IPA_PT.receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_ID_ACK)) {</span><br><span> IPA_PT.send(ts_ASP_RSL_UD(ts_RSL_PAGING_LOAD_IND(23)));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18979">change 18979</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18979"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idd4bdfc99514f4c439837f0ce4a20ec5ff45e86c </div>
<div style="display:none"> Gerrit-Change-Number: 18979 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>