<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18904">View Change</a></p><div style="white-space:pre-wrap">Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Implement tx power ramp down during BTS shutdown<br><br>Upon BTS shutdown (for instance because the Abis link against BSC was<br>lost), stop the operation in an ordered manner (cell soft lock). This<br>means slowly decrease tx power so that MS have time to handover to other<br>neighbour cells.<br><br>Related: SYS#4920<br>Change-Id: I70e34dda8974ebd94aea33bd9fb1d99f9063cc55<br>---<br>M include/osmo-bts/bts_shutdown_fsm.h<br>M src/common/bts_shutdown_fsm.c<br>M src/common/gsm_data.c<br>3 files changed, 43 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-bts/bts_shutdown_fsm.h b/include/osmo-bts/bts_shutdown_fsm.h</span><br><span>index 1268b2b..42f953a 100644</span><br><span>--- a/include/osmo-bts/bts_shutdown_fsm.h</span><br><span>+++ b/include/osmo-bts/bts_shutdown_fsm.h</span><br><span>@@ -33,6 +33,7 @@</span><br><span> </span><br><span> enum bts_shutdown_fsm_events {</span><br><span> BTS_SHUTDOWN_EV_START,</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS_SHUTDOWN_EV_TRX_RAMP_COMPL,</span><br><span> };</span><br><span> </span><br><span> extern struct osmo_fsm bts_shutdown_fsm;</span><br><span>diff --git a/src/common/bts_shutdown_fsm.c b/src/common/bts_shutdown_fsm.c</span><br><span>index 50ef652..faa92a0 100644</span><br><span>--- a/src/common/bts_shutdown_fsm.c</span><br><span>+++ b/src/common/bts_shutdown_fsm.c</span><br><span>@@ -47,17 +47,41 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void ramp_down_compl_cb(struct gsm_bts_trx *trx) {</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_dispatch(trx->bts->shutdown_fi, BTS_SHUTDOWN_EV_TRX_RAMP_COMPL, trx);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void st_wait_ramp_down_compl_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- /* TODO: here power ramp down will be started on all TRX, prior to changing state */</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts_trx *trx;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_for_each_entry(trx, &bts->trx_list, list)</span><br><span style="color: hsl(120, 100%, 40%);">+ power_ramp_start(trx, to_mdB(-10), 1, ramp_down_compl_cb);</span><br><span> }</span><br><span> </span><br><span> static void st_wait_ramp_down_compl(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- /* TODO: In here once we have ramp down implemented we'll transit to</span><br><span style="color: hsl(0, 100%, 40%);">- regular exit. For now we simply wait for state timeout</span><br><span style="color: hsl(0, 100%, 40%);">- bts_shutdown_fsm_state_chg(fi, BTS_SHUTDOWN_ST_EXIT);</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts_trx *src_trx;</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int remaining = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts_trx *trx;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ switch(event) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case BTS_SHUTDOWN_EV_TRX_RAMP_COMPL:</span><br><span style="color: hsl(120, 100%, 40%);">+ src_trx = (struct gsm_bts_trx *)data;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_for_each_entry(trx, &bts->trx_list, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (trx->power_params.p_total_cur_mdBm > 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ remaining++;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPFSML(fi, LOGL_INFO, "%s Ramping down complete, %u TRX remaining\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ gsm_trx_name(src_trx), remaining);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (remaining == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_shutdown_fsm_state_chg(fi, BTS_SHUTDOWN_ST_EXIT);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span> </span><br><span> static void st_exit_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state)</span><br><span>@@ -82,7 +106,8 @@</span><br><span> .action = st_none,</span><br><span> },</span><br><span> [BTS_SHUTDOWN_ST_WAIT_RAMP_DOWN_COMPL] = {</span><br><span style="color: hsl(0, 100%, 40%);">- .in_event_mask = 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ .in_event_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+ X(BTS_SHUTDOWN_EV_TRX_RAMP_COMPL),</span><br><span> .out_state_mask =</span><br><span> X(BTS_SHUTDOWN_ST_EXIT),</span><br><span> .name = "WAIT_RAMP_DOWN_COMPL",</span><br><span>@@ -97,6 +122,7 @@</span><br><span> </span><br><span> const struct value_string bts_shutdown_fsm_event_names[] = {</span><br><span> OSMO_VALUE_STRING(BTS_SHUTDOWN_EV_START),</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_VALUE_STRING(BTS_SHUTDOWN_EV_TRX_RAMP_COMPL),</span><br><span> { 0, NULL }</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/common/gsm_data.c b/src/common/gsm_data.c</span><br><span>index 18d5b66..ae604ec 100644</span><br><span>--- a/src/common/gsm_data.c</span><br><span>+++ b/src/common/gsm_data.c</span><br><span>@@ -40,7 +40,16 @@</span><br><span> #include <osmo-bts/bts_shutdown_fsm.h></span><br><span> </span><br><span> static struct osmo_tdef bts_T_defs[] = {</span><br><span style="color: hsl(0, 100%, 40%);">- { .T=-1, .default_val=1, .desc="Time after which osmo-bts exits if regular ramp down during shut down process does not finish (s)" },</span><br><span style="color: hsl(120, 100%, 40%);">+ /* T-1: FIXME: Ideally should be dynamically calculated per trx at</span><br><span style="color: hsl(120, 100%, 40%);">+ * shutdown start based on params below, and highest trx value taken:</span><br><span style="color: hsl(120, 100%, 40%);">+ * + VTY's power-ramp step-interval.</span><br><span style="color: hsl(120, 100%, 40%);">+ * + Amount of steps needed (taking into account how many dB each step moves).</span><br><span style="color: hsl(120, 100%, 40%);">+ * + Extra time to get response back for each step.</span><br><span style="color: hsl(120, 100%, 40%);">+ * For now we simply give 5 mins, which should be enough for any</span><br><span style="color: hsl(120, 100%, 40%);">+ * acceptable setup, while still ensuring will timeout at some point if</span><br><span style="color: hsl(120, 100%, 40%);">+ * something fails in the ramp down procedure.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ { .T=-1, .default_val=300, .desc="Time after which osmo-bts exits if regular ramp down during shut down process does not finish (s)" },</span><br><span> { .T=-2, .default_val=3, .desc="Time after which osmo-bts exits if requesting transceivers to stop during shut down process does not finish (s)" },</span><br><span> {}</span><br><span> };</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/18904">change 18904</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/18904"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I70e34dda8974ebd94aea33bd9fb1d99f9063cc55 </div>
<div style="display:none"> Gerrit-Change-Number: 18904 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>