<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980/2/bts/BTS_Tests.ttcn">File bts/BTS_Tests.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980/2/bts/BTS_Tests.ttcn@380">Patch Set #2, Line 380:</a> <code style="font-family:monospace,monospace">f_connhdlr_init_vty_bsc</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Hmm, a separate VTY connection for ConnHdlr is the easiest way, but maybe you can just re-map the port somehow, like we do for the TRXC port?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980/2/bts/BTS_Tests.ttcn@2037">Patch Set #2, Line 2037:</a> <code style="font-family:monospace,monospace">function</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please make it private, here or in a separate change.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980/2/bts/BTS_Tests.ttcn@2062">Patch Set #2, Line 2062:</a> <code style="font-family:monospace,monospace">f_verify_ramp_up</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here, it should be private.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980/2/bts/BTS_Tests.ttcn@2124">Patch Set #2, Line 2124:</a> <code style="font-family:monospace,monospace">function</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">private</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980/2/bts/BTS_Tests.ttcn@2191">Patch Set #2, Line 2191:</a> <code style="font-family:monospace,monospace">function</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">private</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980">change 18980</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I895d69394a0123ae32b336c9ffaff615ba657f12 </div>
<div style="display:none"> Gerrit-Change-Number: 18980 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 23 Jun 2020 20:55:16 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>