<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/18692">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc_a: add callref as call id to ASSIGNMENT REQ.<br><br>The BSSMAP message ASSIGNMENT REQUEST may contain an optional CALL<br>IDENTIFIER IE. While this IE is optional some BSC implementions may<br>require it.<br><br>Change-Id: I4288f47e4a6d61ec672f431723f6e72c7c6b0799<br>Related: OS#4582<br>---<br>M include/osmocom/msc/ran_msg.h<br>M src/libmsc/msc_a.c<br>M src/libmsc/ran_msg_a.c<br>3 files changed, 9 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/msc/ran_msg.h b/include/osmocom/msc/ran_msg.h</span><br><span>index 1b0e2e8..3b08b46 100644</span><br><span>--- a/include/osmocom/msc/ran_msg.h</span><br><span>+++ b/include/osmocom/msc/ran_msg.h</span><br><span>@@ -86,6 +86,8 @@</span><br><span>      enum nsap_addr_enc rab_assign_addr_enc;</span><br><span>      bool osmux_present;</span><br><span>  uint8_t osmux_cid;</span><br><span style="color: hsl(120, 100%, 40%);">+    bool call_id_present;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint32_t call_id;</span><br><span> };</span><br><span> </span><br><span> struct ran_cipher_mode_command {</span><br><span>diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c</span><br><span>index 4d856d0..3bfc0f8 100644</span><br><span>--- a/src/libmsc/msc_a.c</span><br><span>+++ b/src/libmsc/msc_a.c</span><br><span>@@ -541,6 +541,8 @@</span><br><span>                   .channel_type = &channel_type,</span><br><span>                   .osmux_present = msc_a->cc.call_leg->rtp[RTP_TO_RAN]->use_osmux,</span><br><span>                    .osmux_cid = msc_a->cc.call_leg->rtp[RTP_TO_RAN]->local_osmux_cid,</span><br><span style="color: hsl(120, 100%, 40%);">+                   .call_id_present = true,</span><br><span style="color: hsl(120, 100%, 40%);">+                      .call_id = cc_trans->callref,</span><br><span>             },</span><br><span>   };</span><br><span>   if (msc_a_ran_down(msc_a, MSC_ROLE_I, &msg)) {</span><br><span>diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c</span><br><span>index 28f99ce..e6dee52 100644</span><br><span>--- a/src/libmsc/ran_msg_a.c</span><br><span>+++ b/src/libmsc/ran_msg_a.c</span><br><span>@@ -959,6 +959,7 @@</span><br><span>        struct sockaddr_storage rtp_addr;</span><br><span>    struct sockaddr_storage *use_rtp_addr = NULL;</span><br><span>        struct msgb *msg;</span><br><span style="color: hsl(120, 100%, 40%);">+     const uint32_t *call_id = NULL;</span><br><span>      int rc;</span><br><span> </span><br><span>  if (!ac->channel_type) {</span><br><span>@@ -999,7 +1000,10 @@</span><br><span>          }</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   msg = gsm0808_create_ass(ac->channel_type, NULL, use_rtp_addr, use_scl, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+     if(ac->call_id_present == true)</span><br><span style="color: hsl(120, 100%, 40%);">+            call_id = &ac->call_id;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      msg = gsm0808_create_ass(ac->channel_type, NULL, use_rtp_addr, use_scl, call_id);</span><br><span>         if (ac->osmux_present)</span><br><span>            _gsm0808_assignment_extend_osmux(msg, ac->osmux_cid);</span><br><span>     return msg;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/18692">change 18692</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/18692"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4288f47e4a6d61ec672f431723f6e72c7c6b0799 </div>
<div style="display:none"> Gerrit-Change-Number: 18692 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>