<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18968">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts-trx: Mark 'osmotrx power' VTY cmd as deprecated<br><br>There's a standarized way through OML's Administrate State to control<br>the status of TRX, so let's use and maintain that one rather than this<br>ad-hoc hack.<br><br>Related: SYS#4920<br>Change-Id: Ia7f190063c35e0ed8e2e734047b3aff608cd3ce3<br>---<br>M src/osmo-bts-trx/trx_vty.c<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/68/18968/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c</span><br><span>index b3214ee..2e52958 100644</span><br><span>--- a/src/osmo-bts-trx/trx_vty.c</span><br><span>+++ b/src/osmo-bts-trx/trx_vty.c</span><br><span>@@ -296,7 +296,7 @@</span><br><span>    return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN(cfg_phyinst_power_on, cfg_phyinst_power_on_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_DEPRECATED(cfg_phyinst_power_on, cfg_phyinst_power_on_cmd,</span><br><span>  "osmotrx power (on|off)",</span><br><span>  OSMOTRX_STR</span><br><span>  "Change TRX state\n"</span><br><span>@@ -305,6 +305,10 @@</span><br><span>        struct phy_instance *pinst = vty->index;</span><br><span>  struct trx_l1h *l1h = pinst->u.osmotrx.hdl;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    vty_out (vty, "'osmotrx power' is deprecated, use OML's standard "</span><br><span style="color: hsl(120, 100%, 40%);">+                    "Administrative State instead to control each TRX "</span><br><span style="color: hsl(120, 100%, 40%);">+                 "('rf_locked' VTY cmd in osmo-bsc)%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>       if (strcmp(argv[0], "on"))</span><br><span>                 vty_out(vty, "OFF: %d%s", trx_if_cmd_poweroff(l1h, NULL), VTY_NEWLINE);</span><br><span>    else {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/18968">change 18968</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/18968"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia7f190063c35e0ed8e2e734047b3aff608cd3ce3 </div>
<div style="display:none"> Gerrit-Change-Number: 18968 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>