<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/18740">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST<br><br>When msc_ho_send_handover_request() generates the HANDOVER REQUEST<br>message, it does not populate the call_id struct member.<br><br>In ran_msg_a.c the struct member call_id is used, but the<br>call_id_present flag is not set, which also prevents the call_id being<br>added to the message<br><br>Change-Id: I6b1b55b3f5a3092d9557dc2512020c766a9ff744<br>Related: OS#4582<br>---<br>M src/libmsc/msc_ho.c<br>M src/libmsc/ran_msg_a.c<br>2 files changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msc_ho.c b/src/libmsc/msc_ho.c</span><br><span>index aa513eb..d89a24c 100644</span><br><span>--- a/src/libmsc/msc_ho.c</span><br><span>+++ b/src/libmsc/msc_ho.c</span><br><span>@@ -383,6 +383,7 @@</span><br><span>         struct vlr_subscr *vsub = msc_a_vsub(msc_a);</span><br><span>         struct gsm_network *net = msc_a_net(msc_a);</span><br><span>  struct gsm0808_channel_type channel_type;</span><br><span style="color: hsl(120, 100%, 40%);">+     struct gsm_trans *cc_trans = msc_a->cc.active_trans;</span><br><span>      struct ran_msg ran_enc_msg = {</span><br><span>               .msg_type = RAN_MSG_HANDOVER_REQUEST,</span><br><span>                .handover_request = {</span><br><span>@@ -402,6 +403,8 @@</span><br><span>                  /* Don't send AoIP Transport Layer Address for inter-MSC Handover */</span><br><span>                     .rtp_ran_local = (msc_a->ho.new_cell.type == MSC_NEIGHBOR_TYPE_LOCAL_RAN_PEER)</span><br><span>                            ? call_leg_local_ip(msc_a->cc.call_leg, RTP_TO_RAN) : NULL,</span><br><span style="color: hsl(120, 100%, 40%);">+                        .call_id_present = true,</span><br><span style="color: hsl(120, 100%, 40%);">+                      .call_id = cc_trans->callref,</span><br><span>             },</span><br><span>   };</span><br><span> </span><br><span>diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c</span><br><span>index e6dee52..ab58526 100644</span><br><span>--- a/src/libmsc/ran_msg_a.c</span><br><span>+++ b/src/libmsc/ran_msg_a.c</span><br><span>@@ -1121,6 +1121,7 @@</span><br><span> </span><br><span>              .imsi = n->imsi,</span><br><span>          .codec_list_msc_preferred = n->codec_list_msc_preferred,</span><br><span style="color: hsl(120, 100%, 40%);">+           .call_id_present = n->call_id_present,</span><br><span>            .call_id = n->call_id,</span><br><span>            .global_call_reference = n->global_call_reference,</span><br><span>                .global_call_reference_len = n->global_call_reference_len,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/18740">change 18740</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/18740"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6b1b55b3f5a3092d9557dc2512020c766a9ff744 </div>
<div style="display:none"> Gerrit-Change-Number: 18740 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>