<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18935">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[cosmetic] system_information: Values are not guesses; more comments<br><br>Change-Id: I978fbcd0c82658444b7603b082c236d23b0fa04b<br>---<br>M src/osmo-bsc/system_information.c<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c</span><br><span>index d5be3f2..de01112 100644</span><br><span>--- a/src/osmo-bsc/system_information.c</span><br><span>+++ b/src/osmo-bsc/system_information.c</span><br><span>@@ -1152,9 +1152,8 @@</span><br><span>            .ctrl_ack_type_use_block = true,</span><br><span>             .ext_info_present = 0,</span><br><span>               .ext_info = {</span><br><span style="color: hsl(0, 100%, 40%);">-                   /* The values below are just guesses ! */</span><br><span style="color: hsl(0, 100%, 40%);">-                       .egprs_supported = 0,</span><br><span style="color: hsl(0, 100%, 40%);">-                   .use_egprs_p_ch_req = 0,</span><br><span style="color: hsl(120, 100%, 40%);">+                      .egprs_supported = 0,           /* overridden in gsm_generate_si() */</span><br><span style="color: hsl(120, 100%, 40%);">+                 .use_egprs_p_ch_req = 0,        /* overridden in generate_si13() */</span><br><span>                  .bep_period = 5,</span><br><span>                     .pfc_supported = 0,</span><br><span>                  .dtm_supported = 0,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18935">change 18935</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18935"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I978fbcd0c82658444b7603b082c236d23b0fa04b </div>
<div style="display:none"> Gerrit-Change-Number: 18935 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>