<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18939">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Count RSL DELETE INDICATION received from BTS<br><br>If the BTS downlink CCCH (PCH + AGCH) queue is full, it sends<br>us an RSL DELETE INDICATION.  So far, osmo-bsc logs this as<br><br><0004> abis_rsl.c:2026 Unimplemented Abis RSL TRX message type 0x14<br><br>which is not very helpful.  Instead, make the log message more<br>descriptive and add a rate counter for monitoring.<br><br>Change-Id: I9bd2966db90e39ccca442d6bc9abc91e9a9147d4<br>Closes: OS#3190<br>---<br>M include/osmocom/bsc/gsm_data.h<br>M src/osmo-bsc/abis_rsl.c<br>2 files changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/39/18939/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index 9874706..8c1c545 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -1403,6 +1403,7 @@</span><br><span>  BTS_CTR_CHAN_ACT_NACK,</span><br><span>       BTS_CTR_RSL_UNKNOWN,</span><br><span>         BTS_CTR_RSL_IPA_NACK,</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS_CTR_RSL_DELETE_IND,</span><br><span>      BTS_CTR_MODE_MODIFY_NACK,</span><br><span>    BTS_CTR_LCHAN_BORKEN_FROM_UNUSED,</span><br><span>    BTS_CTR_LCHAN_BORKEN_FROM_WAIT_ACTIV_ACK,</span><br><span>@@ -1458,6 +1459,7 @@</span><br><span>    [BTS_CTR_CHAN_ACT_NACK] =               {"chan_act:nack", "Number of Channel Activations that the BTS NACKed"},</span><br><span>  [BTS_CTR_RSL_UNKNOWN] =                 {"rsl:unknown", "Number of unknown/unsupported RSL messages received from BTS"},</span><br><span>         [BTS_CTR_RSL_IPA_NACK] =                {"rsl:ipa_nack", "Number of IPA (RTP/dyn-PDCH) related NACKs received from BTS"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BTS_CTR_RSL_DELETE_IND] =              {"rsl:delete_ind", "Number of RSL DELETE INDICATION (DL CCCH overload)"},</span><br><span>        [BTS_CTR_MODE_MODIFY_NACK] =            {"chan:mode_modify_nack", "Number of Channel Mode Modify NACKs received from BTS"},</span><br><span> </span><br><span>  /* lchan/TS BORKEN state counters */</span><br><span>@@ -1489,6 +1491,7 @@</span><br><span>         [BTS_CTR_ASSIGNMENT_TIMEOUT] =               {"assignment:timeout", "Assignment timed out"},</span><br><span>     [BTS_CTR_ASSIGNMENT_FAILED] =                {"assignment:failed", "Received Assignment Failure message"},</span><br><span>       [BTS_CTR_ASSIGNMENT_ERROR] =                 {"assignment:error", "Assignment failed for other reason"},</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> };</span><br><span> </span><br><span> static const struct rate_ctr_group_desc bts_ctrg_desc = {</span><br><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index 2fb1a22..8376f98 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -1591,8 +1591,8 @@</span><br><span>               break;</span><br><span>       case RSL_MT_DELETE_IND:</span><br><span>              /* CCCH overloaded, IMM_ASSIGN was dropped */</span><br><span style="color: hsl(0, 100%, 40%);">-           LOGP(DRSL, LOGL_NOTICE, "Unimplemented Abis RSL CChan message "</span><br><span style="color: hsl(0, 100%, 40%);">-                       "type %s\n", rsl_msg_name(rslh->c.msg_type));</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGPLCHAN(msg->lchan, DRSL, LOGL_NOTICE, "DELETE INDICATION (Downlink CCCH overload)\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                rate_ctr_inc(&sign_link->trx->bts->bts_ctrs->ctr[BTS_CTR_RSL_DELETE_IND]);</span><br><span>           break;</span><br><span>       case RSL_MT_CBCH_LOAD_IND:</span><br><span>           /* current load on the CBCH */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18939">change 18939</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18939"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9bd2966db90e39ccca442d6bc9abc91e9a9147d4 </div>
<div style="display:none"> Gerrit-Change-Number: 18939 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>