<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/18877">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
neels: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Treat RAU as implicit RESUME if GMM is suspended<br><br>We so far only resumed from suspend upon receiving an explicit BSSGP<br>RESUME message from the BSS. The latter is only possible in<br>BSC-colocated PCU, where the BSC can trigger the message when releasing<br>the dedicated channel. In BTS-colocated PCUs, this is not possible,<br>and we have to rely on the MS resuming by RAU.<br><br>See 3GPP TS 23.060 section 16.2.1.1.1 clause 6:<br><br>The MS shall resume GPRS services by sending a Routeing Area Update Request message to the SGSN:<br>* if the BSS did not successfully request the SGSN to resume GPRS services,<br>* if the RR Channel Release message was not received before the MS left dedicated mode,<br>* if the MS locally determines that the conditions for the GPRS suspension have disappeared<br><br>Without this patch, the GMM state would forever be stuck in SUSPEND,<br>which in turn causes the SGSN to page the MS all the time.<br><br>Change-Id: I3c09187a27483d95fa0070bbb467f94a2ea3978f<br>Related: OS4616<br>---<br>M src/sgsn/gprs_gmm_fsm.c<br>1 file changed, 8 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sgsn/gprs_gmm_fsm.c b/src/sgsn/gprs_gmm_fsm.c</span><br><span>index 37ea904..11b4e4e 100644</span><br><span>--- a/src/sgsn/gprs_gmm_fsm.c</span><br><span>+++ b/src/sgsn/gprs_gmm_fsm.c</span><br><span>@@ -69,9 +69,12 @@</span><br><span> static void st_gmm_registered_suspended(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span> {</span><br><span> switch(event) {</span><br><span style="color: hsl(0, 100%, 40%);">- case E_GMM_RESUME:</span><br><span style="color: hsl(120, 100%, 40%);">+ case E_GMM_RESUME: /* explicit BSSGP RESUME from BSS */</span><br><span> gmm_fsm_state_chg(fi, ST_GMM_REGISTERED_NORMAL);</span><br><span> break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case E_GMM_COMMON_PROC_INIT_REQ: /* implicit resume from MS */</span><br><span style="color: hsl(120, 100%, 40%);">+ gmm_fsm_state_chg(fi, ST_GMM_COMMON_PROC_INIT);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span> }</span><br><span> }</span><br><span> </span><br><span>@@ -123,10 +126,12 @@</span><br><span> .action = st_gmm_registered_normal,</span><br><span> },</span><br><span> [ST_GMM_REGISTERED_SUSPENDED] = {</span><br><span style="color: hsl(0, 100%, 40%);">- .in_event_mask = X(E_GMM_RESUME),</span><br><span style="color: hsl(120, 100%, 40%);">+ .in_event_mask = X(E_GMM_RESUME) |</span><br><span style="color: hsl(120, 100%, 40%);">+ X(E_GMM_COMMON_PROC_INIT_REQ),</span><br><span> .out_state_mask =</span><br><span> X(ST_GMM_DEREGISTERED) |</span><br><span style="color: hsl(0, 100%, 40%);">- X(ST_GMM_REGISTERED_NORMAL),</span><br><span style="color: hsl(120, 100%, 40%);">+ X(ST_GMM_REGISTERED_NORMAL) |</span><br><span style="color: hsl(120, 100%, 40%);">+ X(ST_GMM_COMMON_PROC_INIT),</span><br><span> .name = "Registered.SUSPENDED",</span><br><span> .action = st_gmm_registered_suspended,</span><br><span> },</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/18877">change 18877</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/18877"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3c09187a27483d95fa0070bbb467f94a2ea3978f </div>
<div style="display:none"> Gerrit-Change-Number: 18877 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>