<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">RSL_Emulation: fix rx of tr_RSL_PAGING_CMD()<br><br>For tr_RSL_PAGING_CMD, also check comp_ref against null.<br><br>Upon receiving a tr_RSL_PAGING_CMD, the code tries to dispatch the Paging<br>Command to all valid clients. However, the ConnectionTable[*].comp_ref is<br>*always* present, and actually null for unconnected clients.<br>So, before this patch, a Paging Command from osmo-bsc gets sent to a null<br>client, which disconnects the RSL emulation and aborts the test.<br><br>There is currently no test using this, but the upcoming MSC pool tests will:<br>see I21cbab193cd0de2e5692665442eae113d5f61904.<br><br>Change-Id: Iaf7730153a3a19e448a33298c3e12212a55929d5<br>---<br>M library/RSL_Emulation.ttcn<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn</span><br><span>index bb11340..618cf11 100644</span><br><span>--- a/library/RSL_Emulation.ttcn</span><br><span>+++ b/library/RSL_Emulation.ttcn</span><br><span>@@ -548,7 +548,7 @@</span><br><span>            [bts_role] IPA_PT.receive(tr_ASP_RSL_UD(tr_RSL_PAGING_CMD(?, ?), sid := ?)) -> value rx_rsl {</span><br><span>                     /* broadcast to all clients? */</span><br><span>                      for (i := 0; i < sizeof(ConnectionTable); i := i + 1) {</span><br><span style="color: hsl(0, 100%, 40%);">-                              if (ispresent(ConnectionTable[i].comp_ref)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                         if (ispresent(ConnectionTable[i].comp_ref) and ConnectionTable[i].comp_ref != null) {</span><br><span>                                        CLIENT_PT.send(rx_rsl.rsl) to ConnectionTable[i].comp_ref;</span><br><span>                           }</span><br><span>                    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761">change 18761</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iaf7730153a3a19e448a33298c3e12212a55929d5 </div>
<div style="display:none"> Gerrit-Change-Number: 18761 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>