<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18835">View Change</a></p><div style="white-space:pre-wrap">Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
fixeria: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">A-bis/RSL: refactor handling of BS Power IE (power reduction)<br><br>According to 3GPP TS 08.58, section 9.3.4, BS Power IE indicates<br>the transmission power attenuation on a particular channel:<br><br> +--------------+---------+-----------------+<br> | Reserved (3) | FPC (1) | Power level (4) |<br> +--------------+---------+-----------------+<br><br>so let's change handling of this IE as follows:<br><br> - s/bs_power/bs_power_red/g, so it reflects 'reduction';<br> - store power attenuation value in dB, not in 2 db steps;<br> - get rid of ms_power_ctrl.bts_tx_pwr, it's always 0 anyway;<br> - fix rsl_tx_meas_res(): use lchan->bs_power_red;<br> - always check if FPC (Fast Power Control) flag is set;<br> - we don't support it, so reject messages containing it;<br> - fix rsl_rx_chan_activ(): properly apply the bitmask.<br><br>Change-Id: I16cc50dfca102030380a06e16c234d5f6698f38f<br>---<br>M include/osmo-bts/gsm_data_shared.h<br>M include/osmo-bts/tx_power.h<br>M src/common/rsl.c<br>M src/common/scheduler.c<br>M src/common/tx_power.c<br>M src/common/vty.c<br>M tests/tx_power/tx_power_test.c<br>7 files changed, 50 insertions(+), 43 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-bts/gsm_data_shared.h b/include/osmo-bts/gsm_data_shared.h</span><br><span>index 7cfbfeb..bbc1bd4 100644</span><br><span>--- a/include/osmo-bts/gsm_data_shared.h</span><br><span>+++ b/include/osmo-bts/gsm_data_shared.h</span><br><span>@@ -193,8 +193,6 @@</span><br><span> uint8_t flags;</span><br><span> /* RSL measurement result number, 0 at lchan_act */</span><br><span> uint8_t res_nr;</span><br><span style="color: hsl(0, 100%, 40%);">- /* current Tx power level of the BTS */</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t bts_tx_pwr;</span><br><span> /* number of measurements stored in array below */</span><br><span> uint8_t num_ul_meas;</span><br><span> struct bts_ul_meas uplink[MAX_NUM_UL_MEAS];</span><br><span>@@ -267,8 +265,9 @@</span><br><span> uint8_t max;</span><br><span> bool fixed;</span><br><span> } ms_power_ctrl;</span><br><span style="color: hsl(0, 100%, 40%);">- /* Power levels for BTS */</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t bs_power;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* BTS power reduction (in dB) */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t bs_power_red;</span><br><span> </span><br><span> struct msgb *pending_rel_ind_msg;</span><br><span> </span><br><span>diff --git a/include/osmo-bts/tx_power.h b/include/osmo-bts/tx_power.h</span><br><span>index 10129eb..8f33100 100644</span><br><span>--- a/include/osmo-bts/tx_power.h</span><br><span>+++ b/include/osmo-bts/tx_power.h</span><br><span>@@ -62,15 +62,15 @@</span><br><span> </span><br><span> int get_p_nominal_mdBm(struct gsm_bts_trx *trx);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int get_p_target_mdBm(struct gsm_bts_trx *trx, uint8_t bs_power_ie);</span><br><span style="color: hsl(120, 100%, 40%);">+int get_p_target_mdBm(struct gsm_bts_trx *trx, uint8_t bs_power_red);</span><br><span> int get_p_target_mdBm_lchan(struct gsm_lchan *lchan);</span><br><span> </span><br><span> int get_p_actual_mdBm(struct gsm_bts_trx *trx, int p_target_mdBm);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int get_p_trxout_target_mdBm(struct gsm_bts_trx *trx, uint8_t bs_power_ie);</span><br><span style="color: hsl(120, 100%, 40%);">+int get_p_trxout_target_mdBm(struct gsm_bts_trx *trx, uint8_t bs_power_red);</span><br><span> int get_p_trxout_target_mdBm_lchan(struct gsm_lchan *lchan);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int get_p_trxout_actual_mdBm(struct gsm_bts_trx *trx, uint8_t bs_power_ie);</span><br><span style="color: hsl(120, 100%, 40%);">+int get_p_trxout_actual_mdBm(struct gsm_bts_trx *trx, uint8_t bs_power_red);</span><br><span> int get_p_trxout_actual_mdBm_lchan(struct gsm_lchan *lchan);</span><br><span> </span><br><span> int power_ramp_start(struct gsm_bts_trx *trx, int p_total_tgt_mdBm, int bypass);</span><br><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index f057a89..b518245 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -60,6 +60,9 @@</span><br><span> </span><br><span> //#define FAKE_CIPH_MODE_COMPL</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Parse power attenuation (in dB) from BS Power IE (see 9.3.4) */</span><br><span style="color: hsl(120, 100%, 40%);">+#define BS_POWER2DB(bs_power) \</span><br><span style="color: hsl(120, 100%, 40%);">+ ((bs_power & 0x0f) * 2)</span><br><span> </span><br><span> static int rsl_tx_error_report(struct gsm_bts_trx *trx, uint8_t cause, const uint8_t *chan_nr,</span><br><span> const uint8_t *link_id, const struct msgb *orig_msg);</span><br><span>@@ -1001,7 +1004,7 @@</span><br><span> lchan->tch_mode = 0;</span><br><span> memset(&lchan->encr, 0, sizeof(lchan->encr));</span><br><span> memset(&lchan->ho, 0, sizeof(lchan->ho));</span><br><span style="color: hsl(0, 100%, 40%);">- lchan->bs_power = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->bs_power_red = 0;</span><br><span> memset(&lchan->ms_power_ctrl, 0, sizeof(lchan->ms_power_ctrl));</span><br><span> lchan->rqd_ta = 0;</span><br><span> copy_sacch_si_to_lchan(lchan);</span><br><span>@@ -1146,8 +1149,18 @@</span><br><span> }</span><br><span> </span><br><span> /* 9.3.4 BS Power */</span><br><span style="color: hsl(0, 100%, 40%);">- if (TLVP_PRES_LEN(&tp, RSL_IE_BS_POWER, 1))</span><br><span style="color: hsl(0, 100%, 40%);">- lchan->bs_power = *TLVP_VAL(&tp, RSL_IE_BS_POWER);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (TLVP_PRES_LEN(&tp, RSL_IE_BS_POWER, 1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (*TLVP_VAL(&tp, RSL_IE_BS_POWER) & (1 << 4)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPLCHAN(lchan, DRSL, LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Fast Power Control is not supported\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return rsl_tx_chan_act_nack(lchan, RSL_ERR_SERV_OPT_UNIMPL);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->bs_power_red = BS_POWER2DB(*TLVP_VAL(&tp, RSL_IE_BS_POWER));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPLCHAN(lchan, DRSL, LOGL_DEBUG, "BS Power attenuation %u dB\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->bs_power_red);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* 9.3.13 MS Power */</span><br><span> if (TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1)) {</span><br><span> lchan->ms_power_ctrl.max = *TLVP_VAL(&tp, RSL_IE_MS_POWER) & 0x1F;</span><br><span>@@ -1664,21 +1677,13 @@</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* See TS 48.058 Section 9.3.4 */</span><br><span style="color: hsl(0, 100%, 40%);">-static int bs_power_attenuation_dB(uint8_t bs_power)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- /* the lower nibble contains the number of 2dB steps that the BS power is reduced compared</span><br><span style="color: hsl(0, 100%, 40%);">- * to its nominal transmit power */</span><br><span style="color: hsl(0, 100%, 40%);">- return - ((bs_power & 0xF) *2);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* 8.4.16 BS POWER CONTROL */</span><br><span> static int rsl_rx_bs_pwr_ctrl(struct msgb *msg)</span><br><span> {</span><br><span> struct abis_rsl_dchan_hdr *dch = msgb_l2(msg);</span><br><span> struct gsm_lchan *lchan = msg->lchan;</span><br><span> struct tlv_parsed tp;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t new_bs_power;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t old_bs_power_red;</span><br><span> </span><br><span> rsl_tlv_parse(&tp, msgb_l3(msg), msgb_l3len(msg));</span><br><span> </span><br><span>@@ -1686,12 +1691,16 @@</span><br><span> if (!TLVP_PRES_LEN(&tp, RSL_IE_BS_POWER, 1))</span><br><span> return rsl_tx_error_report(msg->trx, RSL_ERR_MAND_IE_ERROR, &dch->chan_nr, NULL, msg);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- new_bs_power = *TLVP_VAL(&tp, RSL_IE_BS_POWER);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (*TLVP_VAL(&tp, RSL_IE_BS_POWER) & (1 << 4)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPLCHAN(lchan, DRSL, LOGL_NOTICE, "Fast Power Control is not supported\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return rsl_tx_error_report(msg->trx, RSL_ERR_SERV_OPT_UNIMPL, &dch->chan_nr, NULL, msg);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ old_bs_power_red = lchan->bs_power_red;</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->bs_power_red = BS_POWER2DB(*TLVP_VAL(&tp, RSL_IE_BS_POWER));</span><br><span> </span><br><span> LOGPLCHAN(lchan, DRSL, LOGL_INFO, "BS POWER CONTROL Attenuation %d -> %d dB\n",</span><br><span style="color: hsl(0, 100%, 40%);">- bs_power_attenuation_dB(lchan->bs_power), bs_power_attenuation_dB(new_bs_power));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- lchan->bs_power = new_bs_power;</span><br><span style="color: hsl(120, 100%, 40%);">+ old_bs_power_red, lchan->bs_power_red);</span><br><span> </span><br><span> /* 9.3.31 MS Power Parameters (O) */</span><br><span> if (TLVP_PRESENT(&tp, RSL_IE_BS_POWER_PARAM)) {</span><br><span>@@ -2896,7 +2905,7 @@</span><br><span> msgb_tlv_put(msg, RSL_IE_UPLINK_MEAS, ie_len, meas_res);</span><br><span> lchan->meas.flags &= ~LC_UL_M_F_RES_VALID;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_tv_put(msg, RSL_IE_BS_POWER, lchan->meas.bts_tx_pwr);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_tv_put(msg, RSL_IE_BS_POWER, lchan->bs_power_red / 2);</span><br><span> if (lchan->meas.flags & LC_UL_M_F_L1_VALID) {</span><br><span> msgb_tv_fixed_put(msg, RSL_IE_L1_INFO, 2, lchan->meas.l1_info);</span><br><span> lchan->meas.flags &= ~LC_UL_M_F_L1_VALID;</span><br><span>diff --git a/src/common/scheduler.c b/src/common/scheduler.c</span><br><span>index ac9085d..e55b3a4 100644</span><br><span>--- a/src/common/scheduler.c</span><br><span>+++ b/src/common/scheduler.c</span><br><span>@@ -1190,9 +1190,9 @@</span><br><span> if (func(l1t, chan, bid, br) != 0)</span><br><span> goto no_data;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* BS Power reduction (2 dB steps) per logical channel */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* BS Power reduction (in dB) per logical channel */</span><br><span> if (l1cs->lchan != NULL)</span><br><span style="color: hsl(0, 100%, 40%);">- br->att = l1cs->lchan->bs_power * 2;</span><br><span style="color: hsl(120, 100%, 40%);">+ br->att = l1cs->lchan->bs_power_red;</span><br><span> </span><br><span> /* encrypt */</span><br><span> if (br->burst_len && l1cs->dl_encr_algo) {</span><br><span>diff --git a/src/common/tx_power.c b/src/common/tx_power.c</span><br><span>index e418cec..db3121d 100644</span><br><span>--- a/src/common/tx_power.c</span><br><span>+++ b/src/common/tx_power.c</span><br><span>@@ -60,14 +60,14 @@</span><br><span> /* calculate the target total output power required, reduced by both</span><br><span> * OML and RSL, but ignoring the attenuation required for power ramping and</span><br><span> * thermal management */</span><br><span style="color: hsl(0, 100%, 40%);">-int get_p_target_mdBm(struct gsm_bts_trx *trx, uint8_t bs_power_ie)</span><br><span style="color: hsl(120, 100%, 40%);">+int get_p_target_mdBm(struct gsm_bts_trx *trx, uint8_t bs_power_red)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- /* Pn subtracted by RSL BS Power IE (in 2 dB steps) */</span><br><span style="color: hsl(0, 100%, 40%);">- return get_p_nominal_mdBm(trx) - to_mdB(bs_power_ie * 2);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Pn subtracted by RSL BS Power Recudtion (in 1 dB steps) */</span><br><span style="color: hsl(120, 100%, 40%);">+ return get_p_nominal_mdBm(trx) - to_mdB(bs_power_red);</span><br><span> }</span><br><span> int get_p_target_mdBm_lchan(struct gsm_lchan *lchan)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- return get_p_target_mdBm(lchan->ts->trx, lchan->bs_power);</span><br><span style="color: hsl(120, 100%, 40%);">+ return get_p_target_mdBm(lchan->ts->trx, lchan->bs_power_red);</span><br><span> }</span><br><span> </span><br><span> /* calculate the actual total output power required, taking into account the</span><br><span>@@ -113,14 +113,14 @@</span><br><span> </span><br><span> /* calculate target TRX output power required, ignoring the</span><br><span> * attenuations required for power ramping but not thermal management */</span><br><span style="color: hsl(0, 100%, 40%);">-int get_p_trxout_target_mdBm(struct gsm_bts_trx *trx, uint8_t bs_power_ie)</span><br><span style="color: hsl(120, 100%, 40%);">+int get_p_trxout_target_mdBm(struct gsm_bts_trx *trx, uint8_t bs_power_red)</span><br><span> {</span><br><span> struct trx_power_params *tpp = &trx->power_params;</span><br><span> int p_target_mdBm, user_pa_drvlvl_mdBm, pa_drvlvl_mdBm;</span><br><span> unsigned int arfcn = trx->arfcn;</span><br><span> </span><br><span> /* P_target subtracted by any bulk gain added by the user */</span><br><span style="color: hsl(0, 100%, 40%);">- p_target_mdBm = get_p_target_mdBm(trx, bs_power_ie) - tpp->user_gain_mdB;</span><br><span style="color: hsl(120, 100%, 40%);">+ p_target_mdBm = get_p_target_mdBm(trx, bs_power_red) - tpp->user_gain_mdB;</span><br><span> </span><br><span> /* determine input drive level required at input to user PA */</span><br><span> user_pa_drvlvl_mdBm = get_pa_drive_level_mdBm(&tpp->user_pa, p_target_mdBm, arfcn);</span><br><span>@@ -133,7 +133,7 @@</span><br><span> }</span><br><span> int get_p_trxout_target_mdBm_lchan(struct gsm_lchan *lchan)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- return get_p_trxout_target_mdBm(lchan->ts->trx, lchan->bs_power);</span><br><span style="color: hsl(120, 100%, 40%);">+ return get_p_trxout_target_mdBm(lchan->ts->trx, lchan->bs_power_red);</span><br><span> }</span><br><span> </span><br><span> </span><br><span>diff --git a/src/common/vty.c b/src/common/vty.c</span><br><span>index 3dfd387..6a1fd9c 100644</span><br><span>--- a/src/common/vty.c</span><br><span>+++ b/src/common/vty.c</span><br><span>@@ -1182,8 +1182,7 @@</span><br><span> lchan->state == LCHAN_S_BROKEN ? lchan->broken_reason : "",</span><br><span> VTY_NEWLINE);</span><br><span> vty_out(vty, " BS Power: %d dBm, MS Power: %u dBm%s",</span><br><span style="color: hsl(0, 100%, 40%);">- lchan->ts->trx->nominal_power - lchan->ts->trx->max_power_red</span><br><span style="color: hsl(0, 100%, 40%);">- - lchan->bs_power*2,</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->ts->trx->nominal_power - (lchan->ts->trx->max_power_red + lchan->bs_power_red),</span><br><span> ms_pwr_dbm(lchan->ts->trx->bts->band, lchan->ms_power_ctrl.max),</span><br><span> VTY_NEWLINE);</span><br><span> vty_out(vty, " Channel Mode / Codec: %s%s",</span><br><span>diff --git a/tests/tx_power/tx_power_test.c b/tests/tx_power/tx_power_test.c</span><br><span>index 9d38d83..aaa34ea 100644</span><br><span>--- a/tests/tx_power/tx_power_test.c</span><br><span>+++ b/tests/tx_power/tx_power_test.c</span><br><span>@@ -120,9 +120,9 @@</span><br><span> /* at max_power_red = 2, we expect 21dBm */</span><br><span> OSMO_ASSERT(get_p_nominal_mdBm(trx) == to_mdB(21));</span><br><span> /* at 1 step (of 2dB), we expect full 23-2-2=19 dBm */</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(get_p_target_mdBm(trx, 1) == to_mdB(19));</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(get_p_target_mdBm(trx, 2) == to_mdB(19));</span><br><span> /* at 2 steps (= 4dB), we expect 23-2-4=17*/</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(get_p_trxout_target_mdBm(trx, 2) == to_mdB(17));</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(get_p_trxout_target_mdBm(trx, 4) == to_mdB(17));</span><br><span> }</span><br><span> </span><br><span> static void test_sbts1020(struct gsm_bts_trx *trx)</span><br><span>@@ -138,9 +138,9 @@</span><br><span> /* at max_power_red = 2, we expect 31dBm */</span><br><span> OSMO_ASSERT(get_p_nominal_mdBm(trx) == to_mdB(31));</span><br><span> /* at 1 step (of 2dB), we expect full 33-2-2=29 dBm */</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(get_p_target_mdBm(trx, 1) == to_mdB(29));</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(get_p_target_mdBm(trx, 2) == to_mdB(29));</span><br><span> /* at 2 steps (= 4dB), we expect 33-2-4-10=17*/</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(get_p_trxout_target_mdBm(trx, 2) == to_mdB(17));</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(get_p_trxout_target_mdBm(trx, 4) == to_mdB(17));</span><br><span> }</span><br><span> </span><br><span> </span><br><span>@@ -157,9 +157,9 @@</span><br><span> /* at max_power_red = 2, we expect 38dBm */</span><br><span> OSMO_ASSERT(get_p_nominal_mdBm(trx) == to_mdB(38));</span><br><span> /* at 1 step (of 2dB), we expect full 40-2-2=36 dBm */</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(get_p_target_mdBm(trx, 1) == to_mdB(36));</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(get_p_target_mdBm(trx, 2) == to_mdB(36));</span><br><span> /* at 2 steps (= 4dB), we expect 40-2-4-17=17*/</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(get_p_trxout_target_mdBm(trx, 2) == to_mdB(17));</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(get_p_trxout_target_mdBm(trx, 4) == to_mdB(17));</span><br><span> }</span><br><span> </span><br><span> static void test_sbts2050(struct gsm_bts_trx *trx)</span><br><span>@@ -175,9 +175,9 @@</span><br><span> /* at max_power_red = 2, we expect 35dBm */</span><br><span> OSMO_ASSERT(get_p_nominal_mdBm(trx) == to_mdB(35));</span><br><span> /* at 1 step (of 2dB), we expect full 37-2-2=33 dBm */</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(get_p_target_mdBm(trx, 1) == to_mdB(33));</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(get_p_target_mdBm(trx, 2) == to_mdB(33));</span><br><span> /* at 2 steps (= 4dB), we expect 37-2-4=31dBm */</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(get_p_trxout_target_mdBm(trx, 2) == to_mdB(31));</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(get_p_trxout_target_mdBm(trx, 4) == to_mdB(31));</span><br><span> }</span><br><span> </span><br><span> int bts_model_change_power(struct gsm_bts_trx *trx, int p_trxout_mdBm)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/18835">change 18835</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/18835"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I16cc50dfca102030380a06e16c234d5f6698f38f </div>
<div style="display:none"> Gerrit-Change-Number: 18835 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>