<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18719">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis_rsl: Count successful channel requests<br><br>Ticket: SYS#4877<br>Change-Id: I5c51956569223e802f4789dc5ed1605d18f80aea<br>---<br>M include/osmocom/bsc/gsm_data.h<br>M src/osmo-bsc/abis_rsl.c<br>2 files changed, 9 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index 8dc4105..7e55089 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -1384,6 +1384,7 @@</span><br><span> </span><br><span> enum bts_counter_id {</span><br><span>  BTS_CTR_CHREQ_TOTAL,</span><br><span style="color: hsl(120, 100%, 40%);">+  BTS_CTR_CHREQ_SUCCESSFUL,</span><br><span>    BTS_CTR_CHREQ_NO_CHANNEL,</span><br><span>    BTS_CTR_CHAN_RF_FAIL,</span><br><span>        BTS_CTR_CHAN_RLL_ERR,</span><br><span>@@ -1430,6 +1431,7 @@</span><br><span> </span><br><span> static const struct rate_ctr_desc bts_ctr_description[] = {</span><br><span>     [BTS_CTR_CHREQ_TOTAL] =                 {"chreq:total", "Received channel requests"},</span><br><span style="color: hsl(120, 100%, 40%);">+     [BTS_CTR_CHREQ_SUCCESSFUL] =            {"chreq:successful", "Successful channel requests (immediate assign sent)"},</span><br><span>     [BTS_CTR_CHREQ_NO_CHANNEL] =            {"chreq:no_channel", "Sent to MS no channel available"},</span><br><span>         [BTS_CTR_CHAN_RF_FAIL] =                {"chan:rf_fail", "Received a RF failure indication from BTS"},</span><br><span>   [BTS_CTR_CHAN_RLL_ERR] =                {"chan:rll_err", "Received a RLL failure with T200 cause from BTS"},</span><br><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index 4a1d314..705e759 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -1428,6 +1428,7 @@</span><br><span> </span><br><span> int rsl_tx_imm_assignment(struct gsm_lchan *lchan)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+      int rc;</span><br><span>      struct gsm_bts *bts = lchan->ts->trx->bts;</span><br><span>  uint8_t buf[GSM_MACBLOCK_LEN];</span><br><span>       struct gsm48_imm_ass *ia = (struct gsm48_imm_ass *) buf;</span><br><span>@@ -1453,7 +1454,12 @@</span><br><span>    ia->l2_plen = GSM48_LEN2PLEN((sizeof(*ia)-1) + ia->mob_alloc_len);</span><br><span> </span><br><span>         /* send IMMEDIATE ASSIGN CMD on RSL to BTS (to send on CCCH to MS) */</span><br><span style="color: hsl(0, 100%, 40%);">-   return rsl_imm_assign_cmd(bts, sizeof(*ia)+ia->mob_alloc_len, (uint8_t *) ia);</span><br><span style="color: hsl(120, 100%, 40%);">+     rc = rsl_imm_assign_cmd(bts, sizeof(*ia)+ia->mob_alloc_len, (uint8_t *) ia);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     if (!rc)</span><br><span style="color: hsl(120, 100%, 40%);">+              rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_CHREQ_SUCCESSFUL]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      return rc;</span><br><span> }</span><br><span> </span><br><span> /* current load on the CCCH */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18719">change 18719</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18719"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5c51956569223e802f4789dc5ed1605d18f80aea </div>
<div style="display:none"> Gerrit-Change-Number: 18719 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>