<p>srs_andre <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18789">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">epc: refactor run_wait() method and rename to prepare_proc()<br><br>this refactor no longer enforces blocking operation of the process.<br>Instead it returns the process object to the caller who<br>can now run either proc.launch() for non-blocking operation<br>or proc.launch_sync() for blocking mode.<br><br>The non-block mode allos doing other stuff in the background,<br>for example controlling the rfemu while running a ping.<br><br>Change-Id: Ia6372e55a8829f722e40db537d9dfd63a94d1be9<br>---<br>M src/osmo_gsm_tester/obj/epc.py<br>M sysmocom/suites/4g/rrc_idle_mt_ping.py<br>2 files changed, 6 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/obj/epc.py b/src/osmo_gsm_tester/obj/epc.py</span><br><span>index dfeba74..6f056fc 100644</span><br><span>--- a/src/osmo_gsm_tester/obj/epc.py</span><br><span>+++ b/src/osmo_gsm_tester/obj/epc.py</span><br><span>@@ -76,13 +76,14 @@</span><br><span> </span><br><span>         return  epc_class(testenv, run_node)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    def run_wait(self, name, popen_args):</span><br><span style="color: hsl(0, 100%, 40%);">-        ''' Execute process on EPC node, useful for MT traffic '''</span><br><span style="color: hsl(120, 100%, 40%);">+    def prepare_process(self, name, popen_args):</span><br><span style="color: hsl(120, 100%, 40%);">+        ''' Prepare and return a process to run on EPC node.</span><br><span style="color: hsl(120, 100%, 40%);">+            Caller calls either launch() or launch_sync()</span><br><span style="color: hsl(120, 100%, 40%);">+            for non-blocking or blocking operation respectively '''</span><br><span>         if self._run_node.is_local():</span><br><span>             proc = process.Process(name, self.run_dir, popen_args)</span><br><span>         else:</span><br><span>             proc = self.rem_host.RemoteProcess(name, popen_args)</span><br><span style="color: hsl(0, 100%, 40%);">-        proc.launch_sync()</span><br><span>         return proc</span><br><span> </span><br><span> ###################</span><br><span>diff --git a/sysmocom/suites/4g/rrc_idle_mt_ping.py b/sysmocom/suites/4g/rrc_idle_mt_ping.py</span><br><span>index fb3c32c..dcabe21 100755</span><br><span>--- a/sysmocom/suites/4g/rrc_idle_mt_ping.py</span><br><span>+++ b/sysmocom/suites/4g/rrc_idle_mt_ping.py</span><br><span>@@ -27,7 +27,8 @@</span><br><span> sleep(5)</span><br><span> </span><br><span> # Generate MO traffic, send single ping</span><br><span style="color: hsl(0, 100%, 40%);">-proc = epc.run_wait('ping', ('ping', '-c', '1', ue.get_assigned_addr()))</span><br><span style="color: hsl(120, 100%, 40%);">+proc = epc.prepare_process('ping', ('ping', '-c', '1', ue.get_assigned_addr()))</span><br><span style="color: hsl(120, 100%, 40%);">+proc.launch_sync()</span><br><span> output = proc.get_stdout()</span><br><span> </span><br><span> # Check paging received</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18789">change 18789</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18789"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia6372e55a8829f722e40db537d9dfd63a94d1be9 </div>
<div style="display:none"> Gerrit-Change-Number: 18789 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: srs_andre <andre@softwareradiosystems.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: srs_andre <andre@softwareradiosystems.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>