<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18824">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">testenv: Prepend underscor to internal method<br><br>Change-Id: I2297f4b44d6f0c88409ab6982de4e3640a6a48b2<br>---<br>M src/osmo_gsm_tester/testenv.py<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/testenv.py b/src/osmo_gsm_tester/testenv.py</span><br><span>index 77d844a..ea71df9 100644</span><br><span>--- a/src/osmo_gsm_tester/testenv.py</span><br><span>+++ b/src/osmo_gsm_tester/testenv.py</span><br><span>@@ -56,7 +56,7 @@</span><br><span>         self.objects_to_clean_up = None</span><br><span>         MainLoop.register_poll_func(self.poll)</span><br><span>         if self._test.timeout is not None: # aimed at firing once</span><br><span style="color: hsl(0, 100%, 40%);">-            MainLoop.register_poll_func(self.timeout_expired, timestep=self._test.timeout)</span><br><span style="color: hsl(120, 100%, 40%);">+            MainLoop.register_poll_func(self._timeout_expired, timestep=self._test.timeout)</span><br><span> </span><br><span>     def test(self):</span><br><span>         return self._test</span><br><span>@@ -122,9 +122,9 @@</span><br><span>             except Exception:</span><br><span>                 log_module.log_exn()</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    def timeout_expired(self):</span><br><span style="color: hsl(120, 100%, 40%);">+    def _timeout_expired(self):</span><br><span>         # Avoid timeout being called several times:</span><br><span style="color: hsl(0, 100%, 40%);">-        MainLoop.unregister_poll_func(self.timeout_expired)</span><br><span style="color: hsl(120, 100%, 40%);">+        MainLoop.unregister_poll_func(self._timeout_expired)</span><br><span>         raise log_module.Error('Test Timeout triggered: %d seconds elapsed' % self._test.elapsed_time())</span><br><span> </span><br><span>     def poll(self):</span><br><span>@@ -146,7 +146,7 @@</span><br><span>         self.objects_cleanup()</span><br><span>         self.suite_run.reserved_resources.put_all()</span><br><span>         MainLoop.unregister_poll_func(self.poll)</span><br><span style="color: hsl(0, 100%, 40%);">-        MainLoop.unregister_poll_func(self.timeout_expired)</span><br><span style="color: hsl(120, 100%, 40%);">+        MainLoop.unregister_poll_func(self._timeout_expired)</span><br><span>         self.test_import_modules_cleanup()</span><br><span>         self.set_overlay_template_dir(None)</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18824">change 18824</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18824"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2297f4b44d6f0c88409ab6982de4e3640a6a48b2 </div>
<div style="display:none"> Gerrit-Change-Number: 18824 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>