<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18732">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis.c: Grab reference to e1inp_line_get if already created<br><br>Since we are returning the pointer, it should always be grabbing a<br>reference (find doesn't do it).<br>In practice it's not much important since it is always created and not<br>found.<br><br>Change-Id: Ib84636663be2df33d497131c780b010b57f17e32<br>---<br>M src/common/abis.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/abis.c b/src/common/abis.c</span><br><span>index 44b8eff..ab32870 100644</span><br><span>--- a/src/common/abis.c</span><br><span>+++ b/src/common/abis.c</span><br><span>@@ -280,8 +280,10 @@</span><br><span>       bts_dev_info.location2 = model_name;</span><br><span> </span><br><span>     line = e1inp_line_find(0);</span><br><span style="color: hsl(0, 100%, 40%);">-      if (!line)</span><br><span style="color: hsl(0, 100%, 40%);">-              line = e1inp_line_create(0, "ipa");</span><br><span style="color: hsl(120, 100%, 40%);">+ if (line)</span><br><span style="color: hsl(120, 100%, 40%);">+             e1inp_line_get(line); /* We want a new reference for returned line */</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+          line = e1inp_line_create(0, "ipa"); /* already comes with a reference */</span><br><span>   if (!line)</span><br><span>           return NULL;</span><br><span>         e1inp_line_bind_ops(line, &line_ops);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/18732">change 18732</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/18732"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib84636663be2df33d497131c780b010b57f17e32 </div>
<div style="display:none"> Gerrit-Change-Number: 18732 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>