<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/16394">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Add "no traffic-mode" configuration to AS<br><br>As per RFC4666 it is optional whether or not a traffic-mode IE is<br>part of ASPAC requests from ASP to SG. We implemented that so far<br>by having none as default, unless the user specified an explicit<br>traffic-mode in the VTY. However, we had no command to remove that<br>explicit configuration and return to the implicit one.<br><br>Change-Id: Ibe2b298dd76dc4b02521dc411ae9d570eaf5a9a2<br>---<br>M src/osmo_ss7_vty.c<br>M tests/vty/ss7_asp_test.vty<br>2 files changed, 15 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c</span><br><span>index 9a2f8bb..9c31c00 100644</span><br><span>--- a/src/osmo_ss7_vty.c</span><br><span>+++ b/src/osmo_ss7_vty.c</span><br><span>@@ -878,6 +878,17 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(as_no_traf_mode, as_no_traf_mode_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "no traffic-mode",</span><br><span style="color: hsl(120, 100%, 40%);">+ NO_STR "Remove explicit traffic mode of operation of this AS\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct osmo_ss7_as *as = vty->index;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ as->cfg.mode = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ as->cfg.mode_set_by_vty = false;</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN(as_recov_tout, as_recov_tout_cmd,</span><br><span> "recovery-timeout <1-2000>",</span><br><span> "Specifies the recovery timeout value in milliseconds\n"</span><br><span>@@ -1931,6 +1942,7 @@</span><br><span> install_element(L_CS7_AS_NODE, &as_asp_cmd);</span><br><span> install_element(L_CS7_AS_NODE, &as_no_asp_cmd);</span><br><span> install_element(L_CS7_AS_NODE, &as_traf_mode_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(L_CS7_AS_NODE, &as_no_traf_mode_cmd);</span><br><span> install_element(L_CS7_AS_NODE, &as_recov_tout_cmd);</span><br><span> install_element(L_CS7_AS_NODE, &as_qos_class_cmd);</span><br><span> install_element(L_CS7_AS_NODE, &as_rout_key_cmd);</span><br><span>diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty</span><br><span>index 9bafb02..7411b1f 100644</span><br><span>--- a/tests/vty/ss7_asp_test.vty</span><br><span>+++ b/tests/vty/ss7_asp_test.vty</span><br><span>@@ -250,6 +250,7 @@</span><br><span> asp NAME</span><br><span> no asp NAME</span><br><span> traffic-mode (broadcast | loadshare | roundrobin | override)</span><br><span style="color: hsl(120, 100%, 40%);">+ no traffic-mode</span><br><span> recovery-timeout <1-2000></span><br><span> qos-class <0-255></span><br><span> routing-key RCONTEXT DPC</span><br><span>@@ -271,7 +272,8 @@</span><br><span> point-code Point Code Specific Features</span><br><span> </span><br><span> ss7_asp_vty_test(config-cs7-as)# no ?</span><br><span style="color: hsl(0, 100%, 40%);">- asp Specify ASP to be removed from this AS</span><br><span style="color: hsl(120, 100%, 40%);">+ asp Specify ASP to be removed from this AS</span><br><span style="color: hsl(120, 100%, 40%);">+ traffic-mode Remove explicit traffic mode of operation of this AS</span><br><span> </span><br><span> ss7_asp_vty_test(config-cs7-as)# do show cs7 instance 0 as all</span><br><span> Routing Routing Key Cic Cic Traffic</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/16394">change 16394</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/16394"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibe2b298dd76dc4b02521dc411ae9d570eaf5a9a2 </div>
<div style="display:none"> Gerrit-Change-Number: 16394 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>