<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/18795">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_bcd2str: also validate start_nibble parameter<br><br>If start_nibble were passed negative, we'd end up accessing invalid memory.<br>Safeguard against that.<br><br>Change-Id: Ied3c1e02c3a01d868e08195cbd8dfa52d2c19ac3<br>---<br>M src/utils.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/utils.c b/src/utils.c</span><br><span>index 038288c..18e105f 100644</span><br><span>--- a/src/utils.c</span><br><span>+++ b/src/utils.c</span><br><span>@@ -154,7 +154,7 @@</span><br><span>    int nibble_i;</span><br><span>        int rc = 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (!dst || dst_size < 1)</span><br><span style="color: hsl(120, 100%, 40%);">+  if (!dst || dst_size < 1 || start_nibble < 0)</span><br><span>          return -ENOMEM;</span><br><span> </span><br><span>  for (nibble_i = start_nibble; nibble_i < end_nibble && dst < dst_end; nibble_i++, dst++) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/18795">change 18795</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/18795"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ied3c1e02c3a01d868e08195cbd8dfa52d2c19ac3 </div>
<div style="display:none"> Gerrit-Change-Number: 18795 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>