<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18778">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MSC pooling: add 'no allow-attach' for MSC off-loading<br><br>As in 3GPP TS 23.236, to offload an MSC, the BSC must be able to avoid<br>attaching new subscribers to it:<br><br>4.5a.1: "UEs being moved from one CN node are stopped from registering to the<br>same CN node again by an O&M command in BSCs and RNCs connected to the pool."<br><br>Change-Id: I6249201c15d0f6565aca643c21d2375c9ca58584<br>---<br>M include/osmocom/bsc/bsc_msc_data.h<br>M src/osmo-bsc/gsm_08_08.c<br>M src/osmo-bsc/osmo_bsc_msc.c<br>M src/osmo-bsc/osmo_bsc_vty.c<br>M tests/nri_cfg.vty<br>5 files changed, 48 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/18778/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/bsc_msc_data.h b/include/osmocom/bsc/bsc_msc_data.h</span><br><span>index 3df2774..fc6c2d6 100644</span><br><span>--- a/include/osmocom/bsc/bsc_msc_data.h</span><br><span>+++ b/include/osmocom/bsc/bsc_msc_data.h</span><br><span>@@ -181,6 +181,7 @@</span><br><span> } mgcp_ipa;</span><br><span> </span><br><span> struct osmo_nri_ranges *nri_ranges;</span><br><span style="color: hsl(120, 100%, 40%);">+ bool allow_attach;</span><br><span> };</span><br><span> </span><br><span> int osmo_bsc_msc_init(struct bsc_msc_data *msc);</span><br><span>diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c</span><br><span>index 0707c65..0064b41 100644</span><br><span>--- a/src/osmo-bsc/gsm_08_08.c</span><br><span>+++ b/src/osmo-bsc/gsm_08_08.c</span><br><span>@@ -231,7 +231,11 @@</span><br><span> </span><br><span> /* Figure out the next round-robin MSC. The MSCs may appear unsorted in net->mscs. Make sure to linearly</span><br><span> * round robin the MSCs by number: pick the lowest msc->nr >= round_robin_next_nr, and also remember the</span><br><span style="color: hsl(0, 100%, 40%);">- * lowest available msc->nr to wrap back to that in case no next MSC is left. */</span><br><span style="color: hsl(120, 100%, 40%);">+ * lowest available msc->nr to wrap back to that in case no next MSC is left.</span><br><span style="color: hsl(120, 100%, 40%);">+ * MSCs configured with `no allow-attach` do not accept new subscribers and hence must not be picked by</span><br><span style="color: hsl(120, 100%, 40%);">+ * round-robin. */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!msc->allow_attach)</span><br><span style="color: hsl(120, 100%, 40%);">+ continue;</span><br><span> if (!msc_round_robin_first || msc->nr < msc_round_robin_first->nr)</span><br><span> msc_round_robin_first = msc;</span><br><span> if (msc->nr >= round_robin_next_nr</span><br><span>diff --git a/src/osmo-bsc/osmo_bsc_msc.c b/src/osmo-bsc/osmo_bsc_msc.c</span><br><span>index ce07518..157808e 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_msc.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_msc.c</span><br><span>@@ -230,6 +230,7 @@</span><br><span> msc_data->mgcp_ipa.local_port = 0; /* dynamic */</span><br><span> </span><br><span> msc_data->nri_ranges = osmo_nri_ranges_alloc(msc_data);</span><br><span style="color: hsl(120, 100%, 40%);">+ msc_data->allow_attach = true;</span><br><span> </span><br><span> return msc_data;</span><br><span> }</span><br><span>diff --git a/src/osmo-bsc/osmo_bsc_vty.c b/src/osmo-bsc/osmo_bsc_vty.c</span><br><span>index 7db7c94..dbdd807 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_vty.c</span><br><span>@@ -177,6 +177,9 @@</span><br><span> }</span><br><span> </span><br><span> msc_write_nri(vty, msc, false);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!msc->allow_attach)</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " no allow-attach%s", VTY_NEWLINE);</span><br><span> }</span><br><span> </span><br><span> static int config_write_msc(struct vty *vty)</span><br><span>@@ -861,6 +864,28 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_msc_allow_attach, cfg_msc_allow_attach_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "allow-attach",</span><br><span style="color: hsl(120, 100%, 40%);">+ "Allow this MSC to attach new subscribers (default).\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct bsc_msc_data *msc = bsc_msc_data(vty);</span><br><span style="color: hsl(120, 100%, 40%);">+ msc->allow_attach = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_msc_no_allow_attach, cfg_msc_no_allow_attach_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "no allow-attach",</span><br><span style="color: hsl(120, 100%, 40%);">+ NO_STR</span><br><span style="color: hsl(120, 100%, 40%);">+ "Do not assign new subscribers to this MSC."</span><br><span style="color: hsl(120, 100%, 40%);">+ " Useful if an MSC in an MSC pool is configured to off-load subscribers."</span><br><span style="color: hsl(120, 100%, 40%);">+ " The MSC will still be operational for already attached subscribers,"</span><br><span style="color: hsl(120, 100%, 40%);">+ " but the NAS node selection function will skip this MSC for new subscribers\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct bsc_msc_data *msc = bsc_msc_data(vty);</span><br><span style="color: hsl(120, 100%, 40%);">+ msc->allow_attach = false;</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void msc_write_nri(struct vty *vty, struct bsc_msc_data *msc, bool verbose)</span><br><span> {</span><br><span> struct osmo_nri_range *r;</span><br><span>@@ -964,6 +989,8 @@</span><br><span> install_element(MSC_NODE, &cfg_msc_nri_add_cmd);</span><br><span> install_element(MSC_NODE, &cfg_msc_nri_del_cmd);</span><br><span> install_element(MSC_NODE, &cfg_msc_show_nri_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(MSC_NODE, &cfg_msc_allow_attach_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(MSC_NODE, &cfg_msc_no_allow_attach_cmd);</span><br><span> </span><br><span> /* Deprecated: ping time config, kept to support legacy config files. */</span><br><span> install_element(MSC_NODE, &cfg_net_msc_no_ping_time_cmd);</span><br><span>diff --git a/tests/nri_cfg.vty b/tests/nri_cfg.vty</span><br><span>index 2b38ec4..3ab7bf2 100644</span><br><span>--- a/tests/nri_cfg.vty</span><br><span>+++ b/tests/nri_cfg.vty</span><br><span>@@ -159,3 +159,17 @@</span><br><span> OsmoBSC(config-msc)# show nri</span><br><span> msc 0</span><br><span> nri add 0 1000</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-msc)# show running-config</span><br><span style="color: hsl(120, 100%, 40%);">+... ! no allow-attach</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-msc)# no allow-attach</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-msc)# show running-config</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+msc 0</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+ nri add 0 1000</span><br><span style="color: hsl(120, 100%, 40%);">+ no allow-attach</span><br><span style="color: hsl(120, 100%, 40%);">+... ! no allow-attach</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-msc)# allow-attach</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-msc)# show running-config</span><br><span style="color: hsl(120, 100%, 40%);">+... ! no allow-attach</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18778">change 18778</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18778"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6249201c15d0f6565aca643c21d2375c9ca58584 </div>
<div style="display:none"> Gerrit-Change-Number: 18778 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>