<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/18730">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">e1_input: refcount inc line during e1_sign_link_create, not during line update<br><br>Increase reference count when a new sign_link using the line is created.<br>Otherwise the line is freed too quickly during e1inp_sign_link_destroy()<br>with several TRX being used, since each RSL link is missing a reference.<br><br>That extra refcoutny in update() is not really needed given that we already<br>have a link assigned on the line when we call update.<br><br>Fixes: OS#3612<br>Fixes: OS#4094<br><br>Change-Id: I74405b0e87a89c17d58e87024f4aedbd30832013<br>---<br>M src/e1_input.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/30/18730/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/e1_input.c b/src/e1_input.c</span><br><span>index 3ab33b8..38fa478 100644</span><br><span>--- a/src/e1_input.c</span><br><span>+++ b/src/e1_input.c</span><br><span>@@ -578,6 +578,8 @@</span><br><span>  link->tei = tei;</span><br><span>  link->sapi = sapi;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+     e1inp_line_get(link->ts->line);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      llist_add_tail(&link->list, &ts->sign.sign_links);</span><br><span> </span><br><span>         return link;</span><br><span>@@ -847,8 +849,6 @@</span><br><span>   struct input_signal_data isd;</span><br><span>        int i, rc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  e1inp_line_get(line);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>        if (line->driver && line->ops && line->driver->line_update) {</span><br><span>            rc = line->driver->line_update(line);</span><br><span>  } else</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/18730">change 18730</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/18730"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I74405b0e87a89c17d58e87024f4aedbd30832013 </div>
<div style="display:none"> Gerrit-Change-Number: 18730 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>