<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18004">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Ensure we include lchan name in all LAPDm log lines<br><br>This makes use of the newly-introduced lapdm_channel_init3() API,<br>which provides the user (BTS in this case) to provide a human-readable<br>string identifier for each LAPDm channel.  This identifier is<br>subsequently used in all related log lines to provide context.<br><br>This means we will now get context information about which specific<br>SAPI in which sub-channel (ACCH/DCCH) on which lchan/ts/trx/bts a given<br>message originated from.<br><br>Example:<br>DLLAPD <0011> lapd_core.c:829 ((bts=0,trx=0,ts=0,ss=0)[DCCH][0]) SABM(E) received in state LAPD_STATE_IDLE<br><br>Change-Id: I17e3d4797ec71e31d0775330ae36d2e1fd70423f<br>Depends: libosmocore.git Ie6742843fff809edffcac24c4dce4edf66bc71be<br>Related: OS#1938<br>---<br>A TODO-RELEASE<br>M src/common/bts.c<br>2 files changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/TODO-RELEASE b/TODO-RELEASE</span><br><span>new file mode 100644</span><br><span>index 0000000..1dd5e79</span><br><span>--- /dev/null</span><br><span>+++ b/TODO-RELEASE</span><br><span>@@ -0,0 +1 @@</span><br><span style="color: hsl(120, 100%, 40%);">+* update libosmocore dependency to > 1.3.x for lapdm_channel_init3()</span><br><span>diff --git a/src/common/bts.c b/src/common/bts.c</span><br><span>index 2200615..9710a2c 100644</span><br><span>--- a/src/common/bts.c</span><br><span>+++ b/src/common/bts.c</span><br><span>@@ -429,7 +429,8 @@</span><br><span>                           "Setting T200 D0=%u, D3=%u, S0=%u, S3=%u (all in ms)\n",</span><br><span>                           t200_ms_dcch[DL_SAPI0], t200_ms_dcch[DL_SAPI3],</span><br><span>                      t200_ms_acch[DL_SAPI0], t200_ms_acch[DL_SAPI3]);</span><br><span style="color: hsl(0, 100%, 40%);">-              lapdm_channel_init2(lc, LAPDM_MODE_BTS, t200_ms_dcch, t200_ms_acch, lchan->type);</span><br><span style="color: hsl(120, 100%, 40%);">+          lapdm_channel_init3(lc, LAPDM_MODE_BTS, t200_ms_dcch, t200_ms_acch, lchan->type,</span><br><span style="color: hsl(120, 100%, 40%);">+                               gsm_lchan_name(lchan));</span><br><span>          lapdm_channel_set_flags(lc, LAPDM_ENT_F_POLLING_ONLY);</span><br><span>               lapdm_channel_set_l1(lc, NULL, lchan);</span><br><span>       }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/18004">change 18004</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/18004"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I17e3d4797ec71e31d0775330ae36d2e1fd70423f </div>
<div style="display:none"> Gerrit-Change-Number: 18004 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>