<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/18733">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Fix memory leak when SNDCP de-fragmentation is used<br><br>As msgb ownership is not passed along, we need to free the message<br>buffer memory we allocate in defrag_segments() after calling<br>sgsn_rx_sndcp_ud_ind().<br><br>Change-Id: I1185b1aa99bb167d616eb469e5445e4ed5ad949d<br>Closes: OS#4603<br>---<br>M src/sgsn/gprs_sndcp.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sgsn/gprs_sndcp.c b/src/sgsn/gprs_sndcp.c</span><br><span>index 01be57e..7ce6960 100644</span><br><span>--- a/src/sgsn/gprs_sndcp.c</span><br><span>+++ b/src/sgsn/gprs_sndcp.c</span><br><span>@@ -366,6 +366,10 @@</span><br><span>    rc = sgsn_rx_sndcp_ud_ind(&sne->ra_id, sne->lle->llme->tlli,</span><br><span>                                   sne->nsapi, msg, npdu_len, expnd);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   /* we must free the memory we allocated above; ownership is not transferred</span><br><span style="color: hsl(120, 100%, 40%);">+    * downwards in the call above */</span><br><span style="color: hsl(120, 100%, 40%);">+     msgb_free(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    if (any_pcomp_or_dcomp_active(sgsn))</span><br><span>                 talloc_free(expnd);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/18733">change 18733</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/18733"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1185b1aa99bb167d616eb469e5445e4ed5ad949d </div>
<div style="display:none"> Gerrit-Change-Number: 18733 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>