<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18648">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
fixeria: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm0408_test.c: drop test_mi_functionality()<br><br>Testing these functions is actually done in libosmocore. Also, with new<br>osmo_mobile_identity API, the functions being tested are marked deprecated. So<br>drop the test.<br><br>BTW, the test contained an IMSI of 16 digits, which is too long, yet was<br>expected to succeed. GSM23003_IMSI_MAX_DIGITS == 15. I first considered fixing<br>the test data, but the test is in the wrong place here anyway.<br><br>Change-Id: I902d31ecd72d71892fad7945f695a9f1fb403bf2<br>---<br>M tests/gsm0408/gsm0408_test.c<br>M tests/gsm0408/gsm0408_test.ok<br>2 files changed, 0 insertions(+), 33 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c</span><br><span>index f850274..5ff9491 100644</span><br><span>--- a/tests/gsm0408/gsm0408_test.c</span><br><span>+++ b/tests/gsm0408/gsm0408_test.c</span><br><span>@@ -269,34 +269,6 @@</span><br><span> bts_del(bts);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void test_mi_functionality(void)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- const char *imsi_odd = "987654321098763";</span><br><span style="color: hsl(0, 100%, 40%);">- const char *imsi_even = "9876543210987654";</span><br><span style="color: hsl(0, 100%, 40%);">- const uint32_t tmsi = 0xfabeacd0;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t mi[128];</span><br><span style="color: hsl(0, 100%, 40%);">- unsigned int mi_len;</span><br><span style="color: hsl(0, 100%, 40%);">- char mi_parsed[GSM48_MI_SIZE];</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- printf("Testing parsing and generating TMSI/IMSI\n");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* tmsi code */</span><br><span style="color: hsl(0, 100%, 40%);">- mi_len = gsm48_generate_mid_from_tmsi(mi, tmsi);</span><br><span style="color: hsl(0, 100%, 40%);">- gsm48_mi_to_string(mi_parsed, sizeof(mi_parsed), mi + 2, mi_len - 2);</span><br><span style="color: hsl(0, 100%, 40%);">- COMPARE((uint32_t)strtoul(mi_parsed, NULL, 10), ==, tmsi);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* imsi code */</span><br><span style="color: hsl(0, 100%, 40%);">- mi_len = gsm48_generate_mid_from_imsi(mi, imsi_odd);</span><br><span style="color: hsl(0, 100%, 40%);">- gsm48_mi_to_string(mi_parsed, sizeof(mi_parsed), mi + 2, mi_len -2);</span><br><span style="color: hsl(0, 100%, 40%);">- printf("hex: %s\n", osmo_hexdump(mi, mi_len));</span><br><span style="color: hsl(0, 100%, 40%);">- COMPARE_STR(mi_parsed, imsi_odd);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- mi_len = gsm48_generate_mid_from_imsi(mi, imsi_even);</span><br><span style="color: hsl(0, 100%, 40%);">- gsm48_mi_to_string(mi_parsed, sizeof(mi_parsed), mi + 2, mi_len -2);</span><br><span style="color: hsl(0, 100%, 40%);">- printf("hex: %s\n", osmo_hexdump(mi, mi_len));</span><br><span style="color: hsl(0, 100%, 40%);">- COMPARE_STR(mi_parsed, imsi_even);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> struct {</span><br><span> int range;</span><br><span> int arfcns_num;</span><br><span>@@ -924,8 +896,6 @@</span><br><span> return EXIT_FAILURE;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- test_mi_functionality();</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> test_si_range_helpers();</span><br><span> test_arfcn_filter();</span><br><span> test_print_encoding();</span><br><span>diff --git a/tests/gsm0408/gsm0408_test.ok b/tests/gsm0408/gsm0408_test.ok</span><br><span>index e3290b5..bad8aef 100644</span><br><span>--- a/tests/gsm0408/gsm0408_test.ok</span><br><span>+++ b/tests/gsm0408/gsm0408_test.ok</span><br><span>@@ -1,6 +1,3 @@</span><br><span style="color: hsl(0, 100%, 40%);">-Testing parsing and generating TMSI/IMSI</span><br><span style="color: hsl(0, 100%, 40%);">-hex: 17 08 99 78 56 34 12 90 78 36 </span><br><span style="color: hsl(0, 100%, 40%);">-hex: 17 09 91 78 56 34 12 90 78 56 f4 </span><br><span> Element is: 2 => freqs[i] = 121</span><br><span> Element is: 2 => freqs[i] = 1</span><br><span> Element is: 0 => freqs[i] = 68</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18648">change 18648</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18648"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I902d31ecd72d71892fad7945f695a9f1fb403bf2 </div>
<div style="display:none"> Gerrit-Change-Number: 18648 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>