<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18699">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">common/scheduler: fix unreachable code in trx_sched_set_lchan()<br><br>Change-Id: Ie9d8f8ca86195be4408db717cd3194a7d2ddc918<br>---<br>M src/common/scheduler.c<br>1 file changed, 5 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/99/18699/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/scheduler.c b/src/common/scheduler.c</span><br><span>index be3ae42..276f3fd 100644</span><br><span>--- a/src/common/scheduler.c</span><br><span>+++ b/src/common/scheduler.c</span><br><span>@@ -986,9 +986,6 @@</span><br><span>                        LOGP(DL1C, LOGL_NOTICE, "%s %s on trx=%d ts=%d\n",</span><br><span>                                 (active) ? "Activating" : "Deactivating",</span><br><span>                                trx_chan_desc[i].name, l1t->trx->nr, tn);</span><br><span style="color: hsl(0, 100%, 40%);">-                 if (active)</span><br><span style="color: hsl(0, 100%, 40%);">-                             memset(chan_state, 0, sizeof(*chan_state));</span><br><span style="color: hsl(0, 100%, 40%);">-                     chan_state->active = active;</span><br><span>                      /* free burst memory, to cleanly start with burst 0 */</span><br><span>                       if (chan_state->dl_bursts) {</span><br><span>                              talloc_free(chan_state->dl_bursts);</span><br><span>@@ -998,8 +995,12 @@</span><br><span>                                talloc_free(chan_state->ul_bursts);</span><br><span>                               chan_state->ul_bursts = NULL;</span><br><span>                     }</span><br><span style="color: hsl(0, 100%, 40%);">-                       if (!active)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                        if (active)</span><br><span style="color: hsl(120, 100%, 40%);">+                           memset(chan_state, 0, sizeof(*chan_state));</span><br><span style="color: hsl(120, 100%, 40%);">+                   else</span><br><span>                                 chan_state->ho_rach_detect = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+                    chan_state->active = active;</span><br><span>              }</span><br><span>    }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/18699">change 18699</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/18699"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie9d8f8ca86195be4408db717cd3194a7d2ddc918 </div>
<div style="display:none"> Gerrit-Change-Number: 18699 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>