<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/18694">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm0808: fix endieness of call identifier<br><br>The call identifier in the ASSIGNMENT COMMAND is encoded in the wrong<br>endieness. Lets not swap the byte order since the endieness matches<br>already.<br><br>Change-Id: I6468e502f552f99ab54aec9d4b1c169fdc0adfb8<br>Related: OS#4582<br>---<br>M src/gsm/gsm0808.c<br>1 file changed, 2 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/18694/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c</span><br><span>index 23468c3..4c6aca9 100644</span><br><span>--- a/src/gsm/gsm0808.c</span><br><span>+++ b/src/gsm/gsm0808.c</span><br><span>@@ -480,7 +480,6 @@</span><br><span>        /* See also: 3GPP TS 48.008 3.2.1.1 ASSIGNMENT REQUEST */</span><br><span>    struct msgb *msg;</span><br><span>    uint16_t cic_sw;</span><br><span style="color: hsl(0, 100%, 40%);">-        uint32_t ci_sw;</span><br><span> </span><br><span>  /* Mandatory emelent! */</span><br><span>     OSMO_ASSERT(ct);</span><br><span>@@ -515,9 +514,8 @@</span><br><span> </span><br><span>   /* AoIP: Call Identifier 3.2.2.105 */</span><br><span>        if (ci) {</span><br><span style="color: hsl(0, 100%, 40%);">-               ci_sw = osmo_htonl(*ci);</span><br><span style="color: hsl(0, 100%, 40%);">-                msgb_tv_fixed_put(msg, GSM0808_IE_CALL_ID, sizeof(ci_sw),</span><br><span style="color: hsl(0, 100%, 40%);">-                                 (uint8_t *) & ci_sw);</span><br><span style="color: hsl(120, 100%, 40%);">+           msgb_tv_fixed_put(msg, GSM0808_IE_CALL_ID, sizeof(*ci),</span><br><span style="color: hsl(120, 100%, 40%);">+                                 (uint8_t *) ci);</span><br><span>   }</span><br><span> </span><br><span>        if (kc)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/18694">change 18694</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/18694"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6468e502f552f99ab54aec9d4b1c169fdc0adfb8 </div>
<div style="display:none"> Gerrit-Change-Number: 18694 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>