<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/17848">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">commands.py: fix read_binary for lengths > 256<br><br>fixed commit with commented changes<br><br>Change-Id: Ie9c61caa1412606254b44a3a24f26ad44950e73a<br>---<br>M pySim/commands.py<br>1 file changed, 11 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/commands.py b/pySim/commands.py</span><br><span>index e077289..7288b19 100644</span><br><span>--- a/pySim/commands.py</span><br><span>+++ b/pySim/commands.py</span><br><span>@@ -119,8 +119,17 @@</span><br><span>                        return (None, None)</span><br><span>          if length is None:</span><br><span>                   length = self.__len(r) - offset</span><br><span style="color: hsl(0, 100%, 40%);">-         pdu = self.cla_byte + 'b0%04x%02x' % (offset, (min(256, length) & 0xff))</span><br><span style="color: hsl(0, 100%, 40%);">-            return self._tp.send_apdu(pdu)</span><br><span style="color: hsl(120, 100%, 40%);">+                total_data = ''</span><br><span style="color: hsl(120, 100%, 40%);">+               while offset < length:</span><br><span style="color: hsl(120, 100%, 40%);">+                     chunk_len = min(255, length-offset)</span><br><span style="color: hsl(120, 100%, 40%);">+                   pdu = self.cla_byte + 'b0%04x%02x' % (offset, chunk_len)</span><br><span style="color: hsl(120, 100%, 40%);">+                      data,sw = self._tp.send_apdu(pdu)</span><br><span style="color: hsl(120, 100%, 40%);">+                     if sw == '9000':</span><br><span style="color: hsl(120, 100%, 40%);">+                              total_data += data</span><br><span style="color: hsl(120, 100%, 40%);">+                            offset += chunk_len</span><br><span style="color: hsl(120, 100%, 40%);">+                   else:</span><br><span style="color: hsl(120, 100%, 40%);">+                         raise ValueError('Failed to read (offset %d)' % (offset))</span><br><span style="color: hsl(120, 100%, 40%);">+             return total_data, sw</span><br><span> </span><br><span>    def update_binary(self, ef, data, offset=0, verify=False):</span><br><span>           self.select_file(ef)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/17848">change 17848</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/17848"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie9c61caa1412606254b44a3a24f26ad44950e73a </div>
<div style="display:none"> Gerrit-Change-Number: 17848 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: guilly@gmail.com <guilly@gmail.com> </div>
<div style="display:none"> Gerrit-Assignee: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: guilly@gmail.com <guilly@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>