<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18658">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">log: Improve log ctx information in log.Error exception<br><br>Before, it would show somethig like:<br>"""<br>osmo_gsm_tester.core.log.Error: Exited in error 255<br>"""<br><br>Now:<br>"""<br>osmo_gsm_tester.core.log.Error: rm-remote-dir(pid=24820): Exited in error 255 [trial↪4g:srsue-rftype@zmq+srsenb-rftype@zmq+mod-enb-nprb@6↪ping.py:9↪ping.py↪srsepc_10.42.42.118↪host-jenkins@10.42.42.110↪rm-remote-dir(pid=24820)]<br>"""<br><br>Change-Id: I8873f67a2f3df21c4dd552c92510535bf95e2c9d<br>---<br>M src/osmo_gsm_tester/core/log.py<br>1 file changed, 11 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/58/18658/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/core/log.py b/src/osmo_gsm_tester/core/log.py</span><br><span>index 8ae55d9..2cf1af0 100644</span><br><span>--- a/src/osmo_gsm_tester/core/log.py</span><br><span>+++ b/src/osmo_gsm_tester/core/log.py</span><br><span>@@ -88,8 +88,17 @@</span><br><span> get_process_id = lambda: '%d-%d' % (os.getpid(), time.time())</span><br><span> </span><br><span> class Error(Exception):</span><br><span style="color: hsl(0, 100%, 40%);">-    def __init__(self, *messages, **named_items):</span><br><span style="color: hsl(0, 100%, 40%);">-        super().__init__(compose_message(messages, named_items))</span><br><span style="color: hsl(120, 100%, 40%);">+    def __init__(self, *messages, origin=None, **named_items):</span><br><span style="color: hsl(120, 100%, 40%);">+        msg = ''</span><br><span style="color: hsl(120, 100%, 40%);">+        if origin is None:</span><br><span style="color: hsl(120, 100%, 40%);">+            origin = Origin.find_on_stack(f=sys._getframe(1))</span><br><span style="color: hsl(120, 100%, 40%);">+        if origin:</span><br><span style="color: hsl(120, 100%, 40%);">+            msg += origin.name() + ': '</span><br><span style="color: hsl(120, 100%, 40%);">+        msg += compose_message(messages, named_items)</span><br><span style="color: hsl(120, 100%, 40%);">+        if origin and origin._parent is not None:</span><br><span style="color: hsl(120, 100%, 40%);">+            deeper_origins = origin.ancestry_str()</span><br><span style="color: hsl(120, 100%, 40%);">+            msg += ' [%s]' % deeper_origins</span><br><span style="color: hsl(120, 100%, 40%);">+        super().__init__(msg)</span><br><span> </span><br><span> class LogTarget:</span><br><span>     all_targets = []</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18658">change 18658</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18658"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8873f67a2f3df21c4dd552c92510535bf95e2c9d </div>
<div style="display:none"> Gerrit-Change-Number: 18658 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>