<p>Patch set 6:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18641">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py">File src/target/trx_toolkit/fake_trx.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py@241">Patch Set #6, Line 241:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"># Apply RSSI based on transmitter:<br>             if not self.fake_rssi_enabled:<br>                        msg.rssi = src_trx.tx_power - src_msg.pwr - self.PATH_LOSS_DEFAULT<br>            else: # Apply fake RSSI<br>                       msg.rssi = self.rssi<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Feel free to move this computation to @property self.rssi (line 156).</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18641">change 18641</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/18641"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3ee1a32ca22c3272e66b3ca78e4f67d283844c80 </div>
<div style="display:none"> Gerrit-Change-Number: 18641 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 03 Jun 2020 19:43:03 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>