<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/18651">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-mslookup-client: fix segfault for respond_error() caller<br><br>respond_error() passes r == 0. On error, consider it the last response for that<br>request.<br><br>Change-Id: I1acb0b8aa00c098d1f1f1cc17035daa38ce29fd3<br>---<br>M src/mslookup/osmo-mslookup-client.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/51/18651/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mslookup/osmo-mslookup-client.c b/src/mslookup/osmo-mslookup-client.c</span><br><span>index 4a9e587..a200a7e 100644</span><br><span>--- a/src/mslookup/osmo-mslookup-client.c</span><br><span>+++ b/src/mslookup/osmo-mslookup-client.c</span><br><span>@@ -584,11 +584,11 @@</span><br><span>    llist_for_each_entry_safe(c, n, &globals.socket_clients, entry) {</span><br><span>                if (!strcmp(query_str, c->query_str)) {</span><br><span>                   socket_client_respond_result(c, g_buf);</span><br><span style="color: hsl(0, 100%, 40%);">-                 if (r->last)</span><br><span style="color: hsl(120, 100%, 40%);">+                       if (!r || r->last)</span><br><span>                                socket_client_close(c);</span><br><span>              }</span><br><span>    }</span><br><span style="color: hsl(0, 100%, 40%);">-       if (r->last)</span><br><span style="color: hsl(120, 100%, 40%);">+       if (!r || r->last)</span><br><span>                globals.requests_handled++;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/18651">change 18651</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/18651"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1acb0b8aa00c098d1f1f1cc17035daa38ce29fd3 </div>
<div style="display:none"> Gerrit-Change-Number: 18651 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>