<p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/18651">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/18651/1/src/mslookup/osmo-mslookup-client.c">File src/mslookup/osmo-mslookup-client.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/18651/1/src/mslookup/osmo-mslookup-client.c@587">Patch Set #1, Line 587:</a> <code style="font-family:monospace,monospace">                  if (!r || r->last)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">would be nice documenting this behavior (like r=NULL being passed by error.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">see here...</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/18651/1/src/mslookup/osmo-mslookup-client.c@597">Patch Set #1, Line 597:</a> <code style="font-family:monospace,monospace">   respond_result(query_str, NULL);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">...here.</p><p style="white-space: pre-wrap; word-wrap: break-word;">(This is "just" a cmdline tool, no public API/ABI)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/18651">change 18651</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/18651"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1acb0b8aa00c098d1f1f1cc17035daa38ce29fd3 </div>
<div style="display:none"> Gerrit-Change-Number: 18651 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 03 Jun 2020 17:29:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>